fix: add volatile and test for concurrency#2389
Merged
arnaudgiuliani merged 1 commit intoApr 9, 2026
Merged
Conversation
inemtsev
force-pushed
the
fix/scope-closed-volatile
branch
from
89ae0da to
7ec1ec7
Compare
inemtsev
force-pushed
the
fix/scope-closed-volatile
branch
from
7ec1ec7 to
2f33846
Compare
Contributor
Author
|
@arnaudgiuliani Do you think we can include this in the next patch version? |
Member
|
will be in 4.2.1 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After investigating some concurrency issues we've had with version 4.1.1, I realized most of these were fixed with 4.2.0.
But, I believe this one can still cause an issue in rare cases. _closed should be volatile because checkScopeIsOpen() reads _closed outside any lock the JVM is free to let other threads see a stale cached value of false even after close() has fully returned.
It was hard to create a test, but I managed to reproduce with some AI help.
Adding volatile fixes the failing test