fix(viewmodel): keep useIndexedValues in AndroidParametersHolder#2399
Open
0xZhangKe wants to merge 1 commit into
Open
fix(viewmodel): keep useIndexedValues in AndroidParametersHolder#23990xZhangKe wants to merge 1 commit into
0xZhangKe wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes ViewModel parameter wrapping so that ParametersHolder.useIndexedValues is preserved when ParametersDefinition values are wrapped by AndroidParametersHolder, maintaining indexed-parameter semantics (e.g., from parameterArrayOf(...)) during ViewModel resolution.
Changes:
- Pass through
useIndexedValuesfrom the originalParametersHolderintoAndroidParametersHolder. - Switch
AndroidParametersHolder’s superclass constructor call to use named parameters (_values,useIndexedValues).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
0xZhangKe
force-pushed
the
fix/array_parameters_not_working
branch
from
c01538f to
da8401e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix ViewModel parameter wrapping to preserve
ParametersHolder.useIndexedValues.Details
parameterArrayOf(...)setsuseIndexedValues = true, but this flag was lost when parameters were wrapped byAndroidParametersHolderduring ViewModel resolution.This change keeps the original flag so indexed parameter semantics are preserved.