RXR-3163: minimal change to undo breaking change in PR#59#60
Merged
Conversation
roninsightrx
approved these changes
Jun 3, 2026
roninsightrx
left a comment
roninsightrx
left a comment
Contributor
There was a problem hiding this comment.
lgtm.
Not sure either why weights are not respected in the new approach, but can investigate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #59, we inadvertently introduced an issue so that obj$vcov_full sometimes had a different value, when we expected it to have parity from before.
This PR minimally reverts some of the changes made in that PR so that we continue to use the (slow) numDeriv::hessian as before, rather than the FOCE VCOV.
Fixes necessary to get the FOCE VCOV up to snuff will be made in a separate PR.