Skip to content

Commit 113871c

Browse files
committed
fix: exclude itk-wasm test-pipelines from workspace to break pixi symlink loop
test-pipelines (packages/core/typescript/itk-wasm/test/pipelines/typescript) is nested inside itk-wasm and depends on itk-wasm via workspace:*, creating a self-referential symlink loop in node_modules. pixi does not respect .gitignore and errors on this loop when walking package directories. - Exclude packages/core/typescript/itk-wasm/test/** from pnpm-workspace.yaml (follows existing create-itk-wasm/test exclusion pattern) - Change test-pipelines deps from workspace:* to link: protocol for standalone installation - Add pnpm install to itk-wasm start script since test-pipelines deps are no longer auto-installed by root workspace install
1 parent 7a78678 commit 113871c

4 files changed

Lines changed: 7 additions & 51 deletions

File tree

packages/core/typescript/itk-wasm/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
"build:workerBundle": "esbuild --bundle --format=esm --outfile=./dist/pipeline/web-workers/bundles/itk-wasm-pipeline.worker.js ./dist/pipeline/web-workers/itk-wasm-pipeline.worker.js",
2828
"build:workerBundleForTesting": "esbuild --bundle --format=esm --outfile=./test/pipelines/typescript/test/browser/demo-app/public/itk-wasm-pipeline.worker.js ./dist/pipeline/web-workers/itk-wasm-pipeline.worker.js && shx cp -r ./test/data/ ./test/pipelines/typescript/test/browser/demo-app/public/",
2929
"build:workerMinBundle": "esbuild --minify --bundle --format=esm --outfile=./dist/pipeline/web-workers/bundles/itk-wasm-pipeline.min.worker.js ./dist/pipeline/web-workers/itk-wasm-pipeline.worker.js",
30-
"start": "pnpm build:workerBundleForTesting && cd test/pipelines/typescript && pnpm build && pnpm start",
30+
"start": "pnpm build:workerBundleForTesting && cd test/pipelines/typescript && pnpm install --no-frozen-lockfile && pnpm build && pnpm start",
3131
"test:wasi": "pnpm test:buildTestPipelines:wasi && pnpm test:runTestPipelines && pnpm test:bindgenTestPipelines:python",
3232
"test": "pnpm test:lint && pnpm test:testPipelines && pnpm test:node && pnpm test:bindgenTestPipelines:python && pnpm test:browser",
3333
"test:lint": "ts-standard --fix \"src/**/*.ts\" && standard --fix \"test/node/**/*.js\"",

packages/core/typescript/itk-wasm/test/pipelines/typescript/package.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,13 +33,13 @@
3333
"author": "",
3434
"license": "Apache-2.0",
3535
"dependencies": {
36-
"itk-wasm": "workspace:*"
36+
"itk-wasm": "link:../../.."
3737
},
3838
"devDependencies": {
39-
"@itk-wasm/demo-app": "workspace:*",
40-
"@itk-wasm/image-io": "workspace:*",
41-
"@itk-wasm/mesh-io": "workspace:*",
42-
"@itk-wasm/transform-io": "workspace:*",
39+
"@itk-wasm/demo-app": "link:../../../../demo-app",
40+
"@itk-wasm/image-io": "link:../../../../../../image-io/typescript",
41+
"@itk-wasm/mesh-io": "link:../../../../../../mesh-io/typescript",
42+
"@itk-wasm/transform-io": "link:../../../../../../transform-io/typescript",
4343
"@types/node": "^20.2.5",
4444
"esbuild": "^0.25.0",
4545
"shx": "^0.3.4",

pnpm-lock.yaml

Lines changed: 0 additions & 45 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pnpm-workspace.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ packages:
99
- 'examples/mean-squares-versor-registration'
1010
- 'examples/mean-squares-versor-registration/typescript'
1111
- '!packages/core/typescript/create-itk-wasm/test/**'
12+
- '!packages/core/typescript/itk-wasm/test/**'
1213
- '!**/src'
1314
- '!**/dist'
1415
- '!**/pyodide'

0 commit comments

Comments
 (0)