Skip to content

feat: add transform package#1392

Merged
thewtex merged 8 commits intoInsightSoftwareConsortium:mainfrom
thewtex:transform-package
Jun 23, 2025
Merged

feat: add transform package#1392
thewtex merged 8 commits intoInsightSoftwareConsortium:mainfrom
thewtex:transform-package

Conversation

@thewtex
Copy link
Copy Markdown
Member

@thewtex thewtex commented Jun 10, 2025

No description provided.

@thewtex thewtex force-pushed the transform-package branch 3 times, most recently from 07b0d83 to 186cf4c Compare June 17, 2025 02:12
@thewtex thewtex force-pushed the transform-package branch from 186cf4c to aa46e1a Compare June 18, 2025 03:59
@thewtex thewtex force-pushed the transform-package branch from 3f2c7db to 4ffd17b Compare June 20, 2025 02:21
@thewtex thewtex changed the title WIP: feat: add transform package feat: add transform package Jun 20, 2025
@thewtex thewtex marked this pull request as ready for review June 20, 2025 02:21
@thewtex thewtex requested a review from Copilot June 20, 2025 16:49
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Add a new transform package that provides spatial transformation pipelines, TypeScript bindings, and test data, while integrating build and test tasks into the global manifest.

  • Introduce packages/transform with TS package, C++ pipelines, test data, and CMake support
  • Update top-level pixi.toml and itk_wasm_env.bash to include transform build/test tasks and environment vars
  • Add manifest (pixi.toml), package definitions, and CMake rules for native and WASM transform pipelines

Reviewed Changes

Copilot reviewed 15 out of 17 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
pixi.toml Register global build/test tasks for transform package
packages/transform/typescript/package.json Define new TypeScript package and build scripts for transform
packages/transform/pixi.toml Pixi manifest for transform package pipelines
packages/transform/create-transform.cxx C++ implementation of create-*-transform pipelines
packages/transform/CMakeLists.txt CMake setup for transform pipelines and tests
itk_wasm_env.bash Export environment variables for transform test data downloads
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (2)

packages/transform/pixi.toml:4

  • The description appears copied from another package and does not reflect the transform pipelines. Update it to describe spatial transform pipelines.
description = "Pipelines for downsampling images."

packages/transform/typescript/package.json:18

  • [nitpick] The TS package has no real test script and fails by default. Consider adding real tests or removing the placeholder to ensure test coverage.
    "test": "echo \"Error: no test specified\" && exit 1",

Comment thread packages/transform/create-transform.cxx
Comment thread itk_wasm_env.bash Outdated
…-io package

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@thewtex thewtex merged commit 0145347 into InsightSoftwareConsortium:main Jun 23, 2025
80 checks passed
@thewtex thewtex deleted the transform-package branch June 23, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants