STYLE: Use std::array instead of std::vector for local variables in test

Declared those variables static constexpr.

Author: N-Dekker

Modules/Core/Common/test/itkConstNeighborhoodIteratorTest.cxx

@@ -18,6 +18,7 @@
 
 #include "itkNeighborhoodIteratorTestCommon.hxx"
 #include "itkConstNeighborhoodIterator.h"
+#include <array>
 
 void
 println(const char * s)
@@ -356,17 +357,8 @@ itkConstNeighborhoodIteratorTest(int, char *[])
     using NeighborhoodIteratorType = itk::ConstNeighborhoodIterator<ChangeRegionTestImageType>;
     NeighborhoodIteratorType neighborhoodIterator(neighborhoodRadius, image, region1);
 
-    std::vector<int> expectedValuesRegion1(9);
-    expectedValuesRegion1[0] = 0;
-    expectedValuesRegion1[1] = 255;
-    expectedValuesRegion1[2] = 255;
-    expectedValuesRegion1[3] = 0;
-    expectedValuesRegion1[4] = 255;
-    expectedValuesRegion1[5] = 255;
-    expectedValuesRegion1[6] = 0;
-    expectedValuesRegion1[7] = 255;
-    expectedValuesRegion1[8] = 255;
-    unsigned int counter = 0;
+    static constexpr std::array<int, 9> expectedValuesRegion1{ 0, 255, 255, 0, 255, 255, 0, 255, 255 };
+    unsigned int                        counter = 0;
 
     for (NeighborhoodIteratorType::ConstIterator pixelIterator = neighborhoodIterator.Begin();
          pixelIterator < neighborhoodIterator.End();
@@ -387,16 +379,7 @@ itkConstNeighborhoodIteratorTest(int, char *[])
     neighborhoodIterator.SetRegion(region2);
     neighborhoodIterator.GoToBegin();
 
-    std::vector<int> expectedValuesRegion2(9);
-    expectedValuesRegion2[0] = 255;
-    expectedValuesRegion2[1] = 255;
-    expectedValuesRegion2[2] = 255;
-    expectedValuesRegion2[3] = 255;
-    expectedValuesRegion2[4] = 255;
-    expectedValuesRegion2[5] = 255;
-    expectedValuesRegion2[6] = 255;
-    expectedValuesRegion2[7] = 255;
-    expectedValuesRegion2[8] = 255;
+    static constexpr std::array<int, 9> expectedValuesRegion2{ 255, 255, 255, 255, 255, 255, 255, 255, 255 };
     counter = 0;
     for (NeighborhoodIteratorType::ConstIterator pixelIterator = neighborhoodIterator.Begin();
          pixelIterator < neighborhoodIterator.End();

Modules/Core/Common/test/itkConstShapedNeighborhoodIteratorTest.cxx

@@ -18,6 +18,7 @@
 
 #include "itkNeighborhoodIteratorTestCommon.hxx"
 #include "itkConstShapedNeighborhoodIterator.h"
+#include <array>
 
 void
 PrintShapedNeighborhood(const itk::ConstShapedNeighborhoodIterator<TestImageType> & n)
@@ -470,9 +471,7 @@ itkConstShapedNeighborhoodIteratorTest(int, char *[])
       shapedNeighborhoodIterator.ActivateOffset(offset_item);
     }
 
-    std::vector<int> expectedValuesRegion1(2);
-    expectedValuesRegion1[0] = 0;
-    expectedValuesRegion1[1] = 255;
+    static constexpr std::array<int, 2> expectedValuesRegion1{ 0, 255 };
 
     unsigned int counter = 0;
     // while(!shapedNeighborhoodIterator.IsAtEnd()) // no need for this loop as we are only iterating over a 1x1 region
@@ -500,9 +499,7 @@ itkConstShapedNeighborhoodIteratorTest(int, char *[])
     shapedNeighborhoodIterator.SetRegion(region2);
     shapedNeighborhoodIterator.GoToBegin();
 
-    std::vector<int> expectedValuesRegion2(2);
-    expectedValuesRegion2[0] = 255;
-    expectedValuesRegion2[1] = 255;
+    static constexpr std::array<int, 2> expectedValuesRegion2{ 255, 255 };
 
     counter = 0;
     // while(!shapedNeighborhoodIterator.IsAtEnd()) // no need for this loop as we are only iterating over a 1x1 region

Modules/Core/Common/test/itkImageRegionIteratorTest.cxx

@@ -19,6 +19,7 @@
 #include <iostream>
 
 #include "itkImageRegionIterator.h"
+#include <array>
 
 
 // This routine is used to make sure that we call the "const" version
@@ -172,12 +173,8 @@ itkImageRegionIteratorTest(int, char *[])
 
     itk::ImageRegionConstIterator<TestImageType> imageIterator(image, region1);
 
-    std::vector<int> expectedValuesRegion1(4);
-    expectedValuesRegion1[0] = 0;
-    expectedValuesRegion1[1] = 255;
-    expectedValuesRegion1[2] = 0;
-    expectedValuesRegion1[3] = 255;
-    unsigned int counter = 0;
+    static constexpr std::array<int, 4> expectedValuesRegion1{ 0, 255, 0, 255 };
+    unsigned int                        counter = 0;
     while (!imageIterator.IsAtEnd())
     {
       if (imageIterator.Get() != expectedValuesRegion1[counter])
@@ -196,11 +193,7 @@ itkImageRegionIteratorTest(int, char *[])
     imageIterator.SetRegion(region2);
     imageIterator.GoToBegin();
 
-    std::vector<int> expectedValuesRegion2(4);
-    expectedValuesRegion2[0] = 255;
-    expectedValuesRegion2[1] = 255;
-    expectedValuesRegion2[2] = 255;
-    expectedValuesRegion2[3] = 255;
+    static constexpr std::array<int, 4> expectedValuesRegion2{ 255, 255, 255, 255 };
     counter = 0;
     while (!imageIterator.IsAtEnd())
     {

Modules/Core/Common/test/itkImageScanlineIteratorTest1.cxx

@@ -19,6 +19,7 @@
 #include <iostream>
 
 #include "itkImageScanlineIterator.h"
+#include <array>
 
 
 // This routine is used to make sure that we call the "const" version
@@ -188,12 +189,8 @@ itkImageScanlineIteratorTest1(int, char *[])
 
     itk::ImageScanlineConstIterator<TestImageType> imageIterator(image, region1);
 
-    std::vector<int> expectedValuesRegion1(4);
-    expectedValuesRegion1[0] = 0;
-    expectedValuesRegion1[1] = 255;
-    expectedValuesRegion1[2] = 0;
-    expectedValuesRegion1[3] = 255;
-    unsigned int counter = 0;
+    static constexpr std::array<int, 4> expectedValuesRegion1{ 0, 255, 0, 255 };
+    unsigned int                        counter = 0;
     while (!imageIterator.IsAtEnd())
     {
       while (!imageIterator.IsAtEndOfLine())
@@ -216,11 +213,7 @@ itkImageScanlineIteratorTest1(int, char *[])
     imageIterator.SetRegion(region2);
     imageIterator.GoToBegin();
 
-    std::vector<int> expectedValuesRegion2(4);
-    expectedValuesRegion2[0] = 255;
-    expectedValuesRegion2[1] = 255;
-    expectedValuesRegion2[2] = 255;
-    expectedValuesRegion2[3] = 255;
+    static constexpr std::array<int, 4> expectedValuesRegion2{ 255, 255, 255, 255 };
     counter = 0;
     while (!imageIterator.IsAtEnd())
     {