STYLE: Address Greptile review on SmoothingRecursiveYvvGaussianFilter

Greptile P1/P2 findings:

- itk-module.cmake: rename `GPU_DEPENDANCIES` -> `GPU_DEPENDENCIES`
  (typo).
- src/CMakeLists.txt: drop `${INRIA_ITK_LIBRARIES}` /
  `${OPENCL_LIBRARIES}` (undefined in ITK; OpenCL linkage is provided
  by the `ITKGPUCommon` module dep). Drop the `GPU_HANDLES_DOUBLE` /
  `NVIDIA_GPU` guards (variables are never set in ITK's build, so the
  branches were unreachable).
- test/CMakeLists.txt: same `GPU_HANDLES_DOUBLE` / `NVIDIA_GPU` guard
  removal.
- src/OpenCLInfo.cpp: remove the standalone-only diagnostic utility
  (it has its own `main()` and is not listed in src/CMakeLists.txt).
- include/itkGPUSmoothingRecursiveYvvGaussianImageFilter.h{,xx}:
  replace raw `new ScalarRealType[N]` for `m_Bvalues` and
  `m_CPUMatrix` with `std::vector<ScalarRealType>`. The previous code
  leaked on every `SetUp()` re-entry (the destructor is `= default`
  and there is no matching `delete[]`).  `SetCPUBufferPointer` now
  uses `.data()`.

Author: hjmjohnson

Modules/Filtering/SmoothingRecursiveYvvGaussianFilter/include/itkGPUSmoothingRecursiveYvvGaussianImageFilter.h

@@ -28,6 +28,7 @@
 #  include "itkSmoothingRecursiveYvvGaussianImageFilter.h"
 #  include "itkOpenCLUtil.h"
 #  include "itkGPUImageToImageFilter.h"
+#  include <vector>
 
 namespace itk
 {
@@ -170,14 +171,14 @@ class ITK_EXPORT GPUSmoothingRecursiveYvvGaussianImageFilter
 
   std::ostringstream defines;
 
-  ScalarRealType   m_B1;
-  ScalarRealType   m_B2;
-  ScalarRealType   m_B3;
-  ScalarRealType   m_B;
-  ScalarRealType * m_Bvalues;
+  ScalarRealType              m_B1;
+  ScalarRealType              m_B2;
+  ScalarRealType              m_B3;
+  ScalarRealType              m_B;
+  std::vector<ScalarRealType> m_Bvalues;
 
   // Initialization matrix for anti-causal pass
-  ScalarRealType * m_CPUMatrix;
+  std::vector<ScalarRealType> m_CPUMatrix;
 
   using GPUDataPointer = GPUDataManager::Pointer;
 

Modules/Filtering/SmoothingRecursiveYvvGaussianFilter/include/itkGPUSmoothingRecursiveYvvGaussianImageFilter.hxx

@@ -106,7 +106,7 @@ GPUSmoothingRecursiveYvvGaussianImageFilter<TInputImage, TOutputImage>::SetUp(Sc
     ScalarRealType m1 = 1.10783;
     ScalarRealType m2 = 1.40586;
     ScalarRealType scale = (m0 + q) * (m1 * m1 + m2 * m2 + 2 * m1 * q + q * q);
-    m_Bvalues = new ScalarRealType[4];
+    m_Bvalues.assign(4, ScalarRealType{});
 
     m_B1 = m_Bvalues[1] = q * (2 * m0 * m1 + m1 * m1 + m2 * m2 + (2 * m0 + 4 * m1) * q + 3 * q * q) / scale;
     m_B2 = m_Bvalues[2] = -q * q * (m0 + 2 * m1 + 3 * q) / scale;
@@ -117,7 +117,7 @@ GPUSmoothingRecursiveYvvGaussianImageFilter<TInputImage, TOutputImage>::SetUp(Sc
 
     // M Matrix for initialization on backward pass, from Triggs and Sdika, IEEE
     // TSP
-    m_CPUMatrix = new ScalarRealType[9];
+    m_CPUMatrix.assign(9, ScalarRealType{});
     const ScalarRealType factor =
       (1 + m_B1 - m_B2 + m_B3) * (1 - m_B1 - m_B2 - m_B3) * (1 + m_B2 + (m_B1 - m_B3) * m_B3);
 
@@ -261,20 +261,20 @@ GPUSmoothingRecursiveYvvGaussianImageFilter<TInputImage, TOutputImage>::Allocate
 {
   m_GPUBCoefficientsDataManager = GPUDataManager::New();
   m_GPUBCoefficientsDataManager->SetBufferSize(4 * sizeof(ScalarRealType));
-  m_GPUBCoefficientsDataManager->SetCPUBufferPointer(m_Bvalues);
+  m_GPUBCoefficientsDataManager->SetCPUBufferPointer(m_Bvalues.data());
   m_GPUBCoefficientsDataManager->SetBufferFlag(CL_MEM_READ_ONLY);
   m_GPUBCoefficientsDataManager->Allocate();
-  if (m_Bvalues)
+  if (!m_Bvalues.empty())
   {
     m_GPUBCoefficientsDataManager->SetGPUDirtyFlag(true);
   }
 
   m_GPUMMatrixDataManager = GPUDataManager::New();
   m_GPUMMatrixDataManager->SetBufferSize(9 * sizeof(ScalarRealType));
-  m_GPUMMatrixDataManager->SetCPUBufferPointer(m_CPUMatrix);
+  m_GPUMMatrixDataManager->SetCPUBufferPointer(m_CPUMatrix.data());
   m_GPUMMatrixDataManager->SetBufferFlag(CL_MEM_READ_ONLY);
   m_GPUMMatrixDataManager->Allocate();
-  if (m_CPUMatrix)
+  if (!m_CPUMatrix.empty())
   {
     m_GPUMMatrixDataManager->SetGPUDirtyFlag(true);
   }

Modules/Filtering/SmoothingRecursiveYvvGaussianFilter/itk-module.cmake

@@ -10,7 +10,7 @@
 # define the dependencies of the include module and the tests
 set(ModuleName "SmoothingRecursiveYvvGaussianFilter")
 if(ITK_USE_GPU)
-  set(${ModuleName}_GPU_DEPENDANCIES "ITKGPUSmoothing")
+  set(${ModuleName}_GPU_DEPENDENCIES "ITKGPUSmoothing")
   set(${ModuleName}_GPU_COMMON "ITKGPUCommon")
 endif()
 itk_module(
@@ -20,7 +20,7 @@ itk_module(
     ITKIOImageBase
     ITKImageFilterBase
     ITKSmoothing
-    ${${ModuleName}_GPU_DEPENDANCIES}
+    ${${ModuleName}_GPU_DEPENDENCIES}
     ${${ModuleName}_GPU_COMMON}
   TEST_DEPENDS
     ITKTestKernel #to handle IO in src

Modules/Filtering/SmoothingRecursiveYvvGaussianFilter/src/CMakeLists.txt

@@ -1,25 +1,11 @@
 if(ITK_USE_GPU)
-  if(GPU_HANDLES_DOUBLE)
-    add_definitions(-DWITH_DOUBLE)
-  endif()
-
   set(GPU_SRC)
-
   set(GPU_Kernels GPUSmoothingRecursiveYvvGaussianImageFilter.cl)
 
   #essentially a #define GPU.
   add_definitions(-DGPU)
 
-  if(NVIDIA_GPU)
-    add_definitions(-DNVIDIA)
-  endif()
-
   write_gpu_kernels("${GPU_Kernels}" GPU_SRC)
 
   itk_module_add_library(${itk-module} ${GPU_SRC})
-  target_link_libraries(
-    ${itk-module}
-    ${INRIA_ITK_LIBRARIES}
-    ${OPENCL_LIBRARIES}
-  )
 endif()

Modules/Filtering/SmoothingRecursiveYvvGaussianFilter/src/OpenCLInfo.cpp

@@ -3,15 +3,6 @@ itk_module_test()
 if(ITK_USE_GPU)
   add_definitions(-DGPU)
 
-  if(GPU_HANDLES_DOUBLE)
-    add_definitions(-DWITH_DOUBLE)
-  endif()
-
-  if(NVIDIA_GPU)
-    add_definitions(-DNVIDIA)
-    message(STATUS "NVIDIA platform detected")
-  endif()
-
   include_directories("${${itk-module}_SOURCE_DIR}/include")
   include_directories("${${itk-module}KernelDir}")