BUG: Remove shadow declarations in RGBGibbsPriorFilter

RGBGibbsPriorFilter declared its own m_NumberOfClasses and
m_MaximumNumberOfIterations that shadowed identically-named members
in the base MRFImageFilter. Set/Get accessors were hand-written
overrides whose only purpose was to direct `this->m_*` at the
subclass shadow.

Virtual dispatch made the shadow work correctly through the public
API, but every instance carried two orphaned 8-byte fields and any
future MRFImageFilter method that reads m_NumberOfClasses or
m_MaximumNumberOfIterations directly would silently see stale
defaults for RGBGibbsPriorFilter instances.

Remove the shadow declarations and the 4 redundant accessor
overrides. Preserve the subclass-specific default
MaximumNumberOfIterations=10 (vs base default 50) by calling the
inherited setter from the constructor. Drop two PrintSelf lines that
duplicated output from Superclass::PrintSelf.

GTest suite from the preceding commit confirms zero observable API
change: defaults, Set/Get round-trip via subclass and base pointer,
and MTime semantics all match the pre-fix behavior.

Author: hjmjohnson

Modules/Segmentation/MarkovRandomFieldsClassifiers/include/itkRGBGibbsPriorFilter.h

@@ -130,45 +130,6 @@ class ITK_TEMPLATE_EXPORT RGBGibbsPriorFilter : public MRFImageFilter<TInputImag
   void
   SetClassifier(typename ClassifierType::Pointer ptrToClassifier);
 
-  /** Set the number of classes. */
-  void
-  SetNumberOfClasses(const unsigned int numberOfClasses) override
-  {
-    itkDebugMacro("setting NumberOfClasses to " << numberOfClasses);
-    if (this->m_NumberOfClasses != numberOfClasses)
-    {
-      this->m_NumberOfClasses = numberOfClasses;
-      this->Modified();
-    }
-  }
-
-  /** Get the number of classes. */
-  [[nodiscard]] unsigned int
-  GetNumberOfClasses() const override
-  {
-    return this->m_NumberOfClasses;
-  }
-
-  /** Set/Get the number of iteration of the Iterated Conditional Mode
-   * (ICM) algorithm. A default value is set at 50 iterations. */
-  void
-  SetMaximumNumberOfIterations(const unsigned int numberOfIterations) override
-  {
-    itkDebugMacro("setting MaximumNumberOfIterations to " << numberOfIterations);
-    if (this->m_MaximumNumberOfIterations != numberOfIterations)
-    {
-      this->m_MaximumNumberOfIterations = numberOfIterations;
-      this->Modified();
-    }
-  }
-
-  /** Get the number of iterations of the Iterated Conditional Mode
-   * (ICM) algorithm. */
-  [[nodiscard]] unsigned int
-  GetMaximumNumberOfIterations() const override
-  {
-    return this->m_MaximumNumberOfIterations;
-  }
 
   /** Set/Get the threshold for the object size. */
   /** @ITKStartGrouping */
@@ -252,12 +213,6 @@ class ITK_TEMPLATE_EXPORT RGBGibbsPriorFilter : public MRFImageFilter<TInputImag
   /** Output. */
   LabelledImageType m_LabelledImage{};
 
-  /** Number of classes that need to be classified. */
-  unsigned int m_NumberOfClasses{ 0 };
-
-  /** Maximum number of iterations. */
-  unsigned int m_MaximumNumberOfIterations{ 10 };
-
   typename ClassifierType::Pointer m_ClassifierPtr{};
 
   /** Threshold for the existence of a boundary. */

Modules/Segmentation/MarkovRandomFieldsClassifiers/include/itkRGBGibbsPriorFilter.hxx

@@ -41,6 +41,7 @@ RGBGibbsPriorFilter<TInputImage, TClassifiedImage>::RGBGibbsPriorFilter()
 
 {
   m_StartPoint.Fill(0);
+  this->SetMaximumNumberOfIterations(10);
 }
 
 template <typename TInputImage, typename TClassifiedImage>
@@ -165,7 +166,7 @@ void
 RGBGibbsPriorFilter<TInputImage, TClassifiedImage>::SetClassifier(typename ClassifierType::Pointer ptrToClassifier)
 {
   m_ClassifierPtr = ptrToClassifier;
-  m_ClassifierPtr->SetNumberOfClasses(m_NumberOfClasses);
+  m_ClassifierPtr->SetNumberOfClasses(this->GetNumberOfClasses());
 }
 
 template <typename TInputImage, typename TClassifiedImage>
@@ -683,8 +684,6 @@ RGBGibbsPriorFilter<TInputImage, TClassifiedImage>::PrintSelf(std::ostream & os,
 {
   Superclass::PrintSelf(os, indent);
 
-  os << indent << "NumberOfClasses: " << m_NumberOfClasses << std::endl;
-  os << indent << "MaximumNumberOfIterations: " << m_MaximumNumberOfIterations << std::endl;
   os << indent << "ObjectThreshold: " << m_ObjectThreshold << std::endl;
   os << indent << "BoundaryGradient: " << m_BoundaryGradient << std::endl;
   os << indent << "CliqueWeight_1: " << m_CliqueWeight_1 << std::endl;