Merge pull request #6430 from hjmjohnson/remove-wno-deprecated

COMP: Remove default -Wno-deprecated from the ITK warning flags

Author: hjmjohnson

CMake/ITKSetStandardCompilerFlags.cmake

@@ -133,7 +133,6 @@ function(check_compiler_warning_flags c_warning_flags_var cxx_warning_flags_var)
   # Check this list on C++ compiler only
   set(
     cxx_flags
-    -Wno-deprecated
     -Wno-invalid-offsetof
     -Wno-undefined-var-template # suppress invalid warning when explicitly instantiated in another translation unit
     -Woverloaded-virtual

Modules/Core/Common/test/itkAggregateTypesGTest.cxx

@@ -133,7 +133,7 @@ class CommonTests
     const AggregateType knownAll7s{ { 7, 7, 7, 7 } };
     const AggregateType knownAll6s{ { 6, 6, 6, 6 } };
 
-    EXPECT_EQ(std::is_pod_v<AggregateType>, true);
+    EXPECT_EQ((std::is_standard_layout_v<AggregateType> && std::is_trivial_v<AggregateType>), true);
     EXPECT_EQ(AggregateType::Dimension, 4);
 
     AggregateType index1 = { { 10, 20, 30, 40 } };
@@ -324,7 +324,7 @@ TEST(Specialized, IndexOffset)
 
 TEST(Specialized, Index)
 {
-  EXPECT_EQ(std::is_pod_v<itk::Index<13>>, true);
+  EXPECT_EQ((std::is_standard_layout_v<itk::Index<13>> && std::is_trivial_v<itk::Index<13>>), true);
   EXPECT_EQ(itk::Index<2>::GetIndexDimension(), 2);
 
   using IndexType = itk::Index<4>;
@@ -348,7 +348,7 @@ TEST(Specialized, Index)
 TEST(Specialized, Offset)
 {
 
-  EXPECT_EQ(std::is_pod_v<itk::Offset<13>>, true);
+  EXPECT_EQ((std::is_standard_layout_v<itk::Offset<13>> && std::is_trivial_v<itk::Offset<13>>), true);
   EXPECT_EQ(itk::Offset<13>::GetOffsetDimension(), 13);
 
   using OffsetType = itk::Offset<4>;
@@ -371,7 +371,7 @@ TEST(Specialized, Offset)
 
 TEST(Specialized, Size)
 {
-  EXPECT_EQ(std::is_pod_v<itk::Size<13>>, true);
+  EXPECT_EQ((std::is_standard_layout_v<itk::Size<13>> && std::is_trivial_v<itk::Size<13>>), true);
   EXPECT_EQ(itk::Size<7>::GetSizeDimension(), 7);
 
   using SizeType = itk::Size<4>;

Modules/Core/Mesh/include/itkTriangleMeshToBinaryImageFilter.h

@@ -44,6 +44,9 @@ class Point1D
 
   Point1D(const Point1D & point) = default;
 
+  Point1D &
+  operator=(const Point1D &) = default;
+
   [[nodiscard]] double
   getX() const
   {

Modules/Core/QuadEdgeMesh/include/itkQuadEdgeMeshBaseIterator.h

@@ -243,6 +243,9 @@ class ITK_TEMPLATE_EXPORT QuadEdgeMeshIterator : public QuadEdgeMeshBaseIterator
 
   QuadEdgeMeshIterator(const QuadEdgeMeshIterator &) = default;
 
+  Self &
+  operator=(const Self &) = default;
+
   ~QuadEdgeMeshIterator() override = default;
 
   QuadEdgeType *
@@ -281,6 +284,9 @@ class ITK_TEMPLATE_EXPORT QuadEdgeMeshIteratorGeom : public QuadEdgeMeshIterator
 
   QuadEdgeMeshIteratorGeom(const QuadEdgeMeshIteratorGeom &) = default;
 
+  QuadEdgeMeshIteratorGeom &
+  operator=(const QuadEdgeMeshIteratorGeom &) = default;
+
   OriginRefType
   operator*()
   {
@@ -314,6 +320,9 @@ class ITK_TEMPLATE_EXPORT QuadEdgeMeshConstIterator : public QuadEdgeMeshBaseIte
 
   QuadEdgeMeshConstIterator(const QuadEdgeMeshConstIterator &) = default;
 
+  Self &
+  operator=(const Self &) = default;
+
   ~QuadEdgeMeshConstIterator() override = default;
 
   Self &
@@ -361,6 +370,9 @@ class ITK_TEMPLATE_EXPORT QuadEdgeMeshConstIteratorGeom : public QuadEdgeMeshCon
 
   QuadEdgeMeshConstIteratorGeom(const QuadEdgeMeshConstIteratorGeom &) = default;
 
+  Self &
+  operator=(const Self &) = default;
+
   ~QuadEdgeMeshConstIteratorGeom() override = default;
 
   Self &

Modules/IO/GE/src/Ge5xHdr.h

@@ -875,9 +875,9 @@ enum GE_5X_SCAN_TYPE_ENUM
 enum GE_RELATIVE_STARTS
 {
   GENESIS_SU_HDR_START = 0,
-  GENESIS_EX_HDR_START = GENESIS_SU_HDR_LEN,
-  GENESIS_SE_HDR_START = GENESIS_EX_HDR_START + GENESIS_EX_HDR_LEN,
-  GENESIS_IM_HDR_START = GENESIS_SE_HDR_START + GENESIS_SE_HDR_LEN,
+  GENESIS_EX_HDR_START = static_cast<int>(GENESIS_SU_HDR_LEN),
+  GENESIS_SE_HDR_START = GENESIS_EX_HDR_START + static_cast<int>(GENESIS_EX_HDR_LEN),
+  GENESIS_IM_HDR_START = GENESIS_SE_HDR_START + static_cast<int>(GENESIS_SE_HDR_LEN),
   GENESIS_IMG_HDR_START = 0
 };
 

Modules/IO/NIFTI/src/itkNiftiImageIO.cxx

@@ -1665,7 +1665,7 @@ NiftiImageIO::SetImageIOOrientationFromNIfTI(unsigned short dims, double spacing
     // Commonly the 4x4 double precision dicom information is stored in
     // the 4x4 single precision sform fields, and that original representation
     // is converted (with lossy conversion) into the qform representation.
-    const bool qform_sform_are_similar = [=]() -> bool {
+    const bool qform_sform_are_similar = [this]() -> bool {
       const vnl_matrix_fixed<float, 4, 4> sto_xyz{ &(m_Holder->ptr->sto_xyz.m[0][0]) };
       const vnl_matrix_fixed<float, 4, 4> qto_xyz{ &(m_Holder->ptr->qto_xyz.m[0][0]) };
 

Modules/ThirdParty/GDCM/src/gdcm/Source/DataStructureAndEncodingDefinition/gdcmDataSet.h

@@ -227,6 +227,10 @@ class GDCM_EXPORT DataSet
   /// Returns if the dataset is empty
   bool IsEmpty() const { return DES.empty(); }
 
+  DataSet() = default;
+
+  DataSet(DataSet const &) = default;
+
   DataSet& operator=(DataSet const &)
   = default;
 

Modules/ThirdParty/GDCM/src/gdcm/Source/DataStructureAndEncodingDefinition/gdcmItem.h

@@ -93,6 +93,8 @@ class GDCM_EXPORT Item : public DataElement
     NestedDataSet = val.NestedDataSet;
     }
 
+  Item& operator=(Item const &) = default;
+
   template <typename TDE, typename TSwap>
   std::istream &Read(std::istream &is) {
     // Superclass