Skip to content

Commit 8353852

Browse files
committed
COMP: Address TextureFeatures review concerns
CMakeLists.txt: drop the standalone-build branch (if(NOT ITK_SOURCE_DIR) ... else()); only the ITK-embedded path is load-bearing in-tree. itk-module.cmake: replace the boilerplate-comments block with a DOCUMENTATION variable describing the module's purpose, and pass that variable through to DESCRIPTION. LICENSE: remove the per-module copy; ITK's root LICENSE applies.
1 parent 0078c37 commit 8353852

3 files changed

Lines changed: 8 additions & 242 deletions

File tree

Lines changed: 1 addition & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -1,32 +1,3 @@
11
project(TextureFeatures)
22

3-
if(NOT ITK_SOURCE_DIR)
4-
find_package(ITK 4.10 REQUIRED)
5-
list(APPEND CMAKE_MODULE_PATH ${ITK_CMAKE_DIR})
6-
7-
if(SKBUILD)
8-
set(
9-
PY_SITE_PACKAGES_PATH
10-
${CMAKE_INSTALL_PREFIX}
11-
CACHE PATH
12-
"The install
13-
prefix for python package contents"
14-
)
15-
install(
16-
CODE
17-
"
18-
unset(CMAKE_INSTALL_COMPONENT)
19-
set(COMPONENT \"PythonWheelRuntimeLibraries\")
20-
set(CMAKE_INSTALL_DO_STRIP 1)
21-
include\(\"${PROJECT_BINARY_DIR}/cmake_install.cmake\")
22-
unset(CMAKE_INSTALL_COMPONENT)
23-
return()
24-
"
25-
)
26-
endif()
27-
28-
include(ITKModuleExternal)
29-
include_directories(${ITK_INCLUDE_DIRS})
30-
else()
31-
itk_module_impl()
32-
endif()
3+
itk_module_impl()

Modules/Filtering/TextureFeatures/LICENSE

Lines changed: 0 additions & 202 deletions
This file was deleted.
Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,10 @@
1-
# the top-level README is used for describing this module, just
2-
# re-used it for documentation here
3-
# itk_module() defines the module dependencies in ModuleTemplate
4-
# ModuleTemplate depends on ITKCommon
5-
# The testing module in ModuleTemplate depends on ITKTestKernel
6-
# and ITKMetaIO(besides ModuleTemplate and ITKCore)
7-
# By convention those modules outside of ITK are not prefixed with
8-
# ITK.
1+
set(
2+
DOCUMENTATION
3+
"N-dimensional textural feature image filters: first-order,
4+
run-length, and co-occurrence (GLCM) features computed over a
5+
sliding window for radiomics and computer-vision pipelines."
6+
)
97

10-
# define the dependencies of the include module and the tests
118
itk_module(
129
TextureFeatures
1310
DEPENDS
@@ -21,6 +18,6 @@ itk_module(
2118
ITKImageIntensity
2219
ITKImageNoise
2320
ITKGoogleTest
24-
DESCRIPTION "Module ingested from upstream."
21+
DESCRIPTION "${DOCUMENTATION}"
2522
EXCLUDE_FROM_DEFAULT
2623
)

0 commit comments

Comments
 (0)