Skip to content

Commit 8e144dd

Browse files
seanmhjmjohnson
authored andcommitted
COMP: Add false-positive error exceptions for expected ITK test output
The ARM CI dashboard reports ci_completed_successfully failure even when all tests pass (3171/3171) because CTest/CDash pattern-matches test output from negative test cases as errors. Tests that verify correct exception handling print "--- ERROR ---" banners, itk::ExceptionObject traces, and descriptive error messages that are normal expected output. Add patterns for additional expected exception descriptions: - "Transform has not been set" - "Input parameter list size is not expected size" - "Input InputImage is required but not set"
1 parent b95231b commit 8e144dd

1 file changed

Lines changed: 30 additions & 0 deletions

File tree

CMake/CTestCustom.cmake.in

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,7 @@ set(CTEST_CUSTOM_WARNING_EXCEPTION
7878
"attempted multiple inclusion of file"
7979
"warning LNK4221: This object file does not define any previously undefined public symbols"
8080
".*[/\\\\][Mm]odules[/\\\\][Tt]hird[Pp]arty[/\\\\][Dd][Ii][Cc][Oo][Mm][Pp]arser[/\\\\].*[Ww]arning.*"
81+
".*[/\\\\][Mm]odules[/\\\\][Tt]hird[Pp]arty[/\\\\][Ee]igen3[/\\\\].*[Ww]arning.*"
8182
".*[/\\\\][Mm]odules[/\\\\][Tt]hird[Pp]arty[/\\\\][Ee]xpat[/\\\\].*[Ww]arning.*"
8283
".*[/\\\\][Mm]odules[/\\\\][Tt]hird[Pp]arty[/\\\\][Jj][Pp][Ee][Gg][/\\\\].*[Ww]arning.*"
8384
".*[/\\\\][Mm]odules[/\\\\][Tt]hird[Pp]arty[/\\\\][Kk][Ww][Ss]ys[/\\\\].*[Ww]arning.*"
@@ -126,9 +127,17 @@ set(CTEST_CUSTOM_WARNING_EXCEPTION
126127
# ignore third party GoogleTest warnings
127128
".*Modules/ThirdParty/GoogleTest.*:warning:.*"
128129

130+
129131
# ignore -Wunused-template warnings in third party DoubleConversion.
130132
".*Modules/ThirdParty/DoubleConversion/.*warning:.*Wunused-template"
131133

134+
# ignore some third party warnings
135+
".*Modules/ThirdParty/.*warning:.*Wzero-as-null-pointer-constant.*"
136+
".*Modules/ThirdParty/Eigen3/.*warning:.*Wallocator-wrappers.*"
137+
".*Modules/ThirdParty/Eigen3/.*warning:.*Wmaybe-uninitialized.*"
138+
".*libpng warning: sCAL: invalid unit.*"
139+
".*Expect a warning:.*"
140+
132141
# CircleCI distcc warnings
133142
".*WARNING: REMOTE HOST IDENTIFICATION HAS CHANGED.*"
134143
"Warning: Permanently added.*to the list of known hosts"
@@ -151,4 +160,25 @@ endif()
151160
set(CTEST_CUSTOM_ERROR_EXCEPTION
152161
# Emscripten
153162
".*WARNING root: emcc: cannot find library.*"
163+
164+
# ITK tests: expected exceptions are printed with an "--- ERROR ---" banner
165+
# and itk::ExceptionObject traces. These are normal output from negative
166+
# test cases that verify correct exception handling. CTest/CDash pattern-
167+
# matches these as errors, causing ci_completed_successfully to fail even
168+
# when all 3171/3171 tests pass.
169+
".*Caught expected exception\\.?$"
170+
".*Expected exception:.*"
171+
".*--- ERROR ---.*"
172+
".*itk::ExceptionObject.*"
173+
".*Description: Method not applicable for deformable transform\\..*"
174+
".*Description: Transform has not been set\\..*"
175+
".*Description: Input parameter list size is not expected size\\..*"
176+
".*Description: Input InputImage is required but not set\\..*"
177+
".*Description: Seed1 is not within the input image!.*"
178+
179+
# Test output that CDash pattern-matches as errors but are expected
180+
# diagnostics from passing negative test cases
181+
".*Test FAILED !!.*"
182+
".*ITK ERROR:.*"
183+
".*FAILED: FIXME MetaImage library.*"
154184
)

0 commit comments

Comments
 (0)