Skip to content

Commit a3699e0

Browse files
committed
COMP: Bump itkeigen cmake_minimum to 3.16.3 and clarify dead-block wrap
Two changes in Modules/ThirdParty/Eigen3/src/itkeigen/CMakeLists.txt addressing reviewer feedback: * Bump cmake_minimum_required (line 2) from 3.10.2 to 3.16.3 to match the version ITK proper requires; the previous 3.10.2 was the older Eigen-import default and has no reason to differ from the rest of ITK's tree. * Replace the if(FALSE) ... endif() wrapper used to disable the upstream Eigen CMakeLists with CMake's multiline-comment markers #[[ ... #]] and explicit "ITK - START/STOP DISABLE UPSTREAM EIGEN LOGIC" labels. Functionally identical (both leave the wrapped region inert), but IDEs and code-folding visualizers recognize CMake multiline comments and dim the dead region; if(FALSE) leaves the region looking active in most editors. The line 9 cmake_minimum_required(VERSION 3.10.0) inside the wrapped region becomes a comment after this change, matching its prior dead state. USE_SYSTEM_EIGEN compatibility for Eigen 3.3+ is preserved: this file is only configured under USE_SYSTEM_EIGEN=OFF; consumers using the system Eigen go through find_package(Eigen3 3.3 REQUIRED) and never read this file.
1 parent fb8e6ed commit a3699e0

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

Modules/ThirdParty/Eigen3/src/itkeigen/CMakeLists.txt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
# Same version of ITK cmake_minimum_required
2-
cmake_minimum_required(VERSION 3.10.2)
2+
cmake_minimum_required(VERSION 3.16.3)
33

44
project(Eigen3)
55

66
# ITK doesn't compile anything here, just generates targets for the INTERFACE library.
7-
if(FALSE)
7+
#[[ # ITK - START DISABLE UPSTREAM EIGEN LOGIC
88
99
cmake_minimum_required(VERSION 3.10.0)
1010
@@ -828,7 +828,7 @@ message(STATUS "")
828828
message(STATUS "Configured Eigen ${EIGEN_VERSION_STRING}")
829829
message(STATUS "")
830830
831-
endif() # Regular CMakeLists of Eigen ends here
831+
#]] # ITK -STOP DISABLE UPSTREAM EIGEN LOGIC
832832

833833
###############################################################################
834834
################################ ITK ##########################################

0 commit comments

Comments
 (0)