Merge pull request #5835 from InsightSoftwareConsortium/apply-clang-tidy-int-rules

STYLE: remove redundant control flow

Fixed commit message before merging.

Author: hjmjohnson

Modules/Core/Common/src/itkObject.cxx

@@ -209,8 +209,6 @@ Object::SubjectImplementation::InvokeEventRecursion(const EventObject &
 
     ++i;
   }
-
-  return;
 }
 
 Command *

Modules/Core/Mesh/include/itkMesh.hxx

@@ -173,8 +173,6 @@ Mesh<TPixelType, VDimension, TMeshTraits>::CreateCell(int cellType, CellAutoPoin
     default:
       itkExceptionStringMacro("Unknown mesh cell");
   }
-
-  return;
 }
 
 template <typename TPixelType, unsigned int VDimension, typename TMeshTraits>

Modules/Core/Transform/include/itkMatrixOffsetTransformBase.h

@@ -236,7 +236,6 @@ class ITK_TEMPLATE_EXPORT MatrixOffsetTransformBase
     this->ComputeMatrixParameters();
     m_MatrixMTime.Modified();
     this->Modified();
-    return;
   }
 
   /** Get matrix of an MatrixOffsetTransformBase
@@ -266,7 +265,6 @@ class ITK_TEMPLATE_EXPORT MatrixOffsetTransformBase
     m_Offset = offset;
     this->ComputeTranslation();
     this->Modified();
-    return;
   }
 
   /** Get offset of an MatrixOffsetTransformBase
@@ -308,7 +306,6 @@ class ITK_TEMPLATE_EXPORT MatrixOffsetTransformBase
     m_Center = center;
     this->ComputeOffset();
     this->Modified();
-    return;
   }
 
   /** Get center of rotation of the MatrixOffsetTransformBase
@@ -335,7 +332,6 @@ class ITK_TEMPLATE_EXPORT MatrixOffsetTransformBase
     m_Translation = translation;
     this->ComputeOffset();
     this->Modified();
-    return;
   }
 
   /** Get translation component of the MatrixOffsetTransformBase

Modules/Core/Transform/include/itkRigid3DPerspectiveTransform.h

@@ -148,7 +148,6 @@ class ITK_TEMPLATE_EXPORT Rigid3DPerspectiveTransform : public Transform<TParame
   SetOffset(const OffsetType & offset)
   {
     m_Offset = offset;
-    return;
   }
 
   /** This method sets the rotation of an Rigid3DPerspectiveTransform to a

Modules/Core/Transform/include/itkTranslationTransform.h

@@ -124,7 +124,6 @@ class ITK_TEMPLATE_EXPORT TranslationTransform : public Transform<TParametersVal
   SetOffset(const OutputVectorType & offset)
   {
     m_Offset = offset;
-    return;
   }
 
   /** Compose with another TranslationTransform. */

Modules/Filtering/ImageGrid/include/itkSliceImageFilter.hxx

@@ -211,7 +211,6 @@ SliceImageFilter<TInputImage, TOutputImage>::GenerateInputRequestedRegion()
   }
 
   inputPtr->SetRequestedRegion(inputRequestedRegion);
-  return;
 }
 
 

Modules/IO/Bruker/include/itkBruker2dseqImageIO.h

@@ -117,16 +117,12 @@ class ITKIOBruker_EXPORT Bruker2dseqImageIO : public ImageIOBase
   /** Not implemented. */
   void
   WriteImageInformation() override
-  {
-    return;
-  }
+  {}
 
   /** Not implemented - does nothing */
   void
   Write(const void * itkNotUsed(buffer)) override
-  {
-    return;
-  }
+  {}
 
 protected:
   Bruker2dseqImageIO();

Modules/IO/MeshVTK/include/itkVTKPolyDataMeshIO.h

@@ -190,7 +190,6 @@ class ITKIOMeshVTK_EXPORT VTKPolyDataMeshIO : public MeshIOBase
     EncapsulateMetaData<unsigned int>(metaDic, "numberOfLineIndices", numberOfLineIndices);
     EncapsulateMetaData<unsigned int>(metaDic, "numberOfPolygons", numberOfPolygons);
     EncapsulateMetaData<unsigned int>(metaDic, "numberOfPolygonIndices", numberOfPolygonIndices);
-    return;
   }
 
   template <typename T>
@@ -441,8 +440,6 @@ class ITKIOMeshVTK_EXPORT VTKPolyDataMeshIO : public MeshIOBase
 
       outputFile << ConvertNumberToString(buffer[ii * this->m_PointDimension + this->m_PointDimension - 1]) << '\n';
     }
-
-    return;
   }
 
   template <typename T>
@@ -454,8 +451,6 @@ class ITKIOMeshVTK_EXPORT VTKPolyDataMeshIO : public MeshIOBase
     itk::ByteSwapper<T>::SwapWriteRangeFromSystemToBigEndian(
       buffer, this->m_NumberOfPoints * this->m_PointDimension, &outputFile);
     outputFile << '\n';
-
-    return;
   }
 
   template <typename T>
@@ -800,8 +795,6 @@ class ITKIOMeshVTK_EXPORT VTKPolyDataMeshIO : public MeshIOBase
         outputFile << ConvertNumberToString(buffer[ii * this->m_NumberOfPointPixelComponents + jj]) << '\n';
       }
     }
-
-    return;
   }
 
   template <typename T>
@@ -864,7 +857,6 @@ class ITKIOMeshVTK_EXPORT VTKPolyDataMeshIO : public MeshIOBase
     itk::ByteSwapper<T>::SwapWriteRangeFromSystemToBigEndian(
       buffer, this->m_NumberOfPointPixels * this->m_NumberOfPointPixelComponents, &outputFile);
     outputFile << '\n';
-    return;
   }
 
   template <typename T>
@@ -990,8 +982,6 @@ class ITKIOMeshVTK_EXPORT VTKPolyDataMeshIO : public MeshIOBase
         outputFile << buffer[ii * this->m_NumberOfCellPixelComponents + jj] << '\n';
       }
     }
-
-    return;
   }
 
   template <typename T>
@@ -1054,7 +1044,6 @@ class ITKIOMeshVTK_EXPORT VTKPolyDataMeshIO : public MeshIOBase
     itk::ByteSwapper<T>::SwapWriteRangeFromSystemToBigEndian(
       buffer, this->m_NumberOfCells * this->m_NumberOfCellPixelComponents, &outputFile);
     outputFile << '\n';
-    return;
   }
 
   template <typename T>
@@ -1075,8 +1064,6 @@ class ITKIOMeshVTK_EXPORT VTKPolyDataMeshIO : public MeshIOBase
 
       outputFile << '\n';
     }
-
-    return;
   }
 
   template <typename T>
@@ -1096,7 +1083,6 @@ class ITKIOMeshVTK_EXPORT VTKPolyDataMeshIO : public MeshIOBase
 
     outputFile.write(reinterpret_cast<char *>(data.get()), numberOfElements);
     outputFile << '\n';
-    return;
   }
 
   /** Convert cells buffer for output cells buffer, it's user's responsibility to make sure

Modules/IO/RAW/include/itkRawImageIO.h

@@ -116,9 +116,7 @@ class ITK_TEMPLATE_EXPORT RawImageIO : public ImageIOBase
    * user of the class. */
   void
   ReadImageInformation() override
-  {
-    return;
-  }
+  {}
 
   /** Reads the data from disk into the memory buffer provided. */
   void
@@ -154,9 +152,7 @@ class ITK_TEMPLATE_EXPORT RawImageIO : public ImageIOBase
   /** Binary files have no image information to read.  */
   void
   WriteImageInformation() override
-  {
-    return;
-  }
+  {}
 
   /** Writes the data to disk from the memory buffer provided. */
   void

Modules/Registration/Common/include/itkLandmarkBasedTransformInitializer.hxx

@@ -804,8 +804,6 @@ LandmarkBasedTransformInitializer<TTransform, TFixedImage, TMovingImage>::Create
   N[1][2] = N[2][1] = M[0][1] + M[1][0];
   N[1][3] = N[3][1] = M[2][0] + M[0][2];
   N[2][3] = N[3][2] = M[1][2] + M[2][1];
-
-  return;
 }
 
 template <typename TTransform, typename TFixedImage, typename TMovingImage>