Skip to content

Commit ff64672

Browse files
committed
STYLE: Address Greptile review on HigherOrderAccurateGradient
- Drop `== true` boolean comparisons (itkHigherOrderAccurateDerivativeImageFilter.hxx, itkHigherOrderAccurateGradientImageFilter.hxx). - Collapse stray blank line between `Ctor()` signature and `= default;` in Derivative filter, GradientImageFilter ctor, and DerivativeOperator ctor. - Document SetOrder() limitation: only `order == 1` is implemented; GenerateCoefficients() throws on any other value. - Rename misnamed wrap file itkHigherOrderAccurateGradientmageFilter.wrap -> itkHigherOrderAccurateGradientImageFilter.wrap.
1 parent 8055fc7 commit ff64672

5 files changed

Lines changed: 8 additions & 12 deletions

Modules/Filtering/HigherOrderAccurateGradient/include/itkHigherOrderAccurateDerivativeImageFilter.h

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -115,9 +115,7 @@ class HigherOrderAccurateDerivativeImageFilter : public ImageToImageFilter<TInpu
115115
itkGetConstMacro(UseImageSpacing, bool);
116116

117117
protected:
118-
HigherOrderAccurateDerivativeImageFilter()
119-
120-
= default;
118+
HigherOrderAccurateDerivativeImageFilter() = default;
121119

122120
~HigherOrderAccurateDerivativeImageFilter() override = default;
123121
void

Modules/Filtering/HigherOrderAccurateGradient/include/itkHigherOrderAccurateDerivativeImageFilter.hxx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ HigherOrderAccurateDerivativeImageFilter<TInputImage, TOutputImage>::GenerateDat
9999
oper.CreateDirectional();
100100
oper.FlipAxes();
101101

102-
if (m_UseImageSpacing == true)
102+
if (m_UseImageSpacing)
103103
{
104104
if (this->GetInput()->GetSpacing()[m_Direction] == 0.0)
105105
{

Modules/Filtering/HigherOrderAccurateGradient/include/itkHigherOrderAccurateDerivativeOperator.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -72,9 +72,7 @@ class HigherOrderAccurateDerivativeOperator : public NeighborhoodOperator<TPixel
7272
itkTypeMacro(HigherOrderAccurateDerivativeOperator, NeighborhoodOperator);
7373

7474
/** Constructor. */
75-
HigherOrderAccurateDerivativeOperator()
76-
77-
= default;
75+
HigherOrderAccurateDerivativeOperator() = default;
7876

7977
/** Copy constructor. */
8078
HigherOrderAccurateDerivativeOperator(const Self & other)
@@ -92,7 +90,9 @@ class HigherOrderAccurateDerivativeOperator : public NeighborhoodOperator<TPixel
9290
return *this;
9391
}
9492

95-
/** Sets the order of the derivative. */
93+
/** Sets the order of the derivative. Only `order == 1` is currently
94+
* implemented; any other value triggers a runtime exception in
95+
* GenerateCoefficients(). */
9696
void
9797
SetOrder(const unsigned int & order)
9898
{

Modules/Filtering/HigherOrderAccurateGradient/include/itkHigherOrderAccurateGradientImageFilter.hxx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,7 @@ namespace itk
3030

3131
template <typename TInputImage, typename TOperatorValueType, typename TOutputValueType>
3232
HigherOrderAccurateGradientImageFilter<TInputImage, TOperatorValueType, TOutputValueType>::
33-
HigherOrderAccurateGradientImageFilter()
34-
35-
= default;
33+
HigherOrderAccurateGradientImageFilter() = default;
3634

3735

3836
template <typename TInputImage, typename TOperatorValueType, typename TOutputValueType>
@@ -126,7 +124,7 @@ HigherOrderAccurateGradientImageFilter<TInputImage, TOperatorValueType, TOutputV
126124
op[i].FlipAxes();
127125

128126
// Take into account the pixel spacing if necessary
129-
if (m_UseImageSpacing == true)
127+
if (m_UseImageSpacing)
130128
{
131129
if (this->GetInput()->GetSpacing()[i] == 0.0)
132130
{

Modules/Filtering/HigherOrderAccurateGradient/wrapping/itkHigherOrderAccurateGradientmageFilter.wrap renamed to Modules/Filtering/HigherOrderAccurateGradient/wrapping/itkHigherOrderAccurateGradientImageFilter.wrap

File renamed without changes.

0 commit comments

Comments
 (0)