Skip to content

BUG: Use check_symbol_exists for TIFFFieldReadCount detection #6150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blowekamp merged 1 commit into from
Apr 27, 2026
Merged

BUG: Use check_symbol_exists for TIFFFieldReadCount detection #6150

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Modules/ThirdParty/TIFF/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,14 @@ if(ITK_USE_SYSTEM_TIFF)
# Check availability of different methods to access TIFF's field
# data structure.
include(CheckTypeSize)
include(CheckSymbolExists)
set(CMAKE_REQUIRED_LIBRARIES TIFF::TIFF)
set(CMAKE_EXTRA_INCLUDE_FILES "tiffio.h")
check_type_size(TIFFFieldReadCount ITK_TIFF_HAS_TIFFFieldReadCount)
# TIFFFieldReadCount is a function, not a type. Using
# check_type_size (sizeof) on a function is non-standard and fails
# on MSVC, causing the wrong code path and crashes. Use
# check_symbol_exists instead.
check_symbol_exists(TIFFFieldReadCount "tiffio.h" ITK_TIFF_HAS_TIFFFieldReadCount)
check_type_size(TIFFField* ITK_TIFF_HAS_TIFFField)
else()
set(ITKTIFF_INCLUDE_DIRS
Expand Down
Loading