Skip to content

ENH: Decouple itk::Math from vnl_math (constants and functions) #6427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hjmjohnson merged 14 commits into from
Jun 11, 2026
Merged

ENH: Decouple itk::Math from vnl_math (constants and functions) #6427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
62ba138
ENH: Define itk::Math constants from correctly-rounded literals
hjmjohnson Jun 9, 2026
10ece1c
STYLE: Remove unused <vxl_version.h> include from itkMath.h
hjmjohnson Jun 9, 2026
a917b18
BUG: Define itk::Math::sqrteps as exactly-representable 0x1p-26
hjmjohnson Jun 10, 2026
589d680
DOC: Document itk::Math::sqrteps 1 ULP change in ITKv6 migration guide
hjmjohnson Jun 10, 2026
c76d499
ENH: Replace vnl_math function aliases with native itk::Math implemen…
hjmjohnson Jun 10, 2026
f454aa0
ENH: Replace vnl_huge_val with NumericTraits max in FEMRegistrationFi…
hjmjohnson Jun 10, 2026
da11d87
STYLE: Remove unused vnl_math.h include from TriangleMeshCurvatureCal…
hjmjohnson Jun 10, 2026
3d4fc5f
STYLE: Prefer itk::Math::Absolute over legacy itk::Math::abs alias
hjmjohnson Jun 10, 2026
05188f9
ENH: Gate vnl_math.h include in itkMath.h behind ITK_FUTURE_LEGACY_RE…
hjmjohnson Jun 10, 2026
ea24f1d
ENH: Cover all deprecated vnl_math spellings in VNL_ModernizeNaming.py
hjmjohnson Jun 10, 2026
fcc80ce
ENH: Harden itk::Math natives beyond vnl_math parity
hjmjohnson Jun 10, 2026
faea421
ENH: Add GTest verifying itk::Math natives match vnl_math bit-for-bit
hjmjohnson Jun 10, 2026
412fe46
COMP: Opt the vnl_math parity test out of vnl_math deprecation warnings
hjmjohnson Jun 11, 2026
9e5d3e1
COMP: Accept both vnl_math::sqrteps values in the parity test
hjmjohnson Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Documentation/docs/migration_guides/itk_6_migration_guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,12 @@ ITKVNL module. The ITKVNLInstantiation library was an empty library used for
compatibility and provided transitive linking to ITKVNL.


`itk::Math::sqrteps` changed by 1 ULP for accuracy
--------------------------------------------------

`itk::Math::sqrteps` is now `0x1p-26`, the exact `sqrt(eps)`;
`vnl_math::sqrteps` (`1.490116119384766e-08`) was 1 ULP higher.

Prefer itk::AnatomicalOrientation over itk::SpatialOrientation
------------------------------------------------

Expand Down
Loading
Loading