-
-
Notifications
You must be signed in to change notification settings - Fork 737
ENH: YYYYMMDD tweak version for between-tag gating (supersedes #6665) #6667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hjmjohnson
wants to merge
2
commits into
InsightSoftwareConsortium:main
Choose a base branch
from
hjmjohnson:enh-tweak-version-migration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,14 @@ | ||
| set(PACKAGE_VERSION "@ITK_VERSION_MAJOR@.@ITK_VERSION_MINOR@.@ITK_VERSION_PATCH@") | ||
| set( | ||
| PACKAGE_VERSION | ||
| "@ITK_VERSION_MAJOR@.@ITK_VERSION_MINOR@.@ITK_VERSION_PATCH@.@ITK_VERSION_TWEAK@" | ||
| ) | ||
| if(NOT "${PACKAGE_FIND_VERSION}" VERSION_GREATER "${PACKAGE_VERSION}") | ||
| set(PACKAGE_VERSION_COMPATIBLE 1) # compatible with older | ||
| if("${PACKAGE_FIND_VERSION}" VERSION_EQUAL "${PACKAGE_VERSION}") | ||
| if( | ||
| "${PACKAGE_FIND_VERSION}" VERSION_EQUAL "${PACKAGE_VERSION}" | ||
| OR "${PACKAGE_FIND_VERSION}" VERSION_EQUAL | ||
| "@ITK_VERSION_MAJOR@.@ITK_VERSION_MINOR@.@ITK_VERSION_PATCH@" | ||
| ) | ||
| set(PACKAGE_VERSION_EXACT 1) # exact match for this version | ||
| endif() | ||
| endif() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| #!/usr/bin/env python3 | ||
| """Set ITK_VERSION_TWEAK in CMake/itkVersion.cmake to a YYYYMMDD date. | ||
| Usage: | ||
| BumpVersionTweak.py # bump to today's UTC date | ||
| BumpVersionTweak.py 20260801 # bump to an explicit date | ||
| """ | ||
|
|
||
| import argparse | ||
| import datetime | ||
| import re | ||
| import sys | ||
| from pathlib import Path | ||
|
|
||
| VERSION_FILE = Path(__file__).resolve().parents[2] / "CMake" / "itkVersion.cmake" | ||
| PATTERN = re.compile(r'(set\(ITK_VERSION_TWEAK ")(\d{8})("\))') | ||
|
|
||
|
|
||
| def main() -> int: | ||
| parser = argparse.ArgumentParser(description=__doc__) | ||
| parser.add_argument( | ||
| "date", | ||
| nargs="?", | ||
| default=datetime.datetime.now(datetime.UTC).strftime("%Y%m%d"), | ||
| help="YYYYMMDD value (default: today, UTC)", | ||
| ) | ||
| args = parser.parse_args() | ||
|
|
||
| try: | ||
| datetime.datetime.strptime(args.date, "%Y%m%d") | ||
| except ValueError: | ||
| parser.error(f"'{args.date}' is not a valid YYYYMMDD date") | ||
|
|
||
| content = VERSION_FILE.read_text() | ||
| match = PATTERN.search(content) | ||
| if match is None: | ||
| print(f"ERROR: ITK_VERSION_TWEAK not found in {VERSION_FILE}", file=sys.stderr) | ||
| return 1 | ||
| if args.date < match.group(2): | ||
| print( | ||
| f"ERROR: {args.date} is older than current tweak {match.group(2)}", | ||
| file=sys.stderr, | ||
| ) | ||
| return 1 | ||
| if args.date == match.group(2): | ||
| print(f"ITK_VERSION_TWEAK already {args.date}") | ||
| return 0 | ||
|
|
||
| VERSION_FILE.write_text(PATTERN.sub(rf"\g<1>{args.date}\g<3>", content)) | ||
| print(f"ITK_VERSION_TWEAK: {match.group(2)} -> {args.date}") | ||
| return 0 | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| sys.exit(main()) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.