COMP: Update CI best practices and Python 3.10+#17
Merged
hjmjohnson merged 4 commits intomainfrom Apr 23, 2026
Merged
Conversation
Fix macos-13 runner deprecation - v5.4.0 through v5.4.4 reference macos-13 which has been removed from GitHub Actions. v5.4.6 uses macos-15-intel and includes GHCR-mirrored dockcross image pre-pull.
dzenanz
approved these changes
Apr 3, 2026
Member
|
Error: |
The v5.4.6 action's default ITK commit (c6e1c1be, March 2026 main) has a DCMTK ExternalProject include path issue where ijg12/include is exported in ITK targets but does not exist in the build tree, causing CMake configure failure for remote modules. Pin to v5.4.5 release where DCMTK builds correctly.
Member
|
D:\a\ITKIOTransformDCMTK\ITK-build\Modules\ThirdParty\DCMTK\ITKDCMTK_ExtProject-build\config\include\dcmtk/config/osconfig.h(938): fatal error C1189: #error: DCMTK was configured to use C++11 features, but your compiler does not or was not configured to provide them. |
Member
Author
|
Upstream fixes for both DCMTK blockers submitted: InsightSoftwareConsortium/ITK#6072 (targeting release-5.4 for v5.4.6). Once merged, this PR can drop the |
Point itk-git-tag at hjmjohnson:fix-dcmtk-external-module-compat-main which includes both DCMTK fixes: - BUG: Exclude ijg* libs from INTERFACE_INCLUDE_DIRECTORIES - COMP: Add /Zc:__cplusplus for MSVC This is a temporary test commit to validate the upstream fixes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update CI infrastructure and Python version requirement.
Changes
requires-pythonfrom>=3.9to>=3.10(Python 3.9 EOL was Oct 2025)ITKRemoteModuleBuildTestPackageActionfromv5.4.2tov5.4.6for latest runner support (macOS 15, Apple Silicon)ijg12/includeexported but missing); pin to v5.4.5 release where DCMTK builds correctly