STYLE: Remove Initialize() calls on new point sets RegisterTwoPointSets#450
Merged
N-Dekker merged 1 commit intoJun 12, 2026
Merged
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
github-actions
Bot
added
area:Registration
When a point set is just created by `New()`, it is already properly initialized. - Follow-up to pull request InsightSoftwareConsortium/ITK#4976 commit InsightSoftwareConsortium/ITK@bc044c1 "STYLE: Remove p->Initialize() call after p = T::New() in example"
hjmjohnson
force-pushed
the
rebase/remove-initialize-calls-register-two-point-sets
branch
from
557ffa6 to
34c1710
Compare
dzenanz
approved these changes
Jun 12, 2026
|
🎉 Published on https://examples.itk.org as production |
Collaborator
|
Thanks, but I would have been willing to do the rebase myself 🤷 Why was it originally put on hold? |
Member
|
Maybe the CI was broken? |
N-Dekker
approved these changes
Jun 12, 2026
N-Dekker
left a comment
N-Dekker
left a comment
Collaborator
There was a problem hiding this comment.
Thanks Hans, but the next time, can you possibly first just ask me to rebase my pull request myself?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebase of @N-Dekker's PR #434 onto current
main.When a point set is just created by
New(), it is already properly initialized. Removes redundantInitialize()calls fromRegisterTwoPointSets— follow-up to ITK#4976 commit bc044c1d.