test(deploy): fix remaining mig-068 mock sites — full-row helper + MarkBuilding SQL

Two more mock sites still on the pre-068 shape, surfaced by the model/handler
*_Branches + redeploy-CASMiss tests:

- coverage_provision_gate_test.go: deploymentMockCols() + deploymentMockRow()
  (the shared full-deployment mock used by every models *_Branches test) now
  include last_activity_at / scaled_to_zero / always_on (33 cols, matching
  scanDeployment) — fixes the "expected 30 destination arguments, not 33" Scan
  errors in TestGetDeploymentByAppID/ByID/ByTeam/...Branches.
- MarkDeploymentBuilding's SQL now also sets scaled_to_zero=false +
  last_activity_at=now() on redeploy (a redeploy is activity + brings replicas
  back to 1). Update the ExpectExec regexes that pinned the old SQL: 2 in
  coverage_deployment_test.go, 5 in deploy_redeploy_inplace_mock_test.go.

Completes the rule-16 enumeration of every deployments-row mock site rippled by
migration 068. Test-only.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: mastermanas805

internal/handlers/deploy_redeploy_inplace_mock_test.go

@@ -338,7 +338,7 @@ func TestDeployNew_Redeploy_UpdateStatusError_StillAccepts(t *testing.T) {
 	// non-determinate (we can't tell whether the flip landed), and
 	// runRedeployAsync will reconcile the row later. Only an explicit 0-row
 	// CAS miss means "reaped concurrently, return 409".
-	mock.ExpectExec(`UPDATE deployments\s+SET status = 'building', error_message = NULL, updated_at = now\(\)\s+WHERE id = \$1 AND status IN`).
+	mock.ExpectExec(`UPDATE deployments\s+SET status = 'building', error_message = NULL,\s+scaled_to_zero = false, last_activity_at = now\(\),\s+updated_at = now\(\)\s+WHERE id = \$1 AND status IN`).
 		WithArgs(rowID).
 		WillReturnError(errMockRedeployDriver)
 
@@ -494,7 +494,7 @@ func TestDeployNew_Redeploy_CASMiss_Returns409(t *testing.T) {
 		))
 
 	// Guarded CAS matches 0 rows — the reaper won the race. Handler 409s.
-	mock.ExpectExec(`UPDATE deployments\s+SET status = 'building', error_message = NULL, updated_at = now\(\)\s+WHERE id = \$1 AND status IN`).
+	mock.ExpectExec(`UPDATE deployments\s+SET status = 'building', error_message = NULL,\s+scaled_to_zero = false, last_activity_at = now\(\),\s+updated_at = now\(\)\s+WHERE id = \$1 AND status IN`).
 		WithArgs(rowID).
 		WillReturnResult(sqlmock.NewResult(0, 0))
 
@@ -606,7 +606,7 @@ func TestDeployRedeploy_ByID_CASMiss_Returns409(t *testing.T) {
 		))
 
 	// Guarded CAS matches 0 rows — the reaper won the race after the read.
-	mock.ExpectExec(`UPDATE deployments\s+SET status = 'building', error_message = NULL, updated_at = now\(\)\s+WHERE id = \$1 AND status IN`).
+	mock.ExpectExec(`UPDATE deployments\s+SET status = 'building', error_message = NULL,\s+scaled_to_zero = false, last_activity_at = now\(\),\s+updated_at = now\(\)\s+WHERE id = \$1 AND status IN`).
 		WithArgs(rowID).
 		WillReturnResult(sqlmock.NewResult(0, 0))
 
@@ -661,7 +661,7 @@ func TestDeployRedeploy_ByID_CASSuccess_Returns202(t *testing.T) {
 			sql.NullTime{}, false, false,
 		))
 
-	mock.ExpectExec(`UPDATE deployments\s+SET status = 'building', error_message = NULL, updated_at = now\(\)\s+WHERE id = \$1 AND status IN`).
+	mock.ExpectExec(`UPDATE deployments\s+SET status = 'building', error_message = NULL,\s+scaled_to_zero = false, last_activity_at = now\(\),\s+updated_at = now\(\)\s+WHERE id = \$1 AND status IN`).
 		WithArgs(rowID).
 		WillReturnResult(sqlmock.NewResult(0, 1))
 
@@ -713,7 +713,7 @@ func TestDeployRedeploy_ByID_CASDriverError_StillAccepts(t *testing.T) {
 		))
 
 	// Guarded CAS → driver error (non-determinate). Handler logs + continues.
-	mock.ExpectExec(`UPDATE deployments\s+SET status = 'building', error_message = NULL, updated_at = now\(\)\s+WHERE id = \$1 AND status IN`).
+	mock.ExpectExec(`UPDATE deployments\s+SET status = 'building', error_message = NULL,\s+scaled_to_zero = false, last_activity_at = now\(\),\s+updated_at = now\(\)\s+WHERE id = \$1 AND status IN`).
 		WithArgs(rowID).
 		WillReturnError(errMockRedeployDriver)
 

internal/models/coverage_deployment_test.go

@@ -351,15 +351,15 @@ func TestMarkDeploymentBuilding_Branches(t *testing.T) {
 
 	// 1 row matched — redeployable status flipped to building.
 	db, mock := newMock(t)
-	mock.ExpectExec(`UPDATE deployments\s+SET status = 'building', error_message = NULL, updated_at = now\(\)\s+WHERE id = \$1 AND status IN`).
+	mock.ExpectExec(`UPDATE deployments\s+SET status = 'building', error_message = NULL,\s+scaled_to_zero = false, last_activity_at = now\(\),\s+updated_at = now\(\)\s+WHERE id = \$1 AND status IN`).
 		WillReturnResult(sqlmock.NewResult(0, 1))
 	n, err := MarkDeploymentBuilding(ctx, db, uuid.New())
 	require.NoError(t, err)
 	require.Equal(t, int64(1), n)
 
 	// 0 rows matched — the row was reaped to a terminal status; CAS no-op.
 	db2, mock2 := newMock(t)
-	mock2.ExpectExec(`UPDATE deployments\s+SET status = 'building', error_message = NULL, updated_at = now\(\)\s+WHERE id = \$1 AND status IN`).
+	mock2.ExpectExec(`UPDATE deployments\s+SET status = 'building', error_message = NULL,\s+scaled_to_zero = false, last_activity_at = now\(\),\s+updated_at = now\(\)\s+WHERE id = \$1 AND status IN`).
 		WillReturnResult(sqlmock.NewResult(0, 0))
 	n, err = MarkDeploymentBuilding(ctx, db2, uuid.New())
 	require.NoError(t, err)

internal/models/coverage_provision_gate_test.go

@@ -19,6 +19,7 @@ func deploymentMockCols() []string {
 		"expires_at", "ttl_policy", "reminders_sent", "last_reminder_at",
 		"source", "image_ref", "registry_creds_enc",
 		"git_url", "git_ref", "git_token_enc",
+		"last_activity_at", "scaled_to_zero", "always_on",
 	}
 }
 
@@ -30,6 +31,7 @@ func deploymentMockRow() *sqlmock.Rows {
 		nil, "auto_24h", 0, nil,
 		"tarball", "", "", // source, image_ref, registry_creds_enc (mig 064)
 		"", "", "", // git_url, git_ref, git_token_enc (mig 065)
+		nil, false, false, // last_activity_at, scaled_to_zero, always_on (mig 068)
 	)
 }