test(handlers): expand deploy + stack handler coverage (#153)

* test(handlers): expand deploy + stack handler coverage

Add ~70 targeted tests for the deploy.go and stack.go handlers covering
multipart tarball parsing, tier-cap 402 walls, env-vars merge/key-validation,
vault-ref resolution, needs:-resource resolution, promote approval flow
(consumeApprovedPromote), dev-env promote execution, two-step deletion
(confirm/cancel), and the async runDeploy/runStackDeploy/runStackRedeploy
goroutine success+failure branches via injected compute/stack-provider doubles
and DB-fault paths.

Adds a test-only SetStackProvider setter (mirrors SetComputeProvider) and
export_test.go wrappers so external tests can exercise unexported helpers
(truncateForAudit, resourceEnvKey, parseResourceToken, rewriteToInternalURL,
runDeploy, captureAutopsy) without an import cycle through testhelpers.

deploy.go ~71% -> ~86%, stack.go ~62% -> ~77%. Remaining uncovered paths are
k8s-constructor init and deep defensive error tails not reachable without a
live cluster.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* test(handlers): expand deploy + stack handler coverage (batch 2)

Add gap-filling tests for deploy.go and stack.go error and edge branches:
manifest/tarball/token/env validation on /stacks/new, promote
invalid-body/env-mismatch/no-services/missing-image-ref/create-target paths,
copyVaultRefsForPromote no-op + skip-existing + per-key copy, stack
Redeploy/UpdateEnv merge+delete+cross-team, and closed-DB 503 arms for
stack UpdateEnv/Promote/Family. Lifts deploy.go ~82->83% and stack.go
~72->80%.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* test(handlers): cover stack promote in-place update branch

Add a real-DB test that pre-seeds a target stack in the same family so
Promote takes the updated_existing path — covering both the existing-service
image_ref update and the missing-service create branches.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: mastermanas805

internal/handlers/deploy_stack_branches_coverage_test.go

@@ -0,0 +1,186 @@
+package handlers_test
+
+// deploy_stack_dbfault_coverage_test.go — drives the 503 "fetch_failed" /
+// "list_failed" / "team_lookup_failed" error branches in deploy.go + stack.go
+// by handing the handler a *closed* DB handle. Every query then returns
+// "sql: database is closed", which is the non-ErrNotFound error arm.
+//
+// Scope: deploy.go + stack.go ONLY. Skips cleanly when TEST_DATABASE_URL unset.
+
+import (
+	"database/sql"
+	"errors"
+	"net/http"
+	"net/http/httptest"
+	"os"
+	"strings"
+	"testing"
+
+	"github.com/gofiber/fiber/v2"
+	"github.com/google/uuid"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+
+	"instant.dev/internal/config"
+	"instant.dev/internal/handlers"
+	"instant.dev/internal/middleware"
+	"instant.dev/internal/plans"
+	"instant.dev/internal/testhelpers"
+)
+
+// closedDBApp builds a fiber app whose deploy + stack handlers run against a
+// CLOSED *sql.DB so every model query errors. A valid JWT still passes the
+// auth middleware (it doesn't touch the DB), so the request reaches the
+// handler and exercises the non-ErrNotFound error arm.
+func closedDBApp(t *testing.T) (*fiber.App, *config.Config) {
+	t.Helper()
+	dsn := os.Getenv("TEST_DATABASE_URL")
+	if dsn == "" {
+		dsn = "postgres://postgres:postgres@localhost:5432/instant_dev_test?sslmode=disable"
+	}
+	db, err := sql.Open("postgres", dsn)
+	require.NoError(t, err)
+	require.NoError(t, db.Close()) // closed on purpose
+
+	cfg := &config.Config{
+		JWTSecret:       testhelpers.TestJWTSecret,
+		AESKey:          testhelpers.TestAESKeyHex,
+		ComputeProvider: "noop",
+	}
+	app := fiber.New(fiber.Config{
+		ErrorHandler: func(c *fiber.Ctx, e error) error {
+			if errors.Is(e, handlers.ErrResponseWritten) {
+				return nil
+			}
+			code := fiber.StatusInternalServerError
+			if fe, ok := e.(*fiber.Error); ok {
+				code = fe.Code
+			}
+			return c.Status(code).JSON(fiber.Map{"ok": false, "error": "internal_error", "message": e.Error()})
+		},
+	})
+	dh := handlers.NewDeployHandler(db, nil, cfg, plans.Default())
+	sh := handlers.NewStackHandler(db, nil, cfg, plans.Default())
+
+	app.Get("/deploy/:id", middleware.RequireAuth(cfg), dh.Get)
+	app.Get("/api/v1/deployments", middleware.RequireAuth(cfg), dh.List)
+	app.Patch("/deploy/:id/env", middleware.RequireAuth(cfg), dh.UpdateEnv)
+	app.Get("/api/v1/stacks", middleware.RequireAuth(cfg), sh.List)
+	app.Get("/stacks/:slug", middleware.OptionalAuth(cfg), sh.Get)
+	app.Patch("/stacks/:slug/env", middleware.RequireAuth(cfg), sh.UpdateEnv)
+	app.Post("/api/v1/stacks/:slug/promote", middleware.RequireAuth(cfg), sh.Promote)
+	app.Get("/stacks/:slug/family", middleware.RequireAuth(cfg), sh.Family)
+	return app, cfg
+}
+
+func dbFaultJWT(t *testing.T) string {
+	t.Helper()
+	return testhelpers.MustSignSessionJWT(t, uuid.NewString(), uuid.NewString(), "dbfault@example.com")
+}
+
+func dbFaultNeedsDB(t *testing.T) {
+	t.Helper()
+	if os.Getenv("TEST_DATABASE_URL") == "" {
+		t.Skip("TEST_DATABASE_URL not set — skipping db-fault coverage test")
+	}
+}
+
+func TestDeployGet_DBClosed_Returns503(t *testing.T) {
+	dbFaultNeedsDB(t)
+	app, _ := closedDBApp(t)
+	req := httptest.NewRequest(http.MethodGet, "/deploy/some-app", nil)
+	req.Header.Set("Authorization", "Bearer "+dbFaultJWT(t))
+	resp, err := app.Test(req, 5000)
+	require.NoError(t, err)
+	defer resp.Body.Close()
+	assert.Equal(t, http.StatusServiceUnavailable, resp.StatusCode)
+}
+
+func TestDeployList_DBClosed_Returns503(t *testing.T) {
+	dbFaultNeedsDB(t)
+	app, _ := closedDBApp(t)
+	req := httptest.NewRequest(http.MethodGet, "/api/v1/deployments", nil)
+	req.Header.Set("Authorization", "Bearer "+dbFaultJWT(t))
+	resp, err := app.Test(req, 5000)
+	require.NoError(t, err)
+	defer resp.Body.Close()
+	assert.Equal(t, http.StatusServiceUnavailable, resp.StatusCode)
+}
+
+func TestDeployUpdateEnv_DBClosed_Returns503(t *testing.T) {
+	dbFaultNeedsDB(t)
+	app, _ := closedDBApp(t)
+	req := httptest.NewRequest(http.MethodPatch, "/deploy/some-app/env",
+		strings.NewReader(`{"env":{"FOO":"bar"}}`))
+	req.Header.Set("Content-Type", "application/json")
+	req.Header.Set("Authorization", "Bearer "+dbFaultJWT(t))
+	resp, err := app.Test(req, 5000)
+	require.NoError(t, err)
+	defer resp.Body.Close()
+	assert.Equal(t, http.StatusServiceUnavailable, resp.StatusCode)
+}
+
+func TestStackList_DBClosed_Returns503(t *testing.T) {
+	dbFaultNeedsDB(t)
+	app, _ := closedDBApp(t)
+	req := httptest.NewRequest(http.MethodGet, "/api/v1/stacks", nil)
+	req.Header.Set("Authorization", "Bearer "+dbFaultJWT(t))
+	resp, err := app.Test(req, 5000)
+	require.NoError(t, err)
+	defer resp.Body.Close()
+	assert.Equal(t, http.StatusServiceUnavailable, resp.StatusCode)
+}
+
+func TestStackGet_DBClosed_Returns503(t *testing.T) {
+	dbFaultNeedsDB(t)
+	app, _ := closedDBApp(t)
+	req := httptest.NewRequest(http.MethodGet, "/stacks/some-slug", nil)
+	req.Header.Set("Authorization", "Bearer "+dbFaultJWT(t))
+	resp, err := app.Test(req, 5000)
+	require.NoError(t, err)
+	defer resp.Body.Close()
+	assert.Equal(t, http.StatusServiceUnavailable, resp.StatusCode)
+}
+
+// TestStackUpdateEnv_DBClosed_Returns503 — GetStackBySlug fails on the closed
+// DB so UpdateEnv returns 503 fetch_failed (line 1141).
+func TestStackUpdateEnv_DBClosed_Returns503(t *testing.T) {
+	dbFaultNeedsDB(t)
+	app, _ := closedDBApp(t)
+	req := httptest.NewRequest(http.MethodPatch, "/stacks/some-slug/env",
+		strings.NewReader(`{"env":{"FOO":"bar"}}`))
+	req.Header.Set("Content-Type", "application/json")
+	req.Header.Set("Authorization", "Bearer "+dbFaultJWT(t))
+	resp, err := app.Test(req, 5000)
+	require.NoError(t, err)
+	defer resp.Body.Close()
+	assert.Equal(t, http.StatusServiceUnavailable, resp.StatusCode)
+}
+
+// TestStackPromote_DBClosed_Returns503 — requireStackTeam's GetTeamByID fails
+// on the closed DB, exercising Promote's requireStackTeam error arm (503).
+func TestStackPromote_DBClosed_Returns503(t *testing.T) {
+	dbFaultNeedsDB(t)
+	app, _ := closedDBApp(t)
+	jwt := dbFaultJWT(t)
+	req := httptest.NewRequest(http.MethodPost, "/api/v1/stacks/some-slug/promote",
+		strings.NewReader(`{"from":"staging","to":"production"}`))
+	req.Header.Set("Content-Type", "application/json")
+	req.Header.Set("Authorization", "Bearer "+jwt)
+	resp, err := app.Test(req, 5000)
+	require.NoError(t, err)
+	defer resp.Body.Close()
+	assert.Equal(t, http.StatusServiceUnavailable, resp.StatusCode)
+}
+
+// TestStackFamily_DBClosed_Returns503 — Family's first DB query fails.
+func TestStackFamily_DBClosed_Returns503(t *testing.T) {
+	dbFaultNeedsDB(t)
+	app, _ := closedDBApp(t)
+	req := httptest.NewRequest(http.MethodGet, "/stacks/some-slug/family", nil)
+	req.Header.Set("Authorization", "Bearer "+dbFaultJWT(t))
+	resp, err := app.Test(req, 5000)
+	require.NoError(t, err)
+	defer resp.Body.Close()
+	assert.Equal(t, http.StatusServiceUnavailable, resp.StatusCode)
+}