Skip to content

Commit 1d61fda

Browse files
ci(coverage): remove || true test-masking (CLAUDE.md rule 12)
Per the audit at /tmp/ci-audit-2026-05-22.md, the coverage workflow's test step was suppressing failures with `|| true` while still uploading whatever partial coverage data accumulated. This made the workflow report green even when tests failed silently — exactly the bug class CLAUDE.md rule 12 calls out (shipped != verified). Fix: drop `|| true`. Move codecov upload to `if: always()` so coverage still uploads on test failures but the workflow conclusion now reflects actual test status. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 122cef9 commit 1d61fda

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

.github/workflows/coverage.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,9 @@ jobs:
3232
go-version-file: cli/go.mod
3333
- name: Generate coverage
3434
working-directory: cli
35-
run: go test ./... -short -coverprofile=coverage.out -covermode=atomic || true
35+
run: go test ./... -short -coverprofile=coverage.out -covermode=atomic
3636
- uses: codecov/codecov-action@v4
37+
if: always()
3738
with:
3839
files: cli/coverage.out
3940
flags: cli

0 commit comments

Comments
 (0)