Skip to content

Commit 627260f

Browse files
ci(coverage): remove || true test-masking (CLAUDE.md rule 12)
Per the audit at /tmp/ci-audit-2026-05-22.md, the coverage workflow's test step was suppressing failures with `|| true` while still uploading whatever partial coverage data accumulated. This made the workflow report green even when tests failed silently — exactly the bug class CLAUDE.md rule 12 calls out (shipped != verified). Fix: drop `|| true`. Move codecov upload to `if: always()` so coverage still uploads on test failures but the workflow conclusion now reflects actual test status. (For common only — also brings ci.yml branch trigger in line with the [master, main] convention used by every other repo.) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent d7d02f7 commit 627260f

2 files changed

Lines changed: 4 additions & 3 deletions

File tree

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@ name: CI
22

33
on:
44
push:
5-
branches: [main]
5+
branches: [master, main]
66
pull_request:
7-
branches: [main]
7+
branches: [master, main]
88

99
jobs:
1010
build-and-test:

.github/workflows/coverage.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,9 @@ jobs:
2727
go-version-file: common/go.mod
2828
- name: Generate coverage
2929
working-directory: common
30-
run: go test ./... -short -coverprofile=coverage.out -covermode=atomic || true
30+
run: go test ./... -short -coverprofile=coverage.out -covermode=atomic
3131
- uses: codecov/codecov-action@v4
32+
if: always()
3233
with:
3334
files: common/coverage.out
3435
flags: common

0 commit comments

Comments
 (0)