UI nuance fixes — error handling, stale localStorage, misleading copy

- pricing.html: POST /billing/create-order error path no longer paints a
  raw response body; only a safe body.message or a generic string.
  Razorpay payment.failed description bounded to 140 chars before surfacing.
  Outer catch shows a friendly-only string.
- pricing.html: footnote "Cancel anytime from the dashboard" replaced with
  a mailto link — there is no cancel endpoint today, so the old copy was
  a false promise.
- terms.html: same — cancellation goes through admin@instanode.dev.
- dashboard.html: migrate() catches network errors so a dropped claim
  doesn't nuke the whole dashboard boot. localStorage.instanode_token is
  cleared after any claim attempt (success or fail) so a later visitor on
  a shared device doesn't try to re-claim someone else's token.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: mastermanas805

dashboard.html

@@ -509,7 +509,11 @@ <h2 id="apikey-heading">API token for CLI / agent</h2>
         .then(function (res) {
           if (res.status === 401) { goStart(); return false; }
           return res.ok;
-        });
+        })
+        // Network failure here must not blow away the dashboard. The
+        // outer boot .catch() would render a full-page error otherwise;
+        // we just return false so the caller shows a toast.
+        .catch(function () { return false; });
     }
 
     document.getElementById('logoutBtn').addEventListener('click', function () {
@@ -561,6 +565,10 @@ <h2 id="apikey-heading">API token for CLI / agent</h2>
         }
         var next = Promise.resolve();
         if (claimToken) next = migrate(claimToken).then(function (ok) {
+          // Clear the token either way — stale localStorage would otherwise
+          // cause the next visitor on a shared device to try to re-claim
+          // somebody else's resource.
+          try { localStorage.removeItem('instanode_token'); } catch (e) {}
           toast(ok ? 'Resource claimed to your account.' : 'Could not claim resource.', ok ? '' : 'err');
         });
         next.then(loadResources);

pricing.html

@@ -268,7 +268,7 @@ <h1>Upgrade to Developer</h1>
     </div>
 
     <p class="footnote">
-      Secure checkout by Razorpay. Cancel anytime from the <a href="/dashboard">dashboard</a>.
+      Secure checkout by Razorpay. Questions? Email <a href="mailto:admin@instanode.dev">admin@instanode.dev</a>.
     </p>
 
     <footer class="site">
@@ -352,8 +352,18 @@ <h1>Upgrade to Developer</h1>
               return null;
             }
             if (!res.ok) {
-              return res.text().then(function (t) {
-                throw new Error(t && t.length < 200 ? t : ('HTTP ' + res.status));
+              // Parse JSON body for a safe `message` from our own API; never
+              // surface raw text() (could be an HTML error page from a
+              // reverse proxy, or contain internal detail from an upstream).
+              return res.json().then(function (body) {
+                var safe = body && typeof body.message === 'string' ? body.message : '';
+                var e = new Error(safe || 'Checkout could not be started. Please try again in a moment.');
+                e.friendly = true;
+                throw e;
+              }, function () {
+                var e = new Error('Checkout could not be started. Please try again in a moment.');
+                e.friendly = true;
+                throw e;
               });
             }
             return res.json();
@@ -389,15 +399,32 @@ <h1>Upgrade to Developer</h1>
             rzp.on('payment.failed', function (resp) {
               btn.disabled = false;
               btn.textContent = resetLabel;
-              var reason = (resp && resp.error && (resp.error.description || resp.error.reason)) || 'Payment failed.';
-              showMsg(planID, 'error', reason + ' Please try again.');
+              // Razorpay's resp.error.description is gateway-controlled text.
+              // Only surface it when it's a short, human-ish string; otherwise
+              // fall back to a generic message so we never paint long SDK
+              // stack traces or vendor error codes into the UI.
+              var raw = resp && resp.error && (resp.error.description || resp.error.reason);
+              var safe = '';
+              if (typeof raw === 'string' && raw.length > 0 && raw.length <= 140) {
+                safe = raw;
+              }
+              showMsg(planID, 'error', safe
+                ? (safe + ' Please try again.')
+                : 'Payment failed. Please try a different card or retry in a moment.');
             });
             rzp.open();
           })
           .catch(function (err) {
             btn.disabled = false;
             btn.textContent = resetLabel;
-            showMsg(planID, 'error', 'Could not start checkout: ' + (err && err.message ? err.message : 'unknown error'));
+            // err.friendly === true means the message came from our own API
+            // via a safe `message` field. Anything else (network failure,
+            // browser block) we render as a generic retry prompt so we
+            // never paint stack traces or CORS strings at the user.
+            var text = (err && err.friendly && err.message)
+              ? err.message
+              : 'Could not reach the checkout service. Please check your connection and retry.';
+            showMsg(planID, 'error', text);
           });
       }
 

terms.html

@@ -118,7 +118,7 @@ <h2>Developer tier — $12/month or $120/year</h2>
       <ul>
         <li>Billed in advance via Razorpay. Monthly plan renews each month. Annual plan renews once a year and is discounted to $120 (equivalent to $10/month).</li>
         <li>Resources persist until you delete them or cancel.</li>
-        <li>Cancel anytime from the dashboard. Cancellation stops the next renewal; the current billing period remains active.</li>
+        <li>Cancel anytime by emailing <a href="mailto:admin@instanode.dev">admin@instanode.dev</a>. Cancellation stops the next renewal; the current billing period remains active.</li>
         <li>Higher quotas — see <a href="/pricing.html">pricing</a> for exact limits.</li>
       </ul>