Merge pull request #47 from InstaNode-dev/fix/playwright-ci-gate-fresh

e2e: fix navigation + resources playwright specs (admin-bypass becomes unnecessary)

Author: mastermanas805

e2e/fixtures.ts

@@ -70,8 +70,11 @@ export async function installAPIFake(page: Page) {
     }),
   )
 
-  // GET /api/v1/resources
-  await page.route('**/api/v1/resources', (route: Route) => {
+  // GET /api/v1/resources (optional ?env=... query string — ResourcesPage
+  // calls listResources(ctx.env) which produces /api/v1/resources?env=production).
+  // A bare-glob `**/api/v1/resources` only matches the no-query path, so we
+  // use a regex anchored on the path + optional query string.
+  await page.route(/\/api\/v1\/resources(\?[^/]*)?$/, (route: Route) => {
     if (route.request().method() === 'GET') {
       return route.fulfill({
         status: 200,

e2e/navigation.spec.ts

@@ -10,13 +10,16 @@ test.describe('Navigation', () => {
   test('every nav link reaches its page', async ({ page }) => {
     // The authenticated app is mounted under /app/*; the sidebar nav links
     // point to /app/<section>. The Overview is just /app (or /app/).
+    //
+    // Tracks the live AppShell sidebar — Stacks was retired (b13b8ee:
+    // "/app/stacks duplicate route + StacksPage.tsx deleted, same data as
+    // Deployments") and Team has no sidebar nav link in the user-facing
+    // sidebar (the route exists but is no longer linked from chrome).
     await page.goto('/app')
     const targets: { name: RegExp; pathFragment?: string }[] = [
       { name: /Resources/i, pathFragment: '/app/resources' },
       { name: /Deployments/i, pathFragment: '/app/deployments' },
-      { name: /Stacks/i, pathFragment: '/app/stacks' },
       { name: /Vault/i, pathFragment: '/app/vault' },
-      { name: /Team/i, pathFragment: '/app/team' },
       { name: /Billing/i, pathFragment: '/app/billing' },
       { name: /Settings/i, pathFragment: '/app/settings' },
       { name: /Overview/i, pathFragment: '/app' },

src/App.tsx

@@ -1,5 +1,5 @@
 import { lazy, Suspense } from 'react'
-import { BrowserRouter, Navigate, Route, Routes, useLocation } from 'react-router-dom'
+import { BrowserRouter, Navigate, Route, Routes, useLocation, useParams } from 'react-router-dom'
 
 // Homepage — eagerly imported. It's the cold-load path and the most-visited
 // public surface, so it stays in the main entry chunk.
@@ -115,6 +115,19 @@ function AuthGate({ children }: { children: JSX.Element }) {
   return children
 }
 
+// LegacyRedirect — <Navigate to="/app/resources/:id"> sends a literal ":id"
+// string instead of the captured route param (Navigate is dumb — it doesn't
+// interpolate). This wrapper reads the param and constructs the real
+// destination so /resources/<token> → /app/resources/<token> works.
+function LegacyResourceRedirect() {
+  const { id = '' } = useParams()
+  return <Navigate to={`/app/resources/${id}`} replace />
+}
+function LegacyDeploymentRedirect() {
+  const { id = '' } = useParams()
+  return <Navigate to={`/app/deployments/${id}`} replace />
+}
+
 // AppLoadingFallback — shown while a lazy-loaded /app/* chunk is in flight.
 // Tiny inline style so it renders even before the page's own CSS resolves.
 // In practice this fallback is on screen for ~50-150ms on a warm cache.
@@ -209,12 +222,16 @@ export function AppRoutes() {
         </Route>
 
         {/* Back-compat: every legacy unprefixed path that used to be a
-            dashboard route now redirects under /app. */}
+            dashboard route now redirects under /app. Parameterized routes
+            use a wrapper that interpolates the captured param — see
+            LegacyResourceRedirect / LegacyDeploymentRedirect above
+            (Navigate's `to` is literal, not parameterized). */}
         <Route path="/resources" element={<Navigate to="/app/resources" replace />} />
-        <Route path="/resources/:id" element={<Navigate to="/app/resources/:id" replace />} />
+        <Route path="/resources/:id" element={<LegacyResourceRedirect />} />
         <Route path="/deployments" element={<Navigate to="/app/deployments" replace />} />
-        <Route path="/deployments/:id" element={<Navigate to="/app/deployments/:id" replace />} />
-        <Route path="/stacks" element={<Navigate to="/app/stacks" replace />} />
+        <Route path="/deployments/:id" element={<LegacyDeploymentRedirect />} />
+        {/* /stacks legacy path retired with the route (b13b8ee). Falls
+            through to the catch-all → /. */}
         <Route path="/vault" element={<Navigate to="/app/vault" replace />} />
         <Route path="/team" element={<Navigate to="/app/team" replace />} />
         <Route path="/billing" element={<Navigate to="/app/billing" replace />} />