fix(cli-auth): provision /cli-auth route (was 404 on instanode.dev) (#129)

User reported "That page is not provisioned" when CLI device-flow
emitted `https://instanode.dev/cli-auth?cli_session=…`. The route
wasn't defined on the marketing site — it had to be either on the
dashboard OR a redirect from instanode.dev to the dashboard.

Fix: defensive redirect route `/cli-auth` → `/login?cli_session=<id>`.

Details:
- The api currently emits the canonical `/login?cli_session=<id>`
  path (cli_auth.go since commit 0c7991c, B13-P0-F1 2026-05-20).
- `/cli-auth` was never a real route — but it appears in
  `cli/cmd/testapi_test.go` (the hermetic test mock writes
  `https://instanode.dev/cli-auth?s=test`) and in any stale
  terminal scrollback / chat transcript a user pastes.
- Without a route, `/cli-auth` fell through to the catch-all
  NotFoundPage → 404.

Implementation:
- New `CliAuthRedirect` component in App.tsx normalizes both query
  shapes: `?cli_session=<id>` and `?s=<id>` (test-mock shape) →
  canonical `/login?cli_session=<id>`. Bare `/cli-auth` → `/login`.
- Route registered in App.tsx alongside the legacy /resources,
  /vault, /team, /billing redirects.
- `scripts/prerender.mjs` adds `/cli-auth` to authShellRoutes so
  `dist/cli-auth/index.html` is written at build time — otherwise
  GH Pages would 404 before the SPA shell could boot the Navigate.
- `ROUTE_META['/cli-auth']` adds a sensible <title> for the brief
  moment before the redirect runs.
- 5 unit tests in `src/App.cli-auth.test.tsx` lock in the contract:
  param preservation, ?s→cli_session rewrite, bare-fallback, URL
  encoding of reserved characters, cli_session-wins-over-s when
  both are present.

Does NOT touch the working `/login?cli_session=...` flow that the
api emits — that path remains canonical. This is purely a defensive
redirect for the legacy URL shape.

Verification:
- `npx tsc --noEmit`: clean
- `npx vitest run`: 769 passed, 3 skipped, 0 failed (full suite)
- `npm run build`: SSR prerender wrote 4 auth SPA shells (was 3);
  `dist/cli-auth/index.html` exists with title "Signing in CLI… · instanode"

Co-authored-by: Claude <claude@anthropic.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: mastermanas805

scripts/prerender.mjs

@@ -178,6 +178,14 @@ const ROUTE_META = {
     description:
       'Claim the anonymous resources your agent provisioned and convert them to a permanent team account.',
   },
+  // /cli-auth — defensive redirect to /login?cli_session=<s> (App.tsx
+  // CliAuthRedirect). Even though the visible time on this URL is a few
+  // ms before the Navigate runs, the SPA shell still needs a meaningful
+  // <title> so the tab strip doesn't briefly flash the homepage title.
+  '/cli-auth': {
+    title: 'Signing in CLI… · instanode',
+    description: 'Completing CLI device-flow sign-in for instanode.dev.',
+  },
   // /app is the dashboard SPA entry. Visitors who type instanode.dev/app
   // hit this shell before AuthGate runs; a meaningful title is friendlier
   // than the homepage title bleeding through.
@@ -416,7 +424,12 @@ async function main() {
   // /login in a new tab saw the wrong title, breaking WCAG 2.4.2 and
   // confusing tab-strip navigation. metaForRoute() returns sensible
   // titles for /login, /login/callback, and /claim from ROUTE_META.
-  const authShellRoutes = ['/login', '/login/callback', '/claim']
+  // /cli-auth — defensive redirect emitted by App.tsx's CliAuthRedirect.
+  // The api emits the canonical /login?cli_session=<id>, but /cli-auth
+  // appears in the CLI test mock and any stale terminal scrollback /
+  // chat transcript a user pastes. Without an entry under dist/cli-auth/,
+  // GH Pages returns its 404 shell and the React Navigate never runs.
+  const authShellRoutes = ['/login', '/login/callback', '/claim', '/cli-auth']
   for (const route of authShellRoutes) {
     const p = resolve(DIST, route.replace(/^\//, ''), 'index.html')
     await mkdir(dirname(p), { recursive: true })

src/App.cli-auth.test.tsx

@@ -0,0 +1,135 @@
+/* App.cli-auth.test.tsx — fix/cli-auth-route.
+ *
+ * Pins the /cli-auth redirect contract.
+ *
+ * Background: a user reported "That page is not provisioned" hitting
+ * https://instanode.dev/cli-auth — the api emits the canonical
+ * /login?cli_session=<id> path (since 0c7991c) but /cli-auth still
+ * appears in the CLI test mock and any old terminal scrollback /
+ * chat transcript a user pastes. Without a route, /cli-auth fell
+ * through to the catch-all NotFoundPage.
+ *
+ * The fix is App.tsx's CliAuthRedirect — a Navigate that normalizes
+ *   /cli-auth?cli_session=<id>  → /login?cli_session=<id>
+ *   /cli-auth?s=<id>            → /login?cli_session=<id>   (test-mock shape)
+ *   /cli-auth                   → /login                    (no param)
+ *
+ * These tests fail closed if a future refactor drops the param
+ * preservation, drops the s→cli_session rename, or routes to the
+ * wrong destination.
+ */
+
+import { describe, it, expect, afterEach } from 'vitest'
+import { render, cleanup } from '@testing-library/react'
+import { MemoryRouter, Routes, Route, useLocation } from 'react-router-dom'
+import { CliAuthRedirect } from './App'
+
+// LocationSink — renders the current router pathname + search so the
+// test can assert what CliAuthRedirect's <Navigate> landed on. We
+// can't read window.location for this because MemoryRouter doesn't
+// touch the global — it updates its internal context only. useLocation
+// is the right truth surface.
+function LocationSink() {
+  const loc = useLocation()
+  return <div data-testid="landed">{loc.pathname + loc.search}</div>
+}
+
+// CliAuthRedirect reads window.location.search directly (so it can
+// preserve the query through Navigate). MemoryRouter doesn't update
+// window.location, so we stub it per test.
+const realLocation = window.location
+
+function stubLocation(search: string) {
+  // jsdom's window.location is read-only as a whole, but its
+  // individual properties (.search) are configurable. Reassign just
+  // what we need.
+  Object.defineProperty(window, 'location', {
+    configurable: true,
+    value: { ...realLocation, search },
+    writable: true,
+  })
+}
+
+afterEach(() => {
+  Object.defineProperty(window, 'location', {
+    configurable: true,
+    value: realLocation,
+    writable: true,
+  })
+  cleanup()
+})
+
+// Helper — mount CliAuthRedirect with a sink route that renders the
+// landed-on pathname + search so we can assert the redirect target.
+function mountAt(initialEntry: string, search: string) {
+  stubLocation(search)
+  return render(
+    <MemoryRouter initialEntries={[initialEntry]}>
+      <Routes>
+        <Route path="/cli-auth" element={<CliAuthRedirect />} />
+        <Route path="/login" element={<LocationSink />} />
+      </Routes>
+    </MemoryRouter>,
+  )
+}
+
+describe('CliAuthRedirect — /cli-auth defensive redirect (fix/cli-auth-route)', () => {
+  it('preserves ?cli_session=<id> into /login?cli_session=<id>', () => {
+    const { container } = mountAt('/cli-auth?cli_session=abc123', '?cli_session=abc123')
+    // The Navigate runs synchronously during render — by the time
+    // the assertion runs, the second route should be mounted.
+    const landed = container.querySelector('[data-testid="landed"]')
+    expect(landed).not.toBeNull()
+    expect(landed?.textContent).toContain('/login')
+    expect(landed?.textContent).toContain('cli_session=abc123')
+  })
+
+  it('rewrites ?s=<id> (test-mock shape) into /login?cli_session=<id>', () => {
+    const { container } = mountAt('/cli-auth?s=test', '?s=test')
+    const landed = container.querySelector('[data-testid="landed"]')
+    expect(landed).not.toBeNull()
+    expect(landed?.textContent).toContain('cli_session=test')
+    // The original ?s= form must NOT leak through unchanged — that
+    // would mean the LoginPage couldn't find the session.
+    expect(landed?.textContent).not.toMatch(/[?&]s=/)
+  })
+
+  it('falls back to /login (no param) when query is empty', () => {
+    const { container } = mountAt('/cli-auth', '')
+    const landed = container.querySelector('[data-testid="landed"]')
+    expect(landed).not.toBeNull()
+    // No cli_session param — bare /login.
+    expect(landed?.textContent).toBe('/login')
+  })
+
+  it('URL-encodes a session id containing reserved characters', () => {
+    // /cli-auth?cli_session=a/b%20d
+    // URLSearchParams.get('cli_session') decodes %20 → ' ', leaving 'a/b d'.
+    // encodeURIComponent then re-encodes: '/' → '%2F', ' ' → '%20'.
+    // Net effect: the canonical /login link is well-formed.
+    const { container } = mountAt(
+      '/cli-auth?cli_session=a/b%20d',
+      '?cli_session=a/b%20d',
+    )
+    const landed = container.querySelector('[data-testid="landed"]')
+    expect(landed).not.toBeNull()
+    expect(landed?.textContent).toContain('cli_session=a%2Fb%20d')
+    // Unencoded '/' would break a URL parser that interprets the
+    // path/query boundary — fail fast if a future refactor drops the
+    // encodeURIComponent call.
+    expect(landed?.textContent).not.toMatch(/cli_session=a\/b/)
+  })
+
+  it('prefers cli_session over s when both are present', () => {
+    // Defensive: if a stale link somehow carries both, the canonical
+    // name wins.
+    const { container } = mountAt(
+      '/cli-auth?cli_session=real&s=stale',
+      '?cli_session=real&s=stale',
+    )
+    const landed = container.querySelector('[data-testid="landed"]')
+    expect(landed).not.toBeNull()
+    expect(landed?.textContent).toContain('cli_session=real')
+    expect(landed?.textContent).not.toContain('stale')
+  })
+})

src/App.tsx

@@ -208,6 +208,36 @@ function LegacyDeploymentRedirect() {
   return <Navigate to={`/app/deployments/${id}`} replace />
 }
 
+// CliAuthRedirect — defensive fallback for the /cli-auth path.
+//
+// The canonical CLI device-flow URL the api emits today is
+// /login?cli_session=<id>. /cli-auth was never a real route on
+// instanode.dev — but it appears as a stale URL in:
+//   - cli/cmd/testapi_test.go (hermetic test mock — "?s=test")
+//   - any old terminal scrollback / chat transcript a user pastes
+//   - any external docs we missed
+// Until the test mock is rewritten AND every CLI binary in the wild
+// has rotated, /cli-auth must not 404. We normalize ?s=<id> and
+// ?cli_session=<id> to the canonical /login?cli_session=<id> path so
+// the user lands on the real login form with the session preserved.
+//
+// Note: NO query param → still redirect to /login. The LoginPage's
+// session_expired banner and OAuth start paths both work without a
+// cli_session, so this is safe.
+// Exported for unit testing in App.cli-auth.test.tsx — keeps the redirect
+// logic verifiable without mounting the full lazy-loaded route tree.
+export function CliAuthRedirect() {
+  if (typeof window === 'undefined') {
+    // SSR: emit a Navigate without a query string. The client will
+    // re-run and pick the query up from window.location.search.
+    return <Navigate to="/login" replace />
+  }
+  const params = new URLSearchParams(window.location.search)
+  const session = params.get('cli_session') || params.get('s') || ''
+  const dest = session ? `/login?cli_session=${encodeURIComponent(session)}` : '/login'
+  return <Navigate to={dest} replace />
+}
+
 // AppLoadingFallback — shown while a lazy-loaded /app/* chunk is in flight.
 // Tiny inline style so it renders even before the page's own CSS resolves.
 // In practice this fallback is on screen for ~50-150ms on a warm cache.
@@ -349,6 +379,13 @@ export function AppRoutes() {
         <Route path="/team" element={<Navigate to="/app/team" replace />} />
         <Route path="/billing" element={<Navigate to="/app/billing" replace />} />
         <Route path="/settings" element={<Navigate to="/app/settings" replace />} />
+        {/* /cli-auth — defensive redirect to the canonical /login?cli_session=<s>.
+            The api has always emitted /login?cli_session=...; /cli-auth was
+            never a real route. But it surfaces in the CLI test mock and in
+            any stale terminal scrollback / chat transcript a user pastes.
+            Without this route, /cli-auth fell through to the catch-all 404.
+            See CliAuthRedirect above for the param-preservation logic. */}
+        <Route path="/cli-auth" element={<CliAuthRedirect />} />
 
         {/* B1-P1 (2026-05-20): real 404 page replaces the silent
             redirect-to-homepage. The same NotFoundPage is also