Skip to content

Commit b9a30c8

Browse files
ci(coverage): remove || true test-masking (CLAUDE.md rule 12) (#130)
Per the audit at /tmp/ci-audit-2026-05-22.md, the coverage workflow's test step was suppressing failures with `|| true` while still uploading whatever partial coverage data accumulated. This made the workflow report green even when tests failed silently — exactly the bug class CLAUDE.md rule 12 calls out (shipped != verified). Fix: drop `|| true`. Move codecov upload to `if: always()` so coverage still uploads on test failures but the workflow conclusion now reflects actual test status. Co-authored-by: Claude <claude@anthropic.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 6d05222 commit b9a30c8

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

.github/workflows/coverage.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,8 @@ jobs:
2020
node-version: 20
2121
cache: npm
2222
- run: npm ci
23-
- run: npm test -- --coverage || true
23+
- run: npm test -- --coverage
2424
- uses: codecov/codecov-action@v4
25+
if: always()
2526
with:
2627
fail_ci_if_error: false

0 commit comments

Comments
 (0)