|
| 1 | +// MetricsPanel.test.tsx — unit tests for the Metrics tab on |
| 2 | +// ResourceDetailPage. Three behaviours worth pinning: |
| 3 | +// |
| 4 | +// 1. Happy path: a non-stub response renders three charts + no banner. |
| 5 | +// 2. Stub mode: the yellow "metrics will populate" banner renders + the |
| 6 | +// data_source-stub branch does NOT swap layout (charts still mount). |
| 7 | +// 3. 402 upgrade-required: the upgrade prompt renders instead of charts. |
| 8 | +// |
| 9 | +// We mock `api.getResourceMetrics` directly because that's where the wire |
| 10 | +// shape lives — pulling in MSW or fetch-mock for one endpoint would add |
| 11 | +// more setup than the test surface justifies. |
| 12 | + |
| 13 | +import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest' |
| 14 | +import { render, screen, cleanup, waitFor } from '@testing-library/react' |
| 15 | +import { MetricsPanel } from './MetricsPanel' |
| 16 | +import * as api from '../api' |
| 17 | + |
| 18 | +afterEach(() => { |
| 19 | + cleanup() |
| 20 | + vi.restoreAllMocks() |
| 21 | +}) |
| 22 | + |
| 23 | +function makeFakeMetrics(overrides: Partial<api.ResourceMetricsResponse> = {}): api.ResourceMetricsResponse { |
| 24 | + // Deterministic synthetic series — sample values are fine because the |
| 25 | + // chart code only normalises against min/max. |
| 26 | + const sixty = Array.from({ length: 60 }, (_, i) => i + 1) |
| 27 | + return { |
| 28 | + ok: true, |
| 29 | + resource_id: 'aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee', |
| 30 | + resource_type: 'postgres', |
| 31 | + window_seconds: 3600, |
| 32 | + samples_count: 60, |
| 33 | + sample_interval_seconds: 60, |
| 34 | + metrics: { |
| 35 | + latency_p50_ms: sixty.map((v) => v * 0.05), |
| 36 | + latency_p95_ms: sixty.map((v) => v * 0.13), |
| 37 | + latency_p99_ms: sixty.map((v) => v * 0.30), |
| 38 | + connections_active: sixty.map((v) => 3 + (v % 3)), |
| 39 | + storage_bytes: sixty.map((v) => 1_000_000 + v * 50_000), |
| 40 | + error_rate_pct: sixty.map(() => 0), |
| 41 | + }, |
| 42 | + data_source: 'newrelic', |
| 43 | + ...overrides, |
| 44 | + } |
| 45 | +} |
| 46 | + |
| 47 | +describe('MetricsPanel — happy path (real data)', () => { |
| 48 | + beforeEach(() => { |
| 49 | + vi.spyOn(api, 'getResourceMetrics').mockResolvedValue(makeFakeMetrics()) |
| 50 | + }) |
| 51 | + |
| 52 | + it('renders all three charts after the fetch resolves', async () => { |
| 53 | + render(<MetricsPanel resourceId="aaaa1111-bbbb-cccc-dddd-eeeeeeeeeeee" />) |
| 54 | + await waitFor(() => { |
| 55 | + expect(screen.getByTestId('metrics-panel')).toBeTruthy() |
| 56 | + }) |
| 57 | + |
| 58 | + // Latency chart + connections chart = 2 SVG line charts. |
| 59 | + // Storage tile is a number tile, not a chart. |
| 60 | + expect(screen.getAllByTestId('metrics-chart').length).toBe(2) |
| 61 | + expect(screen.getByTestId('metrics-storage-tile')).toBeTruthy() |
| 62 | + }) |
| 63 | + |
| 64 | + it('does NOT render the stub banner when data_source is not "stub"', async () => { |
| 65 | + render(<MetricsPanel resourceId="aaaa1111-bbbb-cccc-dddd-eeeeeeeeeeee" />) |
| 66 | + await waitFor(() => { |
| 67 | + expect(screen.getByTestId('metrics-panel')).toBeTruthy() |
| 68 | + }) |
| 69 | + expect(screen.queryByTestId('metrics-stub-banner')).toBeNull() |
| 70 | + }) |
| 71 | + |
| 72 | + it('renders three p50/p95/p99 series inside the latency chart', async () => { |
| 73 | + render(<MetricsPanel resourceId="aaaa1111-bbbb-cccc-dddd-eeeeeeeeeeee" />) |
| 74 | + await waitFor(() => { |
| 75 | + expect(screen.getByTestId('metrics-panel')).toBeTruthy() |
| 76 | + }) |
| 77 | + |
| 78 | + const charts = screen.getAllByTestId('metrics-chart') |
| 79 | + const latencyChart = charts[0] // First Card is Latency |
| 80 | + // Each series is a <path data-series="..."/>. Three series → three paths. |
| 81 | + const seriesPaths = latencyChart.querySelectorAll('path[data-series]') |
| 82 | + expect(seriesPaths.length).toBe(3) |
| 83 | + expect(seriesPaths[0].getAttribute('data-series')).toBe('p50') |
| 84 | + expect(seriesPaths[1].getAttribute('data-series')).toBe('p95') |
| 85 | + expect(seriesPaths[2].getAttribute('data-series')).toBe('p99') |
| 86 | + }) |
| 87 | + |
| 88 | + it('storage tile renders a positive delta when storage grew across the window', async () => { |
| 89 | + render(<MetricsPanel resourceId="aaaa1111-bbbb-cccc-dddd-eeeeeeeeeeee" />) |
| 90 | + await waitFor(() => { |
| 91 | + expect(screen.getByTestId('metrics-storage-delta')).toBeTruthy() |
| 92 | + }) |
| 93 | + const delta = screen.getByTestId('metrics-storage-delta') |
| 94 | + // Synthetic data starts at 1_050_000 and ends at 4_000_000 (~). The sign |
| 95 | + // must be "+" because the series is strictly increasing. |
| 96 | + expect(delta.textContent).toContain('+') |
| 97 | + }) |
| 98 | +}) |
| 99 | + |
| 100 | +describe('MetricsPanel — stub mode', () => { |
| 101 | + beforeEach(() => { |
| 102 | + vi.spyOn(api, 'getResourceMetrics').mockResolvedValue( |
| 103 | + makeFakeMetrics({ data_source: 'stub' }), |
| 104 | + ) |
| 105 | + }) |
| 106 | + |
| 107 | + it('renders the yellow "metrics will populate" banner', async () => { |
| 108 | + render(<MetricsPanel resourceId="aaaa1111-bbbb-cccc-dddd-eeeeeeeeeeee" />) |
| 109 | + await waitFor(() => { |
| 110 | + expect(screen.getByTestId('metrics-stub-banner')).toBeTruthy() |
| 111 | + }) |
| 112 | + const banner = screen.getByTestId('metrics-stub-banner') |
| 113 | + expect(banner.textContent).toContain('Metrics will populate') |
| 114 | + expect(banner.textContent).toContain('5 minutes') |
| 115 | + }) |
| 116 | + |
| 117 | + it('still renders the charts (layout does not shift when stub flips off)', async () => { |
| 118 | + render(<MetricsPanel resourceId="aaaa1111-bbbb-cccc-dddd-eeeeeeeeeeee" />) |
| 119 | + await waitFor(() => { |
| 120 | + expect(screen.getByTestId('metrics-panel')).toBeTruthy() |
| 121 | + }) |
| 122 | + expect(screen.getAllByTestId('metrics-chart').length).toBe(2) |
| 123 | + expect(screen.getByTestId('metrics-storage-tile')).toBeTruthy() |
| 124 | + }) |
| 125 | +}) |
| 126 | + |
| 127 | +describe('MetricsPanel — tier wall (402)', () => { |
| 128 | + beforeEach(() => { |
| 129 | + // Simulate the APIError shape thrown by the api/index.ts call() wrapper. |
| 130 | + // The wrapper sets `.status` and `.code` on Error before rejecting. |
| 131 | + const err = Object.assign(new Error('Resource metrics require the Pro plan or higher.'), { |
| 132 | + status: 402, |
| 133 | + code: 'upgrade_required', |
| 134 | + }) |
| 135 | + vi.spyOn(api, 'getResourceMetrics').mockRejectedValue(err) |
| 136 | + }) |
| 137 | + |
| 138 | + it('renders the upgrade prompt instead of charts', async () => { |
| 139 | + render(<MetricsPanel resourceId="aaaa1111-bbbb-cccc-dddd-eeeeeeeeeeee" />) |
| 140 | + await waitFor(() => { |
| 141 | + expect(screen.getByTestId('metrics-upgrade-required')).toBeTruthy() |
| 142 | + }) |
| 143 | + // No chart elements rendered on the 402 path — calmer surface. |
| 144 | + expect(screen.queryAllByTestId('metrics-chart').length).toBe(0) |
| 145 | + expect(screen.queryByTestId('metrics-storage-tile')).toBeNull() |
| 146 | + |
| 147 | + const card = screen.getByTestId('metrics-upgrade-required') |
| 148 | + expect(card.textContent).toContain('Pro') |
| 149 | + expect(card.textContent).toContain('Upgrade') |
| 150 | + }) |
| 151 | +}) |
| 152 | + |
| 153 | +describe('MetricsPanel — generic error', () => { |
| 154 | + beforeEach(() => { |
| 155 | + const err = Object.assign(new Error('boom'), { status: 503, code: 'fetch_failed' }) |
| 156 | + vi.spyOn(api, 'getResourceMetrics').mockRejectedValue(err) |
| 157 | + }) |
| 158 | + |
| 159 | + it('renders the error message in an alert region', async () => { |
| 160 | + render(<MetricsPanel resourceId="aaaa1111-bbbb-cccc-dddd-eeeeeeeeeeee" />) |
| 161 | + await waitFor(() => { |
| 162 | + expect(screen.getByTestId('metrics-error')).toBeTruthy() |
| 163 | + }) |
| 164 | + const err = screen.getByTestId('metrics-error') |
| 165 | + expect(err.textContent).toContain('boom') |
| 166 | + expect(err.getAttribute('role')).toBe('alert') |
| 167 | + }) |
| 168 | +}) |
0 commit comments