Merge pull request #40 from InstaNode-dev/pricing/p1-ab-button-fresh

experiments: A/B render of upgrade button label/color per /auth/me variant (P1)

Author: mastermanas805

src/api/index.test.ts

@@ -30,6 +30,7 @@ import {
   fetchStackFamily,
   listDeployments,
   getDeployment,
+  reportExperimentConverted,
   validatePromotion,
 } from './index'
 // §10.21: FIXTURE_BILLING / FIXTURE_INVOICES imports retired. The 503
@@ -607,6 +608,41 @@ describe('fetchMe()', () => {
     m.mockResolvedValueOnce(jsonResponse({ error: 'boom' }, { status: 500 }))
     await expect(fetchMe()).rejects.toBeDefined()
   })
+
+  it('passes through the experiments map from the agent API', async () => {
+    // P1 pricing experiment — /auth/me now embeds a server-bucketed
+    // experiments map. The dashboard's UpgradeButton component reads
+    // `me.experiments.upgrade_button` to decide which variant to render.
+    const m = installFetch()
+    m.mockResolvedValueOnce(jsonResponse({
+      ok: true,
+      user_id: 'u_xyz',
+      team_id: 't_xyz',
+      email: 'agent@instanode.dev',
+      tier: 'pro',
+      trial_ends_at: null,
+      experiments: { upgrade_button: 'urgent' },
+    }))
+    const r = await fetchMe()
+    expect(r.experiments).toEqual({ upgrade_button: 'urgent' })
+  })
+
+  it('omits experiments cleanly when the agent API does not return the field', async () => {
+    // Older API builds (pre-P1) don't return an experiments field.
+    // The dashboard must handle that without throwing — UpgradeButton
+    // falls back to "control" via normalizeVariant().
+    const m = installFetch()
+    m.mockResolvedValueOnce(jsonResponse({
+      ok: true,
+      user_id: 'u_xyz',
+      team_id: 't_xyz',
+      email: 'agent@instanode.dev',
+      tier: 'pro',
+      trial_ends_at: null,
+    }))
+    const r = await fetchMe()
+    expect(r.experiments).toBeUndefined()
+  })
 })
 
 // ─── listResources() / deleteResource() (smoke for shape adaptation) ─────
@@ -999,3 +1035,48 @@ describe('fetchStackFamily()', () => {
     expect(String(url)).toContain('/api/v1/stacks/stk%20weird%2Fslug/family')
   })
 })
+
+// ─── reportExperimentConverted() ─────────────────────────────────────────
+describe('reportExperimentConverted()', () => {
+  it('POSTs the right payload to /api/v1/experiments/converted', async () => {
+    const m = installFetch()
+    m.mockResolvedValueOnce(jsonResponse({ ok: true }))
+    await reportExperimentConverted({
+      experiment: 'upgrade_button',
+      variant: 'urgent',
+      action: 'checkout_started',
+    })
+    const [url, init] = m.mock.calls[0]
+    expect(String(url)).toContain('/api/v1/experiments/converted')
+    expect((init as any).method).toBe('POST')
+    expect(JSON.parse((init as any).body)).toEqual({
+      experiment: 'upgrade_button',
+      variant: 'urgent',
+      action: 'checkout_started',
+    })
+  })
+
+  it('swallows network errors (analytics tail must not wag the conversion dog)', async () => {
+    const m = installFetch()
+    m.mockRejectedValueOnce(new Error('offline'))
+    // Must NOT throw. If it does, the test fails by surfacing the rejection.
+    await reportExperimentConverted({
+      experiment: 'upgrade_button',
+      variant: 'control',
+      action: 'checkout_started',
+    })
+  })
+
+  it('swallows 400 from a stale-variant rejection', async () => {
+    const m = installFetch()
+    m.mockResolvedValueOnce(jsonResponse(
+      { ok: false, error: 'variant_mismatch' },
+      { status: 400 },
+    ))
+    await reportExperimentConverted({
+      experiment: 'upgrade_button',
+      variant: 'control',
+      action: 'checkout_started',
+    })
+  })
+})

src/api/index.ts

@@ -143,7 +143,7 @@ async function call<T>(
 
 // ─── Auth / me ───────────────────────────────────────────────────────────
 // GET /auth/me on the agent API returns:
-//   { ok, user_id, team_id, email, tier, trial_ends_at }
+//   { ok, user_id, team_id, email, tier, trial_ends_at, experiments }
 // The dashboard expected { user, team } — we adapt here so the rest of
 // the dashboard still consumes the richer fixture shape.
 export async function fetchMe(): Promise<AuthMeResponse> {
@@ -154,6 +154,11 @@ export async function fetchMe(): Promise<AuthMeResponse> {
     email: string
     tier: string
     trial_ends_at: string | null
+    /** A/B-test bucket per registered experiment, e.g.
+     *  `{ upgrade_button: "urgent" }`. Older API builds omit this
+     *  field entirely — callers must treat undefined as "no
+     *  experiment, render control variant". */
+    experiments?: Record<string, string>
   }
   // No try/catch — errors propagate. The previous fixture fallback masked
   // backend outages by serving the `aanya@acme.dev` mock identity, which
@@ -184,6 +189,33 @@ export async function fetchMe(): Promise<AuthMeResponse> {
       tier: me.tier as any,
       created_at: '',
     },
+    experiments: me.experiments,
+  }
+}
+
+// ─── A/B-experiment conversion ───────────────────────────────────────────
+// reportExperimentConverted — fires POST /api/v1/experiments/converted to
+// record that the user took the conversion action on a server-bucketed
+// experiment (e.g. clicked the Upgrade button). Best-effort:
+//   - swallows every error (network down, 400 from a stale variant, etc.)
+//   - never blocks navigation; callers race it against a short timeout
+//     and proceed regardless.
+//
+// The matching server-side endpoint writes an audit_log row with
+// kind="experiment.conversion" and metadata={experiment, variant,
+// action_taken}. See api/internal/handlers/experiments.go.
+export async function reportExperimentConverted(input: {
+  experiment: string
+  variant: string
+  action: string
+}): Promise<void> {
+  try {
+    await call<{ ok: boolean }>('/api/v1/experiments/converted', {
+      method: 'POST',
+      body: JSON.stringify(input),
+    })
+  } catch {
+    /* analytics tail must not wag the conversion dog */
   }
 }
 

src/api/types.ts

@@ -231,20 +231,19 @@ export interface OverviewStats {
 }
 
 // ---------- Auth/me response (locked) ----------
+// `experiments` is the server-bucketed A/B map (keyed by experiment
+// name → variant). The dashboard reads this to render variant copy
+// and to know which variant to send back when firing the conversion
+// endpoint. Missing or {} means "no experiments running" — every
+// consumer treats absent variants as "control" so the field is
+// safe to omit on older API builds.
 //
-// `experiments` is an optional bag of A/B-test variants the agent API
-// attaches to the /auth/me response. The dashboard reads `upgrade_cta`
-// (set by track P1) to vary the upgrade button label across visitors.
-// Modelled as optional + permissive so the dashboard ships before the
-// API side lands without forcing a coordinated rollout.
+// Known keys today (track P1): "upgrade_button" → "control" | "urgent" | "value".
+// The variant→label/style mapping lives in src/components/UpgradeButton.tsx;
+// U2's UpgradePromptCard composes that component so it doesn't read variants directly.
 export interface AuthMeResponse {
   user: User
   team: DashboardTeam
   access_token?: string
-  experiments?: {
-    upgrade_cta?: {
-      variant?: string
-      label?: string
-    }
-  }
+  experiments?: Record<string, string>
 }