Skip to content

Commit 3147905

Browse files
ci(coverage): drop --depth=1 on the base fetch — fix diff-cover 'no merge base' (#51)
The patch-coverage gate did 'git fetch origin <base> --depth=1', truncating the base to one commit with no common ancestor with the PR branch whenever the branch was behind base — so diff-cover crashed with 'fatal: origin/<base>...HEAD: no merge base' and reded coverage on PRs that were merely stale (hit repeatedly). The checkout is already fetch-depth:0, so a plain 'git fetch origin <base>' resolves the merge-base reliably. Co-authored-by: Claude <noreply@anthropic.com>
1 parent 11475eb commit 3147905

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

.github/workflows/coverage.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,9 @@ jobs:
249249
if: github.event_name == 'pull_request'
250250
working-directory: provisioner
251251
run: |
252-
git fetch origin "${{ github.base_ref }}" --depth=1 || true
252+
# Full base history (NOT --depth=1): a shallow base fetch shares no merge-base
253+
# with a PR branch that is behind base → diff-cover "no merge base" crash.
254+
git fetch origin "${{ github.base_ref }}" || true
253255
diff-cover coverage.xml \
254256
--compare-branch="origin/${{ github.base_ref }}" \
255257
--fail-under=100

0 commit comments

Comments
 (0)