fix(bugbash 2026-05-21): wave-1 partial — Redis k8s sizingForTier yearly + plus tiers (#9)

Covers:
- E32 F1 [P1]: explicit cases for hobby_yearly, hobby_plus, hobby_plus_yearly, pro_yearly, team_yearly. Previously all fell through to default (hobby 50MB). pro_yearly now gets 512MB; team_yearly is unlimited.

Remaining P0/P1: Mongo authSource align (E33 F1), Neon token truncation + idempotency (E31 F1), storage_admin breaker (E31 F5), Mongo k8s hobby_plus case (E33 F2), Mongo localBackend UserAlreadyExists idempotency (E33 F5).

Co-authored-by: Manas Srivastava <[email protected]>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: mastermanas805

internal/backend/redis/k8s.go

@@ -176,7 +176,8 @@ func sizingForTier(tier string) tierSizing {
 			maxClients:  10,
 			maxmemoryMB: 5, // plans.yaml: anonymous redis_memory_mb = 5
 		}
-	case "hobby":
+	case "hobby", "hobby_yearly":
+		// hobby_yearly mirrors hobby (plans.yaml: identical limits, annual billing).
 		return tierSizing{
 			cpuReq: "100m", memReq: "128Mi",
 			cpuLim: "500m", memLim: "512Mi",
@@ -186,7 +187,24 @@ func sizingForTier(tier string) tierSizing {
 			maxClients:  50,
 			maxmemoryMB: 50, // plans.yaml: hobby redis_memory_mb = 50
 		}
-	case "pro":
+	case "hobby_plus", "hobby_plus_yearly":
+		// hobby_plus (W11 mid-tier insertion 2026-05-13). Redis memory cap
+		// matches hobby (50MB) per plans.yaml; the upsell over hobby is on
+		// postgres/mongo/storage, not redis. F1 fix (2026-05-21): explicit
+		// case so this tier no longer falls through to the default → hobby
+		// path, which by coincidence had the same maxmemoryMB but would
+		// silently drift the moment hobby_plus diverged from hobby.
+		return tierSizing{
+			cpuReq: "100m", memReq: "128Mi",
+			cpuLim: "500m", memLim: "512Mi",
+			pvcMi:        1024, // 1Gi (matches hobby)
+			qCPURequests: "200m", qMemRequests: "256Mi",
+			qCPULimits: "1", qMemLimits: "1Gi",
+			maxClients:  50,
+			maxmemoryMB: 50, // plans.yaml: hobby_plus redis_memory_mb = 50
+		}
+	case "pro", "pro_yearly":
+		// pro_yearly mirrors pro (plans.yaml: identical limits, annual billing).
 		return tierSizing{
 			cpuReq: "250m", memReq: "512Mi",
 			cpuLim: "2", memLim: "2Gi",
@@ -206,7 +224,8 @@ func sizingForTier(tier string) tierSizing {
 			maxClients:  1000,
 			maxmemoryMB: 1024, // plans.yaml: growth redis_memory_mb = 1024
 		}
-	case "team":
+	case "team", "team_yearly":
+		// team_yearly mirrors team (plans.yaml: identical -1 limits, annual billing).
 		return tierSizing{
 			cpuReq: "500m", memReq: "1Gi",
 			cpuLim: "4", memLim: "4Gi",

internal/backend/redis/k8s_test.go

@@ -60,8 +60,13 @@ func TestSizingForTier_MaxmemoryMB_MatchesPlansYAML(t *testing.T) {
 	}{
 		{"anonymous", 5, true},   // plans.yaml: anonymous redis_memory_mb = 5
 		{"hobby", 50, true},      // plans.yaml: hobby redis_memory_mb = 50
+		{"hobby_yearly", 50, true}, // plans.yaml: hobby_yearly mirrors hobby
+		{"hobby_plus", 50, true}, // plans.yaml: hobby_plus redis_memory_mb = 50
+		{"hobby_plus_yearly", 50, true}, // plans.yaml: hobby_plus_yearly mirrors hobby_plus
 		{"pro", 512, true},       // plans.yaml: pro redis_memory_mb = 512
+		{"pro_yearly", 512, true},// plans.yaml: pro_yearly mirrors pro
 		{"team", -1, false},      // unlimited — flag omitted
+		{"team_yearly", -1, false}, // plans.yaml: team_yearly mirrors team (unlimited)
 		{"growth", 1024, true},   // plans.yaml: growth redis_memory_mb = 1024
 		{"unknown", 50, true},    // unknown → hobby fallback
 	}
@@ -123,7 +128,7 @@ func TestSizingForTier_MaxmemoryFlag_InCommand(t *testing.T) {
 		return ""
 	}
 
-	limitedTiers := []string{"anonymous", "hobby", "pro", "growth"}
+	limitedTiers := []string{"anonymous", "hobby", "hobby_yearly", "hobby_plus", "hobby_plus_yearly", "pro", "pro_yearly", "growth"}
 	for _, tier := range limitedTiers {
 		t.Run("limited/"+tier, func(t *testing.T) {
 			sz := sizingForTier(tier)
@@ -142,7 +147,7 @@ func TestSizingForTier_MaxmemoryFlag_InCommand(t *testing.T) {
 		})
 	}
 
-	unlimitedTiers := []string{"team"}
+	unlimitedTiers := []string{"team", "team_yearly"}
 	for _, tier := range unlimitedTiers {
 		t.Run("unlimited/"+tier, func(t *testing.T) {
 			sz := sizingForTier(tier)