Commit 247ef49
docs(jobs): fix stale money-path + quota comments (terminate endpoint live, Team not unlimited) (#97)
Three agent-misleading comment inaccuracies in two job files. Comment-only —
zero behavior change; `go build ./internal/jobs/` + `go vet` clean.
payment_grace_terminator.go:
- Header said terminate "(b) downgrade tier to ANONYMOUS" — the api endpoint
downgrades to FREE (api internal_terminate.go:207, "anonymous would be
wrong"); a terminated team keeps its team_id so free is the correct floor.
- The TODO claimed the api side "is referenced by this dispatcher but NOT yet
implemented in the api repo — that side ships in a separate PR." It IS
implemented and live: api router.go:893 → internal_terminate.go::Terminate
(pause-resources + downgrade-to-free + mark-grace-terminated + audit-emit).
An agent reading the TODO would wrongly conclude dunning-termination is a
no-op. Rewritten to describe the live state.
quota_wall_nudge.go:
- Skip-rationale said "team tier is unlimited on every axis." False post the
strict-≥80%-margin redesign (2026-06-05) which retired all -1 limits — Team
now carries finite high-capacity caps. Skipping Team is still correct (it's
the top self-serve tier; the wall nudge is an UPGRADE banner with nothing
above to upsell), so this is a stale-reason fix, not a behavior change.
Verified the one local integration-test failure
(TestIntegration_BillingReconciler_SkipsTestCohort) reproduces IDENTICALLY on
clean origin/master without this diff — it is a pre-existing local-test-DB seed
flake unrelated to these comment edits (the authoritative gate is CI's seeded
postgres service).
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>1 parent eb427f4 commit 247ef49
2 files changed
Lines changed: 20 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
8 | 10 | | |
9 | 11 | | |
10 | 12 | | |
| |||
27 | 29 | | |
28 | 30 | | |
29 | 31 | | |
30 | | - | |
| 32 | + | |
31 | 33 | | |
32 | 34 | | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
38 | 44 | | |
39 | 45 | | |
40 | 46 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
17 | | - | |
18 | | - | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
19 | 23 | | |
20 | 24 | | |
21 | 25 | | |
| |||
0 commit comments