Skip to content

Commit ecd26c5

Browse files
ci(coverage): drop --depth=1 on the base fetch — fix diff-cover 'no merge base' (#99)
The patch-coverage gate did 'git fetch origin <base> --depth=1', truncating the base to one commit with no common ancestor with the PR branch whenever the branch was behind base — so diff-cover crashed with 'fatal: origin/<base>...HEAD: no merge base' and reded coverage on PRs that were merely stale (hit repeatedly). The checkout is already fetch-depth:0, so a plain 'git fetch origin <base>' resolves the merge-base reliably. Co-authored-by: Claude <noreply@anthropic.com>
1 parent 8bcc320 commit ecd26c5

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

.github/workflows/coverage.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,9 @@ jobs:
183183
if: github.event_name == 'pull_request'
184184
working-directory: worker
185185
run: |
186-
git fetch origin "${{ github.base_ref }}" --depth=1 || true
186+
# Full base history (NOT --depth=1): a shallow base fetch shares no merge-base
187+
# with a PR branch that is behind base → diff-cover "no merge base" crash.
188+
git fetch origin "${{ github.base_ref }}" || true
187189
diff-cover coverage.xml \
188190
--compare-branch="origin/${{ github.base_ref }}" \
189191
--fail-under=100

0 commit comments

Comments
 (0)