refactor: remove excess api calls (group selector)

Author: semrosin

hwproj.front/src/components/Common/GroupSelector.tsx

@@ -1,4 +1,4 @@
-import {FC, useEffect, useMemo, useState} from "react";
+import {FC, useMemo, useState} from "react";
 import {
     Grid,
     TextField,
@@ -23,6 +23,7 @@ import { Group, AccountDataDto } from "@/api";
 interface GroupSelectorProps {
     courseId: number,
     courseStudents: AccountDataDto[],
+    groups: Group[],
     onGroupIdChange: (groupId?: number) => void,
     onGroupsUpdate: () => void,
     selectedGroupId?: number,
@@ -31,8 +32,7 @@ interface GroupSelectorProps {
 }
 
 const GroupSelector:  FC<GroupSelectorProps> = (props) => {
-    const [groups, setGroups] = useState<Group[]>([]);
-    const [groupsLoading, setGroupsLoading] = useState(false);
+    const groups = props.groups || [];
     const [isDialogOpen, setIsDialogOpen] = useState(false);
     const [formState, setFormState] = useState<{
         name: string,
@@ -44,22 +44,6 @@ const GroupSelector:  FC<GroupSelectorProps> = (props) => {
     const [isSubmitting, setIsSubmitting] = useState(false);
     const [isError, setIsError] = useState(false);
 
-    const loadGroups = async () => {
-        setGroupsLoading(true)
-        try {
-            const courseGroups = await ApiSingleton.courseGroupsApi.courseGroupsGetAllCourseGroupsWithNames(props.courseId);
-            setGroups(courseGroups);
-        } catch (error) {
-            console.error('Failed to load groups:', error);
-            setIsError(true);
-        } finally {
-            setGroupsLoading(false);
-        }
-    }
-    useEffect(() => {
-        loadGroups();
-    }, [props.courseId]);
-
     const handleOpenEditDialog = () => {
         const selectedGroup = groups.find(g => g.id === props.selectedGroupId);
         setFormState({
@@ -89,7 +73,6 @@ const GroupSelector:  FC<GroupSelectorProps> = (props) => {
                         groupMates: formState.memberIds.map(studentId => ({ studentId })),
                     }
                 );
-                await loadGroups();
                 props.onGroupsUpdate();
             } else {
                 if (!formState.name.trim() || formState.memberIds.length === 0) {
@@ -101,7 +84,6 @@ const GroupSelector:  FC<GroupSelectorProps> = (props) => {
                     groupMatesIds: formState.memberIds,
                     courseId: props.courseId,
                 });
-                await loadGroups();
                 props.onGroupsUpdate();
                 props.onGroupIdChange(groupId);
             }
@@ -154,7 +136,6 @@ const GroupSelector:  FC<GroupSelectorProps> = (props) => {
                         onChange={(_, newGroup) => {
                             props.onGroupIdChange(newGroup?.id)
                         }}
-                        loading={groupsLoading}
                         renderInput={(params) => (
                             <TextField
                                 {...params}

hwproj.front/src/components/Courses/Course.tsx

@@ -406,6 +406,7 @@ const Course: React.FC = () => {
                             }))
                         }}
                         onGroupsUpdate={loadGroups}
+                        groups={groups}
                     />
                     }
                     {tabValue === "stats" &&

hwproj.front/src/components/Courses/CourseExperimental.tsx

@@ -1,6 +1,7 @@
 import * as React from "react";
 import {
     FileInfoDTO,
+    Group,
     HomeworkTaskViewModel,
     HomeworkViewModel, SolutionDto, StatisticsCourseMatesModel,
 } from "@/api";
@@ -61,6 +62,7 @@ interface ICourseExperimentalProps {
                         waitingNewFilesCount: number,
                         deletingFilesIds: number[]) => void;
     onGroupsUpdate: () => void;
+    groups: Group[];
 }
 
 interface ICourseExperimentalState {
@@ -442,6 +444,7 @@ export const CourseExperimental: FC<ICourseExperimentalProps> = (props) => {
                     isProcessing={props.processingFiles[homework.id!]?.isLoading || false}
                     onStartProcessing={props.onStartProcessing}
                     onGroupsUpdate={props.onGroupsUpdate}
+                    groups={props.groups}
                 />
             </Card>
         </Stack>

hwproj.front/src/components/Homeworks/CourseHomeworkExperimental.tsx

@@ -18,7 +18,8 @@ import {IFileInfo} from "components/Files/IFileInfo";
 import {FC, useEffect, useState} from "react"
 import Utils from "services/Utils";
 import {
-    HomeworkViewModel, ActionOptions, HomeworkTaskViewModel, PostTaskViewModel, AccountDataDto
+    HomeworkViewModel, ActionOptions, HomeworkTaskViewModel, PostTaskViewModel, AccountDataDto,
+    Group
 } from "@/api";
 import ApiSingleton from "../../api/ApiSingleton";
 import Tags from "../Common/Tags";
@@ -65,6 +66,7 @@ const CourseHomeworkEditor: FC<{
                         waitingNewFilesCount: number,
                         deletingFilesIds: number[]) => void;
     onGroupsUpdate: () => void;
+    groups: Group[];
 }> = (props) => {
     const homework = props.homeworkAndFilesInfo.homework
     const isNewHomework = homework.id! < 0
@@ -312,6 +314,7 @@ const CourseHomeworkEditor: FC<{
                     selectedGroupId={selectedGroupId}
                     choiceDisabled={!isNewHomework}
                     onGroupsUpdate={props.onGroupsUpdate}
+                    groups={props.groups}
                 />
                 {tags.includes(TestTag) &&
                     <Grid item>
@@ -421,6 +424,7 @@ const CourseHomeworkExperimental: FC<{
                         waitingNewFilesCount: number,
                         deletingFilesIds: number[]) => void;
     onGroupsUpdate: () => void;
+    groups: Group[];
 }> = (props) => {
     const {homework, filesInfo} = props.homeworkAndFilesInfo
     const deferredTasks = homework.tasks!.filter(t => t.isDeferred!)
@@ -442,6 +446,7 @@ const CourseHomeworkExperimental: FC<{
         }}
         onStartProcessing={props.onStartProcessing}
         onGroupsUpdate={props.onGroupsUpdate}
+        groups={props.groups}
     />
 
     return <CardContent