refactor

Author: semrosin

HwProj.CoursesService/HwProj.CoursesService.API/Services/CourseFilterService.cs

@@ -140,22 +140,21 @@ public async Task<MentorToAssignedStudentsDTO[]> GetAssignedStudentsIds(long cou
                 .Distinct()
                 .ToArray();
 
-            var groupToStudents = groupIds.Any()
-                ? (await _groupsService.GetGroupsAsync(groupIds))
-                    .ToDictionary(
-                        g => g.Id,
-                        g => g.GroupMates?.Select(gm => gm.StudentId).ToArray() ?? Array.Empty<string>()
-                    )
-                : new Dictionary<long, string[]>();
+            var groups = await _groupsService.GetGroupsAsync(groupIds);
+            var groupToStudentIds = groups
+                .ToDictionary(
+                    g => g.Id,
+                    g => g.GroupMates?.Select(gm => gm.StudentId).ToArray() ?? Array.Empty<string>()
+                );
 
             var result = usersCourseFilters
                 .Select(u =>
                 {
                     var directStudents = u.CourseFilter.Filter.StudentIds ?? new List<string>() {};
                     var groupIdsForMentor = u.CourseFilter.Filter.GroupIds ?? Enumerable.Empty<long>();
                     var studentsFromGroups = groupIdsForMentor
-                        .Where(gid => groupToStudents.ContainsKey(gid))
-                        .SelectMany(gid => groupToStudents[gid])
+                        .Where(gid => groupToStudentIds.ContainsKey(gid))
+                        .SelectMany(gid => groupToStudentIds[gid])
                         .Distinct()
                         .ToList();
 

hwproj.front/src/components/Courses/Course.tsx

@@ -158,7 +158,7 @@ const Course: React.FC = () => {
 
     useEffect(() => {
         setCurrentState()
-    }, [courseId])
+    }, [])
 
     useEffect(() => {
         ApiSingleton.statisticsApi.statisticsGetCourseStatistics(+courseId!)