Skip Win32 MCP tests on non-Windows; trim lazy __all__ to clear pylint E0603

Author: JE-Chen

je_auto_control/gui/flow_editor/__init__.py

@@ -4,15 +4,14 @@
 the same :class:`Step` model + JSON action schema, so a script
 authored in one view loads cleanly in the other.
 
-Public surface::
-
-    from je_auto_control.gui.flow_editor import (
-        FlowEditorTab, FlowGraphScene, layout_steps,
-    )
-
-The ``layout`` module is Qt-free and eager so headless tests can import
-it without instantiating PySide6. ``scene`` and ``tab`` are loaded
-lazily via :func:`__getattr__` because they pull in Qt.
+The ``layout`` module is Qt-free and eager so headless tests can
+import it without instantiating PySide6. The Qt-dependent names
+(``FlowGraphScene``, ``FlowEditorTab`` …) load lazily via
+:func:`__getattr__`; they are intentionally absent from ``__all__``
+because Pylint's E0603 refuses to certify names that ``import *`` can
+not resolve at module-load time. ``from je_auto_control.gui.flow_editor
+import FlowEditorTab`` still works — Python falls through to
+``__getattr__`` when the attribute is not pre-bound.
 """
 from je_auto_control.gui.flow_editor.layout import (
     FlowEdge, FlowLayout, FlowNodePosition, layout_steps,
@@ -27,14 +26,16 @@
 
 
 def __getattr__(name):
-    if name in _LAZY_SUBMODULES:
-        import importlib
-        module = importlib.import_module(_LAZY_SUBMODULES[name])
-        return getattr(module, name)
-    raise AttributeError(f"module {__name__!r} has no attribute {name!r}")
+    target = _LAZY_SUBMODULES.get(name)
+    if target is None:
+        raise AttributeError(f"module {__name__!r} has no attribute {name!r}")
+    import importlib
+    # Argument is looked up from a hard-coded dict above, never user
+    # input — safe to import dynamically.
+    module = importlib.import_module(target)  # nosemgrep
+    return getattr(module, name)
 
 
 __all__ = [
-    "FlowEdge", "FlowEditorTab", "FlowEdgeItem", "FlowGraphScene",
-    "FlowLayout", "FlowNodeItem", "FlowNodePosition", "layout_steps",
+    "FlowEdge", "FlowLayout", "FlowNodePosition", "layout_steps",
 ]

je_auto_control/gui/script_builder/__init__.py

@@ -5,6 +5,11 @@
 and can be imported directly from headless tests::
 
     from je_auto_control.gui.script_builder.step_model import Step
+
+``__all__`` is empty on purpose: Pylint's E0603 refuses to certify
+``ScriptBuilderTab`` because it is not bound at module-load time.
+Callers reach the tab via attribute access, which falls through to
+:func:`__getattr__` and loads the Qt submodule on demand.
 """
 
 
@@ -18,4 +23,4 @@ def __getattr__(name):
     raise AttributeError(f"module {__name__!r} has no attribute {name!r}")
 
 
-__all__ = ["ScriptBuilderTab"]
+__all__: list[str] = []

test/unit_test/headless/test_mcp_server.py

@@ -8,9 +8,12 @@
 import json
 import math
 import os
+import sys
 import threading
 from typing import Any, Dict, List
 
+import pytest
+
 from je_auto_control.utils.mcp_server.context import (
     OperationCancelledError, ToolCallContext,
 )
@@ -1343,6 +1346,10 @@ def test_window_geometry_tools_present_in_default_registry():
             "ac_window_maximize", "ac_window_restore"}.issubset(names)
 
 
+@pytest.mark.skipif(
+    sys.platform not in ("win32", "cygwin", "msys"),
+    reason="windows_window_manage uses ctypes.WINFUNCTYPE; Win32-only.",
+)
 def test_window_move_calls_into_windows_manager(monkeypatch):
     import je_auto_control.utils.mcp_server.tools._handlers as handlers
     import je_auto_control.wrapper.auto_control_window as window_module
@@ -1368,6 +1375,10 @@ def fake_move(hwnd, x, y, width, height, repaint=True):
                        "width": 800, "height": 600}
 
 
+@pytest.mark.skipif(
+    sys.platform not in ("win32", "cygwin", "msys"),
+    reason="windows_window_manage uses ctypes.WINFUNCTYPE; Win32-only.",
+)
 def test_window_minimize_uses_show_command_six(monkeypatch):
     """ShowWindow flag 6 is SW_MINIMIZE."""
     import je_auto_control.wrapper.auto_control_window as window_module