Quiet lint noise on dispatcher and CLI-shaped signatures

The MCP stdio dispatcher intentionally catches Exception so a single bad
tool call never aborts the loop; flags W0212 by going through a module-level
generator instead of touching registry internals. SMBClient and FileLock
get narrow pylint disables where a flat kwargs constructor and a single
long-lived file handle are the point.

Author: JE-Chen

automation_file/core/file_lock.py

@@ -50,6 +50,7 @@ def acquire(self) -> None:
             if self._owned:
                 raise LockTimeoutException(f"lock {self._path} already held by this instance")
             self._path.parent.mkdir(parents=True, exist_ok=True)
+            # pylint: disable=consider-using-with
             fh = open(self._path, "a+b")  # noqa: SIM115 — held across acquire/release
             try:
                 self._acquire_os_lock(fh)

automation_file/remote/smb/client.py

@@ -43,7 +43,7 @@ def _import_smbclient() -> Any:
 class SMBClient:
     """Minimal SMB client scoped to the operations used by this project."""
 
-    def __init__(
+    def __init__(  # pylint: disable=too-many-arguments,too-many-positional-arguments
         self,
         server: str,
         share: str,

automation_file/server/mcp_server.py

@@ -88,7 +88,7 @@ def handle_message(self, message: dict[str, Any]) -> dict[str, Any] | None:
                 return _error_response(msg_id, _METHOD_NOT_FOUND, f"unknown method: {method}")
         except MCPServerException as error:
             return _error_response(msg_id, _INVALID_PARAMS, str(error))
-        except Exception as error:
+        except Exception as error:  # pylint: disable=broad-exception-caught
             file_automation_logger.warning("mcp_server: internal error: %r", error)
             return _error_response(msg_id, _INTERNAL_ERROR, f"{type(error).__name__}: {error}")
 
@@ -125,16 +125,7 @@ def _handle_initialize(self, _params: dict[str, Any]) -> dict[str, Any]:
         }
 
     def _handle_tools_list(self) -> dict[str, Any]:
-        tools = []
-        for name, command in sorted(self._registry.event_dict.items()):
-            tools.append(
-                {
-                    "name": name,
-                    "description": _describe(command),
-                    "inputSchema": _schema_for(command),
-                }
-            )
-        return {"tools": tools}
+        return {"tools": list(_catalogue(self._registry))}
 
     def _handle_tools_call(self, params: dict[str, Any]) -> dict[str, Any]:
         name = params.get("name")
@@ -231,8 +222,16 @@ def tools_from_registry(registry: ActionRegistry) -> Iterable[dict[str, Any]]:
     Exposed separately so GUIs and tests can render the same catalogue
     without instantiating :class:`MCPServer`.
     """
-    server = MCPServer(registry)
-    yield from server._handle_tools_list()["tools"]
+    yield from _catalogue(registry)
+
+
+def _catalogue(registry: ActionRegistry) -> Iterable[dict[str, Any]]:
+    for name, command in sorted(registry.event_dict.items()):
+        yield {
+            "name": name,
+            "description": _describe(command),
+            "inputSchema": _schema_for(command),
+        }
 
 
 def _filtered_registry(source: ActionRegistry, allowed: Sequence[str]) -> ActionRegistry: