Conversation
The post-merge SonarCloud run on main kept flagging the write_text() call in _replace_selected_result (BLOCKER S2083) even though the previous version resolved the path and checked containment against project_root — the taint analyzer doesn't treat `parents`-based containment as sanitization. Rebuild the target path from the trusted project_root plus a validated relative component (Path.relative_to raises ValueError when outside the root), so user-controlled data never flows straight into write_text(). Same visible behaviour, recognised by Sonar as a safe construction.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_replace_selected_resultfrom trusted components so SonarCloud's taint analyzer recognises the sanitization (BLOCKER S2083 onsearch_replace_widget.py:508, re-flagged on main after PR Merge dev into main: CLAUDE.md, SonarCloud/Codacy compliance #224 merged).Test plan
py -m pytest test/ --ignore=test/qt_ui— 77 passedpy -m ruff check je_editor— clean