Tcheck: treat trivially false range checks as errors#151
Merged
Conversation
This makes expressions like '0b1[3:0]' or '3 / 0' into typechecking errors instead of just runtime errors. Note that the checks are only performed if you use --runtime-errors
nikolaykosarev
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tcheck: treat trivially false range checks as errors
This makes expressions like '0b1[3:0]' or '3 / 0' into typechecking errors instead of just runtime errors.
Note that this only applies when
Expressions only involve literal constants.
e.g. 'x > x+1' or '0 <= x && x < 0' will be checked at runtime.
Assertions that are automatically inserted by the compiler
to check for errors like
go outside the bounds of the bitvector
Runtime error checks are enabled (using --runtime-errors)
So this does not guarantee to detect all errors.
In fact, it will miss quite a lot of possible errors.
But it will catch completely silly errors and, in particular, it will catch errors resulting from the forthcoming change to treat hex numbers as bitvectors that has resulted in a lot of expressions of the form "0x1[31:0]" creating latent runtime errors.