Skip to content

Commit 66e3e75

Browse files
committed
dpctl/tests/AGENTS.md: remove elementwise references (tensor migration)
Remove all references to tests/elementwise/utils.py and dpt.tensor usage as tests/elementwise will be removed as part of the tensor migration. Addressed review comments from ndgrigorian.
1 parent 09b2dc0 commit 66e3e75

File tree

1 file changed

+8
-14
lines changed

1 file changed

+8
-14
lines changed

dpctl/tests/AGENTS.md

Lines changed: 8 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ pytest-based test suite for dpctl functionality.
1010
|------|---------|
1111
| `conftest.py` | Fixtures and pytest configuration |
1212
| `helper/_helper.py` | `get_queue_or_skip()`, `skip_if_dtype_not_supported()` |
13-
| `elementwise/utils.py` | Dtype and USM type lists for parametrization |
1413

1514
## Essential Helpers
1615

@@ -20,29 +19,24 @@ get_queue_or_skip() # Create queue or skip test
2019
skip_if_dtype_not_supported() # Skip if device lacks dtype (fp64/fp16)
2120
```
2221

23-
## Dtype/USM Lists
24-
25-
**Do not hardcode** - import from `elementwise/utils.py`:
26-
```python
27-
from .utils import _all_dtypes, _usm_types, _no_complex_dtypes
28-
```
29-
3022
## Test Pattern
3123

3224
```python
33-
@pytest.mark.parametrize("dtype", _all_dtypes)
25+
@pytest.mark.parametrize("dtype", ["f2", "f4", "f8", "c8", "c16", ...])
3426
def test_operation(dtype):
3527
q = get_queue_or_skip()
3628
skip_if_dtype_not_supported(dtype, q)
37-
38-
x = dpt.ones(100, dtype=dtype, sycl_queue=q)
39-
result = dpt.operation(x)
40-
# ... assertions
29+
# ... test logic and assertions
4130
```
4231

4332
## Coverage Requirements
4433

45-
- All supported dtypes (see `elementwise/utils.py`)
34+
- All supported dtypes
4635
- All USM types: device, shared, host
4736
- Memory orders: C, F where applicable
4837
- Edge cases: empty arrays, 0-d arrays (scalars), broadcasting
38+
39+
## Critical Rules
40+
41+
1. **Device compatibility:** Not all devices support fp64/fp16 - never assume availability
42+
2. **Queue consistency:** Arrays in same operation must share compatible queues

0 commit comments

Comments
 (0)