Skip to content

Commit 1e8068c

Browse files
committed
Use std namespace explicitly
1 parent 673d395 commit 1e8068c

File tree

4 files changed

+78
-74
lines changed

4 files changed

+78
-74
lines changed

dpnp/backend/extensions/statistics/histogram_common.hpp

Lines changed: 41 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -74,18 +74,18 @@ struct CachedData
7474
template <int _Dims>
7575
void init(const sycl::nd_item<_Dims> &item) const
7676
{
77-
uint32_t llid = item.get_local_linear_id();
77+
std::uint32_t llid = item.get_local_linear_id();
7878
auto local_ptr = &local_data[0];
79-
uint32_t size = local_data.size();
79+
std::uint32_t size = local_data.size();
8080
auto group = item.get_group();
81-
uint32_t local_size = group.get_local_linear_range();
81+
std::uint32_t local_size = group.get_local_linear_range();
8282

83-
for (uint32_t i = llid; i < size; i += local_size) {
83+
for (std::uint32_t i = llid; i < size; i += local_size) {
8484
local_ptr[i] = global_data[i];
8585
}
8686
}
8787

88-
size_t size() const
88+
std::size_t size() const
8989
{
9090
return local_data.size();
9191
}
@@ -96,7 +96,7 @@ struct CachedData
9696
}
9797

9898
template <typename = std::enable_if_t<Dims == 1>>
99-
T &operator[](const size_t id) const
99+
T &operator[](const std::size_t id) const
100100
{
101101
return local_data[id];
102102
}
@@ -131,7 +131,7 @@ struct UncachedData
131131
{
132132
}
133133

134-
size_t size() const
134+
std::size_t size() const
135135
{
136136
return _shape.size();
137137
}
@@ -142,7 +142,7 @@ struct UncachedData
142142
}
143143

144144
template <typename = std::enable_if_t<Dims == 1>>
145-
T &operator[](const size_t id) const
145+
T &operator[](const std::size_t id) const
146146
{
147147
return global_data[id];
148148
}
@@ -159,15 +159,15 @@ struct HistLocalType
159159
};
160160

161161
template <>
162-
struct HistLocalType<uint64_t>
162+
struct HistLocalType<std::uint64_t>
163163
{
164-
using type = uint32_t;
164+
using type = std::uint32_t;
165165
};
166166

167167
template <>
168-
struct HistLocalType<int64_t>
168+
struct HistLocalType<std::int64_t>
169169
{
170-
using type = int32_t;
170+
using type = std::int32_t;
171171
};
172172

173173
template <typename T, typename localT = typename HistLocalType<T>::type>
@@ -179,8 +179,8 @@ struct HistWithLocalCopies
179179
using LocalHist = sycl::local_accessor<localT, 2>;
180180

181181
HistWithLocalCopies(T *global_data,
182-
size_t bins_count,
183-
int32_t copies_count,
182+
std::size_t bins_count,
183+
std::int32_t copies_count,
184184
sycl::handler &cgh)
185185
{
186186
local_hist = LocalHist(sycl::range<2>(copies_count, bins_count), cgh);
@@ -190,23 +190,25 @@ struct HistWithLocalCopies
190190
template <int _Dims>
191191
void init(const sycl::nd_item<_Dims> &item, localT val = 0) const
192192
{
193-
uint32_t llid = item.get_local_linear_id();
193+
std::uint32_t llid = item.get_local_linear_id();
194194
auto *local_ptr = &local_hist[0][0];
195-
uint32_t size = local_hist.size();
195+
std::uint32_t size = local_hist.size();
196196
auto group = item.get_group();
197-
uint32_t local_size = group.get_local_linear_range();
197+
std::uint32_t local_size = group.get_local_linear_range();
198198

199-
for (uint32_t i = llid; i < size; i += local_size) {
199+
for (std::uint32_t i = llid; i < size; i += local_size) {
200200
local_ptr[i] = val;
201201
}
202202
}
203203

204204
template <int _Dims>
205-
void add(const sycl::nd_item<_Dims> &item, int32_t bin, localT value) const
205+
void add(const sycl::nd_item<_Dims> &item,
206+
std::int32_t bin,
207+
localT value) const
206208
{
207-
int32_t llid = item.get_local_linear_id();
208-
int32_t local_hist_count = local_hist.get_range().get(0);
209-
int32_t local_copy_id =
209+
std::int32_t llid = item.get_local_linear_id();
210+
std::int32_t local_hist_count = local_hist.get_range().get(0);
211+
std::int32_t local_copy_id =
210212
local_hist_count == 1 ? 0 : llid % local_hist_count;
211213

212214
AtomicOp<localT, sycl::memory_order::relaxed,
@@ -218,15 +220,15 @@ struct HistWithLocalCopies
218220
template <int _Dims>
219221
void finalize(const sycl::nd_item<_Dims> &item) const
220222
{
221-
uint32_t llid = item.get_local_linear_id();
222-
uint32_t bins_count = local_hist.get_range().get(1);
223-
uint32_t local_hist_count = local_hist.get_range().get(0);
223+
std::uint32_t llid = item.get_local_linear_id();
224+
std::uint32_t bins_count = local_hist.get_range().get(1);
225+
std::uint32_t local_hist_count = local_hist.get_range().get(0);
224226
auto group = item.get_group();
225-
uint32_t local_size = group.get_local_linear_range();
227+
std::uint32_t local_size = group.get_local_linear_range();
226228

227-
for (uint32_t i = llid; i < bins_count; i += local_size) {
229+
for (std::uint32_t i = llid; i < bins_count; i += local_size) {
228230
auto value = local_hist[0][i];
229-
for (uint32_t lhc = 1; lhc < local_hist_count; ++lhc) {
231+
for (std::uint32_t lhc = 1; lhc < local_hist_count; ++lhc) {
230232
value += local_hist[lhc][i];
231233
}
232234
if (value != T(0)) {
@@ -237,7 +239,7 @@ struct HistWithLocalCopies
237239
}
238240
}
239241

240-
uint32_t size() const
242+
std::uint32_t size() const
241243
{
242244
return local_hist.size();
243245
}
@@ -264,7 +266,7 @@ struct HistGlobalMemory
264266
}
265267

266268
template <int _Dims>
267-
void add(const sycl::nd_item<_Dims> &, int32_t bin, T value) const
269+
void add(const sycl::nd_item<_Dims> &, std::int32_t bin, T value) const
268270
{
269271
AtomicOp<T, sycl::memory_order::relaxed,
270272
sycl::memory_scope::device>::add(global_hist[bin], value);
@@ -279,10 +281,10 @@ struct HistGlobalMemory
279281
T *global_hist = nullptr;
280282
};
281283

282-
template <typename T = uint32_t>
284+
template <typename T = std::uint32_t>
283285
struct NoWeights
284286
{
285-
constexpr T get(size_t) const
287+
constexpr T get(std::size_t) const
286288
{
287289
return 1;
288290
}
@@ -296,7 +298,7 @@ struct Weights
296298
data = weights;
297299
}
298300

299-
T get(size_t id) const
301+
T get(std::size_t id) const
300302
{
301303
return data[id];
302304
}
@@ -314,9 +316,9 @@ bool check_in_bounds(const dT &val, const dT &min, const dT &max)
314316

315317
template <typename T, typename HistImpl, typename Edges, typename Weights>
316318
void submit_histogram(const T *in,
317-
const size_t size,
318-
const size_t dims,
319-
const uint32_t WorkPI,
319+
const std::size_t size,
320+
const std::size_t dims,
321+
const std::uint32_t WorkPI,
320322
const HistImpl &hist,
321323
const Edges &edges,
322324
const Weights &weights,
@@ -336,8 +338,8 @@ void validate(const usm_ndarray &sample,
336338
const std::optional<const dpctl::tensor::usm_ndarray> &weights,
337339
const usm_ndarray &histogram);
338340

339-
uint32_t get_local_hist_copies_count(uint32_t loc_mem_size_in_items,
340-
uint32_t local_size,
341-
uint32_t hist_size_in_items);
341+
std::uint32_t get_local_hist_copies_count(std::uint32_t loc_mem_size_in_items,
342+
std::uint32_t local_size,
343+
std::uint32_t hist_size_in_items);
342344

343345
} // namespace statistics::histogram

dpnp/backend/extensions/statistics/sliding_window1d.hpp

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ namespace statistics::sliding_window1d
4242
{
4343
using dpctl::tensor::usm_ndarray;
4444

45-
template <typename T, uint32_t Size>
45+
template <typename T, std::uint32_t Size>
4646
class _RegistryDataStorage
4747
{
4848
public:
@@ -155,7 +155,7 @@ class _RegistryDataStorage
155155
ncT data[Size];
156156
};
157157

158-
template <typename T, uint32_t Size = 1>
158+
template <typename T, std::uint32_t Size = 1>
159159
struct RegistryData : public _RegistryDataStorage<T, Size>
160160
{
161161
using SizeT = typename _RegistryDataStorage<T, Size>::SizeT;
@@ -351,7 +351,7 @@ struct RegistryData : public _RegistryDataStorage<T, Size>
351351
}
352352
};
353353

354-
template <typename T, uint32_t Size>
354+
template <typename T, std::uint32_t Size>
355355
struct RegistryWindow : public RegistryData<T, Size>
356356
{
357357
using SizeT = typename RegistryData<T, Size>::SizeT;
@@ -364,7 +364,7 @@ struct RegistryWindow : public RegistryData<T, Size>
364364
static_assert(std::is_integral_v<shT>,
365365
"shift must be of an integral type");
366366

367-
uint32_t shift_r = this->size_x() - shift;
367+
std::uint32_t shift_r = this->size_x() - shift;
368368
for (SizeT i = 0; i < Size; ++i) {
369369
this->data[i] = this->shift_left(i, shift);
370370
auto border =
@@ -387,7 +387,7 @@ struct RegistryWindow : public RegistryData<T, Size>
387387
}
388388
};
389389

390-
template <typename T, typename SizeT = size_t>
390+
template <typename T, typename SizeT = std::size_t>
391391
class Span
392392
{
393393
public:
@@ -421,13 +421,13 @@ class Span
421421
const SizeT size_;
422422
};
423423

424-
template <typename T, typename SizeT = size_t>
424+
template <typename T, typename SizeT = std::size_t>
425425
Span<T, SizeT> make_span(T *const data, const SizeT size)
426426
{
427427
return Span<T, SizeT>(data, size);
428428
}
429429

430-
template <typename T, typename SizeT = size_t>
430+
template <typename T, typename SizeT = std::size_t>
431431
class PaddedSpan : public Span<T, SizeT>
432432
{
433433
public:
@@ -453,14 +453,14 @@ class PaddedSpan : public Span<T, SizeT>
453453
const SizeT pad_;
454454
};
455455

456-
template <typename T, typename SizeT = size_t>
456+
template <typename T, typename SizeT = std::size_t>
457457
PaddedSpan<T, SizeT>
458458
make_padded_span(T *const data, const SizeT size, const SizeT offset)
459459
{
460460
return PaddedSpan<T, SizeT>(data, size, offset);
461461
}
462462

463-
template <uint32_t WorkPI,
463+
template <std::uint32_t WorkPI,
464464
typename T,
465465
typename SizeT,
466466
typename Op,
@@ -482,7 +482,7 @@ void submit_sliding_window1d(const PaddedSpan<const T, SizeT> &a,
482482
nd_range, SlidingWindow1dKernel(a, v, op, red, out));
483483
}
484484

485-
template <uint32_t WorkPI,
485+
template <std::uint32_t WorkPI,
486486
typename T,
487487
typename SizeT,
488488
typename Op,
@@ -507,6 +507,6 @@ void submit_sliding_window1d_small_kernel(const PaddedSpan<const T, SizeT> &a,
507507
void validate(const usm_ndarray &a,
508508
const usm_ndarray &v,
509509
const usm_ndarray &out,
510-
const size_t l_pad,
511-
const size_t r_pad);
510+
const std::size_t l_pad,
511+
const std::size_t r_pad);
512512
} // namespace statistics::sliding_window1d

dpnp/backend/kernels/statistics/histogram.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ class HistogramFunctor
7676

7777
auto bounds = edges.get_bounds();
7878

79-
for (uint32_t i = 0; i < WorkPI; ++i) {
79+
for (std::uint32_t i = 0; i < WorkPI; ++i) {
8080
auto data_idx = id * WorkPI * local_size + i * local_size + lid;
8181
if (data_idx < size) {
8282
auto *d = &in[data_idx * dims];

0 commit comments

Comments
 (0)