Apply remarks

vlad-perevezentsev · vlad-perevezentsev · commit 281adbf6bf7d · 2026-03-11T05:42:21.000-07:00
diff --git a/dpctl_ext/tensor/libtensor/include/kernels/elementwise_functions/abs.hpp b/dpctl_ext/tensor/libtensor/include/kernels/elementwise_functions/abs.hpp
@@ -47,7 +47,6 @@
 #include "kernels/dpctl_tensor_types.hpp"
 #include "kernels/elementwise_functions/common.hpp"
 
-#include "utils/offset_utils.hpp"
 #include "utils/type_dispatch_building.hpp"
 #include "utils/type_utils.hpp"
 
diff --git a/dpctl_ext/tensor/libtensor/include/kernels/elementwise_functions/acos.hpp b/dpctl_ext/tensor/libtensor/include/kernels/elementwise_functions/acos.hpp
@@ -47,7 +47,6 @@
 #include "kernels/dpctl_tensor_types.hpp"
 #include "kernels/elementwise_functions/common.hpp"
 
-#include "utils/offset_utils.hpp"
 #include "utils/type_dispatch_building.hpp"
 #include "utils/type_utils.hpp"
 
diff --git a/dpctl_ext/tensor/libtensor/include/kernels/elementwise_functions/acosh.hpp b/dpctl_ext/tensor/libtensor/include/kernels/elementwise_functions/acosh.hpp
@@ -49,7 +49,6 @@
 #include "kernels/dpctl_tensor_types.hpp"
 #include "kernels/elementwise_functions/common.hpp"
 
-#include "utils/offset_utils.hpp"
 #include "utils/type_dispatch_building.hpp"
 #include "utils/type_utils.hpp"
 
diff --git a/dpctl_ext/tensor/libtensor/include/kernels/elementwise_functions/angle.hpp b/dpctl_ext/tensor/libtensor/include/kernels/elementwise_functions/angle.hpp
@@ -32,7 +32,6 @@
 /// This file defines kernels for elementwise evaluation of ANGLE(x) function.
 //===---------------------------------------------------------------------===//
 
-#include <cmath>
 #include <complex>
 #include <cstddef>
 #include <cstdint>
@@ -47,7 +46,6 @@
 #include "kernels/dpctl_tensor_types.hpp"
 #include "kernels/elementwise_functions/common.hpp"
 
-#include "utils/offset_utils.hpp"
 #include "utils/type_dispatch_building.hpp"
 #include "utils/type_utils.hpp"
 
diff --git a/dpctl_ext/tensor/libtensor/include/kernels/elementwise_functions/asin.hpp b/dpctl_ext/tensor/libtensor/include/kernels/elementwise_functions/asin.hpp
@@ -49,7 +49,6 @@
 #include "kernels/dpctl_tensor_types.hpp"
 #include "kernels/elementwise_functions/common.hpp"
 
-#include "utils/offset_utils.hpp"
 #include "utils/type_dispatch_building.hpp"
 #include "utils/type_utils.hpp"
 
diff --git a/dpctl_ext/tensor/libtensor/include/kernels/elementwise_functions/asinh.hpp b/dpctl_ext/tensor/libtensor/include/kernels/elementwise_functions/asinh.hpp
@@ -49,7 +49,6 @@
 #include "kernels/dpctl_tensor_types.hpp"
 #include "kernels/elementwise_functions/common.hpp"
 
-#include "utils/offset_utils.hpp"
 #include "utils/type_dispatch_building.hpp"
 #include "utils/type_utils.hpp"
 
diff --git a/dpctl_ext/tensor/libtensor/include/kernels/elementwise_functions/atan.hpp b/dpctl_ext/tensor/libtensor/include/kernels/elementwise_functions/atan.hpp
@@ -49,7 +49,6 @@
 #include "kernels/dpctl_tensor_types.hpp"
 #include "kernels/elementwise_functions/common.hpp"
 
-#include "utils/offset_utils.hpp"
 #include "utils/type_dispatch_building.hpp"
 #include "utils/type_utils.hpp"
 
diff --git a/dpctl_ext/tensor/libtensor/include/kernels/elementwise_functions/atanh.hpp b/dpctl_ext/tensor/libtensor/include/kernels/elementwise_functions/atanh.hpp
@@ -50,7 +50,6 @@
 #include "kernels/dpctl_tensor_types.hpp"
 #include "kernels/elementwise_functions/common.hpp"
 
-#include "utils/offset_utils.hpp"
 #include "utils/type_dispatch_building.hpp"
 #include "utils/type_utils.hpp"
 
diff --git a/dpctl_ext/tensor/libtensor/include/kernels/elementwise_functions/bitwise_invert.hpp b/dpctl_ext/tensor/libtensor/include/kernels/elementwise_functions/bitwise_invert.hpp
@@ -46,7 +46,6 @@
 #include "kernels/dpctl_tensor_types.hpp"
 #include "kernels/elementwise_functions/common.hpp"
 
-#include "utils/offset_utils.hpp"
 #include "utils/type_dispatch_building.hpp"
 #include "utils/type_utils.hpp"
 
diff --git a/dpctl_ext/tensor/libtensor/include/kernels/elementwise_functions/ceil.hpp b/dpctl_ext/tensor/libtensor/include/kernels/elementwise_functions/ceil.hpp
@@ -32,7 +32,6 @@
 /// This file defines kernels for elementwise evaluation of CEIL(x) function.
 //===---------------------------------------------------------------------===//
 
-#pragma once
 #pragma once
 
 #include <cstddef>
@@ -47,7 +46,6 @@
 #include "kernels/dpctl_tensor_types.hpp"
 #include "kernels/elementwise_functions/common.hpp"
 
-#include "utils/offset_utils.hpp"
 #include "utils/type_dispatch_building.hpp"
 #include "utils/type_utils.hpp"
 
diff --git a/dpctl_ext/tensor/libtensor/include/kernels/elementwise_functions/conj.hpp b/dpctl_ext/tensor/libtensor/include/kernels/elementwise_functions/conj.hpp
@@ -33,6 +33,7 @@
 //===---------------------------------------------------------------------===//
 
 #pragma once
+#include <complex>
 #include <cstddef>
 #include <cstdint>
 #include <type_traits>
@@ -46,7 +47,6 @@
 #include "kernels/dpctl_tensor_types.hpp"
 #include "kernels/elementwise_functions/common.hpp"
 
-#include "utils/offset_utils.hpp"
 #include "utils/type_dispatch_building.hpp"
 #include "utils/type_utils.hpp"
 
diff --git a/dpctl_ext/tensor/libtensor/source/elementwise_functions/acos.cpp b/dpctl_ext/tensor/libtensor/source/elementwise_functions/acos.cpp
@@ -53,6 +53,7 @@
 namespace dpctl::tensor::py_internal
 {
 
+namespace py = pybind11;
 namespace td_ns = dpctl::tensor::type_dispatch;
 
 namespace ew_cmn_ns = dpctl::tensor::kernels::elementwise_common;
diff --git a/dpctl_ext/tensor/libtensor/source/elementwise_functions/atanh.cpp b/dpctl_ext/tensor/libtensor/source/elementwise_functions/atanh.cpp
@@ -50,11 +50,10 @@
 #include "kernels/elementwise_functions/atanh.hpp"
 #include "kernels/elementwise_functions/common.hpp"
 
-namespace py = pybind11;
-
 namespace dpctl::tensor::py_internal
 {
 
+namespace py = pybind11;
 namespace td_ns = dpctl::tensor::type_dispatch;
 
 namespace ew_cmn_ns = dpctl::tensor::kernels::elementwise_common;
@@ -65,7 +64,6 @@ using ew_cmn_ns::unary_strided_impl_fn_ptr_t;
 namespace impl
 {
 
-namespace py = pybind11;
 namespace atanh_fn_ns = dpctl::tensor::kernels::atanh;
 
 static unary_contig_impl_fn_ptr_t
diff --git a/dpctl_ext/tensor/libtensor/source/elementwise_functions/ceil.hpp b/dpctl_ext/tensor/libtensor/source/elementwise_functions/ceil.hpp
@@ -38,8 +38,6 @@
 
 namespace py = pybind11;
 
-namespace py = pybind11;
-
 namespace dpctl::tensor::py_internal
 {
 
diff --git a/dpctl_ext/tensor/libtensor/source/elementwise_functions/elementwise_functions.hpp b/dpctl_ext/tensor/libtensor/source/elementwise_functions/elementwise_functions.hpp
@@ -35,7 +35,6 @@
 
 #pragma once
 
-#include <algorithm>
 #include <cstddef>
 #include <stdexcept>
 #include <string>
@@ -50,7 +49,6 @@
 #include <pybind11/pybind11.h>
 
 #include "elementwise_functions_type_utils.hpp"
-#include "kernels/alignment.hpp"
 #include "kernels/dpctl_tensor_types.hpp"
 #include "simplify_iteration_space.hpp"
 #include "utils/memory_overlap.hpp"
@@ -67,9 +65,6 @@ namespace dpctl::tensor::py_internal
 namespace py = pybind11;
 namespace td_ns = dpctl::tensor::type_dispatch;
 
-using dpctl::tensor::kernels::alignment_utils::is_aligned;
-using dpctl::tensor::kernels::alignment_utils::required_alignment;
-
 /*! @brief Template implementing Python API for unary elementwise functions */
 template <typename output_typesT,
           typename contig_dispatchT,
@@ -188,11 +183,10 @@ std::pair<sycl::event, sycl::event>
     int nd = src_nd;
     const py::ssize_t *shape = src_shape;
 
-    dpctl::tensor::py_internal::simplify_iteration_space(
-        nd, shape, src_strides, dst_strides,
-        // output
-        simplified_shape, simplified_src_strides, simplified_dst_strides,
-        src_offset, dst_offset);
+    simplify_iteration_space(nd, shape, src_strides, dst_strides,
+                             // output
+                             simplified_shape, simplified_src_strides,
+                             simplified_dst_strides, src_offset, dst_offset);
 
     if (nd == 1 && simplified_src_strides[0] == 1 &&
         simplified_dst_strides[0] == 1) {
@@ -270,15 +264,15 @@ py::object py_unary_ufunc_result_type(const py::dtype &input_dtype,
         throw py::value_error(e.what());
     }
 
-    using dpctl::tensor::py_internal::type_utils::_result_typeid;
+    using type_utils::_result_typeid;
     int dst_typeid = _result_typeid(src_typeid, output_types);
 
     if (dst_typeid < 0) {
         auto res = py::none();
         return py::cast<py::object>(res);
     }
     else {
-        using dpctl::tensor::py_internal::type_utils::_dtype_from_typenum;
+        using type_utils::_dtype_from_typenum;
 
         auto dst_typenum_t = static_cast<td_ns::typenum_t>(dst_typeid);
         auto dt = _dtype_from_typenum(dst_typenum_t);
diff --git a/dpctl_ext/tensor/libtensor/source/elementwise_functions/elementwise_functions_type_utils.cpp b/dpctl_ext/tensor/libtensor/source/elementwise_functions/elementwise_functions_type_utils.cpp
@@ -35,7 +35,6 @@
 
 #include <string>
 
-#include "dpnp4pybind11.hpp"
 #include <pybind11/numpy.h>
 #include <pybind11/pybind11.h>
 
diff --git a/dpctl_ext/tensor/libtensor/source/elementwise_functions/elementwise_functions_type_utils.hpp b/dpctl_ext/tensor/libtensor/source/elementwise_functions/elementwise_functions_type_utils.hpp
@@ -35,9 +35,6 @@
 
 #pragma once
 
-#include <sycl/sycl.hpp>
-
-#include "dpnp4pybind11.hpp"
 #include <pybind11/numpy.h>
 #include <pybind11/pybind11.h>
 
