Skip to content

Commit 3147fe0

Browse files
committed
Use std namespace explicitly
1 parent 8dd4275 commit 3147fe0

File tree

4 files changed

+93
-74
lines changed

4 files changed

+93
-74
lines changed

dpnp/backend/extensions/statistics/histogram_common.hpp

Lines changed: 56 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -71,23 +71,26 @@ struct CachedData
7171
template <int _Dims>
7272
void init(const sycl::nd_item<_Dims> &item) const
7373
{
74-
uint32_t llid = item.get_local_linear_id();
74+
std::uint32_t llid = item.get_local_linear_id();
7575
auto local_ptr = &local_data[0];
76-
uint32_t size = local_data.size();
76+
std::uint32_t size = local_data.size();
7777
auto group = item.get_group();
78-
uint32_t local_size = group.get_local_linear_range();
78+
std::uint32_t local_size = group.get_local_linear_range();
7979

80-
for (uint32_t i = llid; i < size; i += local_size) {
80+
for (std::uint32_t i = llid; i < size; i += local_size) {
8181
local_ptr[i] = global_data[i];
8282
}
8383
}
8484

85-
size_t size() const { return local_data.size(); }
85+
std::size_t size() const
86+
{
87+
return local_data.size();
88+
}
8689

8790
T &operator[](const sycl::id<Dims> &id) const { return local_data[id]; }
8891

8992
template <typename = std::enable_if_t<Dims == 1>>
90-
T &operator[](const size_t id) const
93+
T &operator[](const std::size_t id) const
9194
{
9295
return local_data[id];
9396
}
@@ -119,12 +122,15 @@ struct UncachedData
119122
{
120123
}
121124

122-
size_t size() const { return _shape.size(); }
125+
std::size_t size() const
126+
{
127+
return _shape.size();
128+
}
123129

124130
T &operator[](const sycl::id<Dims> &id) const { return global_data[id]; }
125131

126132
template <typename = std::enable_if_t<Dims == 1>>
127-
T &operator[](const size_t id) const
133+
T &operator[](const std::size_t id) const
128134
{
129135
return global_data[id];
130136
}
@@ -141,15 +147,15 @@ struct HistLocalType
141147
};
142148

143149
template <>
144-
struct HistLocalType<uint64_t>
150+
struct HistLocalType<std::uint64_t>
145151
{
146-
using type = uint32_t;
152+
using type = std::uint32_t;
147153
};
148154

149155
template <>
150-
struct HistLocalType<int64_t>
156+
struct HistLocalType<std::int64_t>
151157
{
152-
using type = int32_t;
158+
using type = std::int32_t;
153159
};
154160

155161
template <typename T, typename localT = typename HistLocalType<T>::type>
@@ -161,8 +167,8 @@ struct HistWithLocalCopies
161167
using LocalHist = sycl::local_accessor<localT, 2>;
162168

163169
HistWithLocalCopies(T *global_data,
164-
size_t bins_count,
165-
int32_t copies_count,
170+
std::size_t bins_count,
171+
std::int32_t copies_count,
166172
sycl::handler &cgh)
167173
{
168174
local_hist = LocalHist(sycl::range<2>(copies_count, bins_count), cgh);
@@ -172,23 +178,25 @@ struct HistWithLocalCopies
172178
template <int _Dims>
173179
void init(const sycl::nd_item<_Dims> &item, localT val = 0) const
174180
{
175-
uint32_t llid = item.get_local_linear_id();
181+
std::uint32_t llid = item.get_local_linear_id();
176182
auto *local_ptr = &local_hist[0][0];
177-
uint32_t size = local_hist.size();
183+
std::uint32_t size = local_hist.size();
178184
auto group = item.get_group();
179-
uint32_t local_size = group.get_local_linear_range();
185+
std::uint32_t local_size = group.get_local_linear_range();
180186

181-
for (uint32_t i = llid; i < size; i += local_size) {
187+
for (std::uint32_t i = llid; i < size; i += local_size) {
182188
local_ptr[i] = val;
183189
}
184190
}
185191

186192
template <int _Dims>
187-
void add(const sycl::nd_item<_Dims> &item, int32_t bin, localT value) const
193+
void add(const sycl::nd_item<_Dims> &item,
194+
std::int32_t bin,
195+
localT value) const
188196
{
189-
int32_t llid = item.get_local_linear_id();
190-
int32_t local_hist_count = local_hist.get_range().get(0);
191-
int32_t local_copy_id =
197+
std::int32_t llid = item.get_local_linear_id();
198+
std::int32_t local_hist_count = local_hist.get_range().get(0);
199+
std::int32_t local_copy_id =
192200
local_hist_count == 1 ? 0 : llid % local_hist_count;
193201

194202
AtomicOp<localT, sycl::memory_order::relaxed,
@@ -200,15 +208,15 @@ struct HistWithLocalCopies
200208
template <int _Dims>
201209
void finalize(const sycl::nd_item<_Dims> &item) const
202210
{
203-
uint32_t llid = item.get_local_linear_id();
204-
uint32_t bins_count = local_hist.get_range().get(1);
205-
uint32_t local_hist_count = local_hist.get_range().get(0);
211+
std::uint32_t llid = item.get_local_linear_id();
212+
std::uint32_t bins_count = local_hist.get_range().get(1);
213+
std::uint32_t local_hist_count = local_hist.get_range().get(0);
206214
auto group = item.get_group();
207-
uint32_t local_size = group.get_local_linear_range();
215+
std::uint32_t local_size = group.get_local_linear_range();
208216

209-
for (uint32_t i = llid; i < bins_count; i += local_size) {
217+
for (std::uint32_t i = llid; i < bins_count; i += local_size) {
210218
auto value = local_hist[0][i];
211-
for (uint32_t lhc = 1; lhc < local_hist_count; ++lhc) {
219+
for (std::uint32_t lhc = 1; lhc < local_hist_count; ++lhc) {
212220
value += local_hist[lhc][i];
213221
}
214222
if (value != T(0)) {
@@ -219,7 +227,10 @@ struct HistWithLocalCopies
219227
}
220228
}
221229

222-
uint32_t size() const { return local_hist.size(); }
230+
std::uint32_t size() const
231+
{
232+
return local_hist.size();
233+
}
223234

224235
private:
225236
LocalHist local_hist;
@@ -240,7 +251,7 @@ struct HistGlobalMemory
240251
}
241252

242253
template <int _Dims>
243-
void add(const sycl::nd_item<_Dims> &, int32_t bin, T value) const
254+
void add(const sycl::nd_item<_Dims> &, std::int32_t bin, T value) const
244255
{
245256
AtomicOp<T, sycl::memory_order::relaxed,
246257
sycl::memory_scope::device>::add(global_hist[bin], value);
@@ -255,18 +266,24 @@ struct HistGlobalMemory
255266
T *global_hist = nullptr;
256267
};
257268

258-
template <typename T = uint32_t>
269+
template <typename T = std::uint32_t>
259270
struct NoWeights
260271
{
261-
constexpr T get(size_t) const { return 1; }
272+
constexpr T get(std::size_t) const
273+
{
274+
return 1;
275+
}
262276
};
263277

264278
template <typename T>
265279
struct Weights
266280
{
267281
Weights(T *weights) { data = weights; }
268282

269-
T get(size_t id) const { return data[id]; }
283+
T get(std::size_t id) const
284+
{
285+
return data[id];
286+
}
270287

271288
private:
272289
T *data = nullptr;
@@ -281,9 +298,9 @@ bool check_in_bounds(const dT &val, const dT &min, const dT &max)
281298

282299
template <typename T, typename HistImpl, typename Edges, typename Weights>
283300
void submit_histogram(const T *in,
284-
const size_t size,
285-
const size_t dims,
286-
const uint32_t WorkPI,
301+
const std::size_t size,
302+
const std::size_t dims,
303+
const std::uint32_t WorkPI,
287304
const HistImpl &hist,
288305
const Edges &edges,
289306
const Weights &weights,
@@ -303,8 +320,8 @@ void validate(const usm_ndarray &sample,
303320
const std::optional<const dpctl::tensor::usm_ndarray> &weights,
304321
const usm_ndarray &histogram);
305322

306-
uint32_t get_local_hist_copies_count(uint32_t loc_mem_size_in_items,
307-
uint32_t local_size,
308-
uint32_t hist_size_in_items);
323+
std::uint32_t get_local_hist_copies_count(std::uint32_t loc_mem_size_in_items,
324+
std::uint32_t local_size,
325+
std::uint32_t hist_size_in_items);
309326

310327
} // namespace statistics::histogram

dpnp/backend/extensions/statistics/sliding_window1d.hpp

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ namespace statistics::sliding_window1d
4242
{
4343
using dpctl::tensor::usm_ndarray;
4444

45-
template <typename T, uint32_t Size>
45+
template <typename T, std::uint32_t Size>
4646
class _RegistryDataStorage
4747
{
4848
public:
@@ -140,7 +140,7 @@ class _RegistryDataStorage
140140
ncT data[Size];
141141
};
142142

143-
template <typename T, uint32_t Size = 1>
143+
template <typename T, std::uint32_t Size = 1>
144144
struct RegistryData : public _RegistryDataStorage<T, Size>
145145
{
146146
using SizeT = typename _RegistryDataStorage<T, Size>::SizeT;
@@ -332,7 +332,7 @@ struct RegistryData : public _RegistryDataStorage<T, Size>
332332
T *store(T *const data) { return store(data, true); }
333333
};
334334

335-
template <typename T, uint32_t Size>
335+
template <typename T, std::uint32_t Size>
336336
struct RegistryWindow : public RegistryData<T, Size>
337337
{
338338
using SizeT = typename RegistryData<T, Size>::SizeT;
@@ -345,7 +345,7 @@ struct RegistryWindow : public RegistryData<T, Size>
345345
static_assert(std::is_integral_v<shT>,
346346
"shift must be of an integral type");
347347

348-
uint32_t shift_r = this->size_x() - shift;
348+
std::uint32_t shift_r = this->size_x() - shift;
349349
for (SizeT i = 0; i < Size; ++i) {
350350
this->data[i] = this->shift_left(i, shift);
351351
auto border =
@@ -365,7 +365,7 @@ struct RegistryWindow : public RegistryData<T, Size>
365365
}
366366
};
367367

368-
template <typename T, typename SizeT = size_t>
368+
template <typename T, typename SizeT = std::size_t>
369369
class Span
370370
{
371371
public:
@@ -387,13 +387,13 @@ class Span
387387
const SizeT size_;
388388
};
389389

390-
template <typename T, typename SizeT = size_t>
390+
template <typename T, typename SizeT = std::size_t>
391391
Span<T, SizeT> make_span(T *const data, const SizeT size)
392392
{
393393
return Span<T, SizeT>(data, size);
394394
}
395395

396-
template <typename T, typename SizeT = size_t>
396+
template <typename T, typename SizeT = std::size_t>
397397
class PaddedSpan : public Span<T, SizeT>
398398
{
399399
public:
@@ -413,14 +413,14 @@ class PaddedSpan : public Span<T, SizeT>
413413
const SizeT pad_;
414414
};
415415

416-
template <typename T, typename SizeT = size_t>
416+
template <typename T, typename SizeT = std::size_t>
417417
PaddedSpan<T, SizeT>
418418
make_padded_span(T *const data, const SizeT size, const SizeT offset)
419419
{
420420
return PaddedSpan<T, SizeT>(data, size, offset);
421421
}
422422

423-
template <uint32_t WorkPI,
423+
template <std::uint32_t WorkPI,
424424
typename T,
425425
typename SizeT,
426426
typename Op,
@@ -442,7 +442,7 @@ void submit_sliding_window1d(const PaddedSpan<const T, SizeT> &a,
442442
nd_range, SlidingWindow1dKernel(a, v, op, red, out));
443443
}
444444

445-
template <uint32_t WorkPI,
445+
template <std::uint32_t WorkPI,
446446
typename T,
447447
typename SizeT,
448448
typename Op,
@@ -467,6 +467,6 @@ void submit_sliding_window1d_small_kernel(const PaddedSpan<const T, SizeT> &a,
467467
void validate(const usm_ndarray &a,
468468
const usm_ndarray &v,
469469
const usm_ndarray &out,
470-
const size_t l_pad,
471-
const size_t r_pad);
470+
const std::size_t l_pad,
471+
const std::size_t r_pad);
472472
} // namespace statistics::sliding_window1d

dpnp/backend/kernels/statistics/histogram.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ class HistogramFunctor
7676

7777
auto bounds = edges.get_bounds();
7878

79-
for (uint32_t i = 0; i < WorkPI; ++i) {
79+
for (std::uint32_t i = 0; i < WorkPI; ++i) {
8080
auto data_idx = id * WorkPI * local_size + i * local_size + lid;
8181
if (data_idx < size) {
8282
auto *d = &in[data_idx * dims];

0 commit comments

Comments
 (0)