Skip to content

Commit 498c281

Browse files
Apply suggestions from code review
Co-authored-by: vlad-perevezentsev <vladislav.perevezentsev@intel.com>
1 parent a8ca081 commit 498c281

2 files changed

Lines changed: 1 addition & 4 deletions

File tree

CHANGELOG.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -88,12 +88,9 @@ Also, that release drops support for Python 3.9, making Python 3.10 the minimum
8888
* Resolved an issue with strides calculation in `dpnp.diagonal` to return correct values for empty diagonals [#2814](https://github.com/IntelPython/dpnp/pull/2814)
8989
* Fixed test tolerance issues for float16 intermediate precision that became visible when testing against conda-forge's NumPy [#2828](https://github.com/IntelPython/dpnp/pull/2828)
9090
* Ensured device aware dtype handling in `dpnp.identity` and `dpnp.gradient` [#2835](https://github.com/IntelPython/dpnp/pull/2835)
91-
<<<<<<< matrix-rank-for-empty-array
9291
* Fixed `dpnp.linalg.matrix_rank` to properly handle an empty input array [#2853](https://github.com/IntelPython/dpnp/pull/2853)
93-
=======
9492
* Fixed `dpnp.tensor.round` to use device-aware output dtype for boolean input [#2851](https://github.com/IntelPython/dpnp/pull/2851)
9593
* Resolved a deadlock in `dpnp.linalg.qr` by releasing the GIL before OneMKL `orgqr` call to prevent host tasks contention [#2850](https://github.com/IntelPython/dpnp/pull/2850)
96-
>>>>>>> master
9794

9895
### Security
9996

dpnp/tests/test_linalg.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3265,7 +3265,7 @@ def test_empty(self, shape):
32653265
if expected.ndim == 0:
32663266
expected = numpy.array(0)
32673267
else:
3268-
result = numpy.linalg.matrix_rank(a)
3268+
expected = numpy.linalg.matrix_rank(a)
32693269
assert_array_equal(result, expected, strict=True)
32703270

32713271
# Also test with hermitian=True

0 commit comments

Comments
 (0)