Apply remarks

Author: vlad-perevezentsev

dpctl_ext/tensor/_accumulation.py

@@ -35,14 +35,14 @@
 import dpctl_ext.tensor as dpt_ext
 import dpctl_ext.tensor._tensor_accumulation_impl as tai
 import dpctl_ext.tensor._tensor_impl as ti
-from dpctl_ext.tensor._type_utils import (
+
+from ._numpy_helper import normalize_axis_index
+from ._type_utils import (
     _default_accumulation_dtype,
     _default_accumulation_dtype_fp_types,
     _to_device_supported_dtype,
 )
 
-from ._numpy_helper import normalize_axis_index
-
 
 def _accumulate_common(
     x,

dpctl_ext/tensor/libtensor/source/accumulators/accumulate_over_axis.hpp

@@ -35,9 +35,12 @@
 
 #pragma once
 
+#include <algorithm>
 #include <cstddef>
-#include <cstdint>
+#include <exception>
+#include <iterator>
 #include <stdexcept>
+#include <tuple>
 #include <type_traits>
 #include <utility>
 #include <vector>

dpctl_ext/tensor/libtensor/source/accumulators/cumulative_logsumexp.cpp

@@ -311,7 +311,6 @@ void init_cumulative_logsumexp(py::module_ m)
                                   int trailing_dims_to_accumulate,
                                   const arrayT &dst, sycl::queue &exec_q,
                                   const event_vecT &depends = {}) {
-        using dpctl::tensor::py_internal::py_accumulate_over_axis;
         return py_accumulate_over_axis(src, trailing_dims_to_accumulate, dst,
                                        exec_q, depends,
                                        cumlogsumexp_strided_dispatch_table,
@@ -326,8 +325,6 @@ void init_cumulative_logsumexp(py::module_ m)
     auto cumlogsumexp_include_initial_pyapi =
         [&](const arrayT &src, const arrayT &dst, sycl::queue &exec_q,
             const event_vecT &depends = {}) {
-            using dpctl::tensor::py_internal::
-                py_accumulate_final_axis_include_initial;
             return py_accumulate_final_axis_include_initial(
                 src, dst, exec_q, depends,
                 cumlogsumexp_include_initial_strided_dispatch_table,

dpctl_ext/tensor/libtensor/source/accumulators/cumulative_prod.cpp

@@ -322,7 +322,6 @@ void init_cumulative_prod(py::module_ m)
     auto cumprod_pyapi = [&](const arrayT &src, int trailing_dims_to_accumulate,
                              const arrayT &dst, sycl::queue &exec_q,
                              const event_vecT &depends = {}) {
-        using dpctl::tensor::py_internal::py_accumulate_over_axis;
         return py_accumulate_over_axis(
             src, trailing_dims_to_accumulate, dst, exec_q, depends,
             cumprod_strided_dispatch_table, cumprod_1d_contig_dispatch_table);
@@ -336,8 +335,6 @@ void init_cumulative_prod(py::module_ m)
     auto cumprod_include_initial_pyapi =
         [&](const arrayT &src, const arrayT &dst, sycl::queue &exec_q,
             const event_vecT &depends = {}) {
-            using dpctl::tensor::py_internal::
-                py_accumulate_final_axis_include_initial;
             return py_accumulate_final_axis_include_initial(
                 src, dst, exec_q, depends,
                 cumprod_include_initial_strided_dispatch_table,

dpctl_ext/tensor/libtensor/source/accumulators/cumulative_sum.cpp

@@ -320,7 +320,6 @@ void init_cumulative_sum(py::module_ m)
     auto cumsum_pyapi = [&](const arrayT &src, int trailing_dims_to_accumulate,
                             const arrayT &dst, sycl::queue &exec_q,
                             const event_vecT &depends = {}) {
-        using dpctl::tensor::py_internal::py_accumulate_over_axis;
         return py_accumulate_over_axis(
             src, trailing_dims_to_accumulate, dst, exec_q, depends,
             cumsum_strided_dispatch_table, cumsum_1d_contig_dispatch_table);
@@ -334,8 +333,6 @@ void init_cumulative_sum(py::module_ m)
     auto cumsum_include_initial_pyapi =
         [&](const arrayT &src, const arrayT &dst, sycl::queue &exec_q,
             const event_vecT &depends = {}) {
-            using dpctl::tensor::py_internal::
-                py_accumulate_final_axis_include_initial;
             return py_accumulate_final_axis_include_initial(
                 src, dst, exec_q, depends,
                 cumsum_include_initial_strided_dispatch_table,