Add missing memory and queue checks

Author: vlad-perevezentsev

dpctl_ext/tensor/libtensor/source/copy_as_contig.cpp

@@ -189,6 +189,12 @@ std::pair<sycl::event, sycl::event>
             "Execution queue is not compatible with allocation queues");
     }
 
+    // check that arrays do not overlap, and concurrent copying is safe.
+    auto const &overlap = dpctl::tensor::overlap::MemoryOverlap();
+    if (overlap(src, dst)) {
+        throw py::value_error("Arrays index overlapping segments of memory");
+    }
+
     const auto &src_strides_vec = src.get_strides_vector();
 
     if (src_nd >= 2) {
@@ -314,6 +320,12 @@ std::pair<sycl::event, sycl::event>
             "Execution queue is not compatible with allocation queues");
     }
 
+    // check that arrays do not overlap, and concurrent copying is safe.
+    auto const &overlap = dpctl::tensor::overlap::MemoryOverlap();
+    if (overlap(src, dst)) {
+        throw py::value_error("Arrays index overlapping segments of memory");
+    }
+
     const auto &src_strides_vec = src.get_strides_vector();
 
     if (src_nd >= 2) {
@@ -459,6 +471,12 @@ std::pair<sycl::event, sycl::event>
             "Execution queue is not compatible with allocation queues");
     }
 
+    // check that arrays do not overlap, and concurrent copying is safe.
+    auto const &overlap = dpctl::tensor::overlap::MemoryOverlap();
+    if (overlap(src, dst)) {
+        throw py::value_error("Arrays index overlapping segments of memory");
+    }
+
     if (nelems == 0) {
         // nothing to do
         return std::make_pair(sycl::event(), sycl::event());
@@ -624,6 +642,20 @@ std::pair<sycl::event, sycl::event>
         throw py::value_error("Unexpected destination array layout");
     }
 
+    dpctl::tensor::validation::CheckWritable::throw_if_not_writable(dst);
+
+    // check compatibility of execution queue and allocation queue
+    if (!dpctl::utils::queues_are_compatible(exec_q, {src, dst})) {
+        throw py::value_error(
+            "Execution queue is not compatible with allocation queues");
+    }
+
+    // check that arrays do not overlap, and concurrent copying is safe.
+    auto const &overlap = dpctl::tensor::overlap::MemoryOverlap();
+    if (overlap(src, dst)) {
+        throw py::value_error("Arrays index overlapping segments of memory");
+    }
+
     int src_typenum = src.get_typenum();
     int dst_typenum = dst.get_typenum();