Skip to content

Commit d7c5053

Browse files
committed
Mute modf umath on CUDA explicitly in the test
1 parent f102a0b commit d7c5053

2 files changed

Lines changed: 6 additions & 4 deletions

File tree

dpnp/tests/skipped_tests_cuda.tbl

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44
tests/test_arithmetic.py::TestArithmetic::test_modf_part1
55
tests/test_arithmetic.py::TestArithmetic::test_modf_part2
66
tests/test_sycl_queue.py::test_modf[cuda:gpu:0]
7-
tests/test_umath.py::test_umaths[('modf', 'f')]
8-
tests/test_umath.py::test_umaths[('modf', 'd')]
97
tests/third_party/cupy/math_tests/test_arithmetic.py::TestArithmeticModf::test_modf
108

119
# random

dpnp/tests/test_umath.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
get_float_dtypes,
2020
has_support_aspect16,
2121
has_support_aspect64,
22+
is_cuda_device,
2223
is_gpu_device,
2324
)
2425

@@ -107,8 +108,11 @@ def test_umaths(test_cases):
107108
pytest.skip("dpctl-1652")
108109
elif umath in ["divmod", "frexp"]:
109110
pytest.skip("Not implemented umath")
110-
elif umath == "modf" and args[0].dtype == dpnp.float16:
111-
pytest.skip("dpnp.modf is not supported with dpnp.float16")
111+
elif umath == "modf":
112+
if args[0].dtype == dpnp.float16:
113+
pytest.skip("dpnp.modf is not supported with dpnp.float16")
114+
elif is_cuda_device():
115+
pytest.skip("dpnp.modf is not supported on CUDA device")
112116

113117
expected = getattr(numpy, umath)(*args)
114118
result = getattr(dpnp, umath)(*iargs)

0 commit comments

Comments
 (0)