Skip to content

Fix meshgrid return type #2854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
antonwolfy wants to merge 3 commits into
base: master
Choose a base branch
from
+11 −4
Draft

Fix meshgrid return type #2854

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
55df20c
Always return tuple from meshgrid()
antonwolfy Apr 15, 2026
15e568a
Add testing of tuple to test_meshgrid
antonwolfy Apr 15, 2026
ef08ce9
Populate the changelog
antonwolfy Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ Also, that release drops support for Python 3.9, making Python 3.10 the minimum
* Updated QR tests to avoid element-wise comparisons for `raw` and `r` modes [#2785](https://github.com/IntelPython/dpnp/pull/2785)
* Moved all SYCL kernel functors from `backend/extensions/` to a unified `backend/kernels/` directory hierarchy [#2816](https://github.com/IntelPython/dpnp/pull/2816)
* `dpnp` uses pybind11 3.0.3 [#2834](https://github.com/IntelPython/dpnp/pull/2834)
* Changed `dpnp.meshgrid` to return a tuple instead of a list, aligning with NumPy 2.5+ behavior and 2025.12 version of the Python array API standard [#2854](https://github.com/IntelPython/dpnp/pull/2854)

### Deprecated

Expand Down
4 changes: 2 additions & 2 deletions dpnp/dpnp_iface_arraycreation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3111,7 +3111,7 @@ def meshgrid(*xi, copy=True, sparse=False, indexing="xy"):
)

if ndim < 1:
return []
return ()

s0 = (1,) * ndim
output = [
Expand All @@ -3132,7 +3132,7 @@ def meshgrid(*xi, copy=True, sparse=False, indexing="xy"):
if copy:
output = [dpt.copy(x) for x in output]

return [dpnp_array._create_from_usm_ndarray(x) for x in output]
return tuple(dpnp_array._create_from_usm_ndarray(x) for x in output)


class MGridClass:
Expand Down
10 changes: 8 additions & 2 deletions dpnp/tests/test_arraycreation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -984,13 +984,19 @@ def test_dpctl_tensor_input(func, args):
[[], [[1]], [[1, 2, 3], [4, 5, 6]], [[1, 2], [3, 4], [5, 6]]],
ids=["[]", "[[1]]", "[[1, 2, 3], [4, 5, 6]]", "[[1, 2], [3, 4], [5, 6]]"],
)
@pytest.mark.parametrize("dtype", get_all_dtypes(no_float16=False))
@pytest.mark.parametrize(
"dtype", get_all_dtypes(no_none=True, no_float16=False)
)
@pytest.mark.parametrize("indexing", ["ij", "xy"])
def test_meshgrid(arrays, dtype, indexing):
func = lambda xp, xi: xp.meshgrid(*xi, indexing=indexing)
a = tuple(numpy.array(array, dtype=dtype) for array in arrays)
ia = tuple(dpnp.array(array, dtype=dtype) for array in arrays)
assert_array_equal(func(numpy, a), func(dpnp, ia))

result = func(dpnp, ia)
expected = func(numpy, a)
assert_array_equal(result, expected, strict=True)
assert isinstance(result, tuple)


@pytest.mark.parametrize("shape", [(24,), (4, 6), (2, 3, 4), (2, 3, 2, 2)])
Expand Down
Loading