Clean up technical debt in integer indexing Python bindings#2935
Open
ndgrigorian wants to merge 7 commits into
Open
Clean up technical debt in integer indexing Python bindings#2935ndgrigorian wants to merge 7 commits into
ndgrigorian wants to merge 7 commits into
Conversation
simplifies logic
1ebc435 to
fa71591
Compare
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/pull/2935/index.html |
Contributor
|
Array API standard conformance tests for dpnp=0.21.0dev0=py313h509198e_56 ran successfully. |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes various changes to clean technical debt in the tensor integer indexing Python bindings
_populate_kernel_paramsis refactored to be more readable, and anaxis_endparameter is added to the Python bindings, which aligns with the boolean mask Python bindings and improves the logic.Additionally,
usm_ndarray_takeandusm_ndarray_putare renamed topy_takeandpy_put, respectively. This aligns the two with the other non-constructor bindings (usm_ndarrayfunctions are generally constructors).