Skip to content

Clean up technical debt in integer indexing Python bindings#2935

Open
ndgrigorian wants to merge 7 commits into
masterfrom
technical-debt-tensor-indexing
Open

Clean up technical debt in integer indexing Python bindings#2935
ndgrigorian wants to merge 7 commits into
masterfrom
technical-debt-tensor-indexing

Conversation

@ndgrigorian
Copy link
Copy Markdown
Collaborator

This PR proposes various changes to clean technical debt in the tensor integer indexing Python bindings

_populate_kernel_params is refactored to be more readable, and an axis_end parameter is added to the Python bindings, which aligns with the boolean mask Python bindings and improves the logic.

Additionally, usm_ndarray_take and usm_ndarray_put are renamed to py_take and py_put, respectively. This aligns the two with the other non-constructor bindings (usm_ndarray functions are generally constructors).

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@ndgrigorian ndgrigorian force-pushed the technical-debt-tensor-indexing branch from 1ebc435 to fa71591 Compare May 30, 2026 01:54
@github-actions
Copy link
Copy Markdown
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/pull/2935/index.html

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 30, 2026

Array API standard conformance tests for dpnp=0.21.0dev0=py313h509198e_56 ran successfully.
Passed: 1357
Failed: 3
Skipped: 16

@coveralls
Copy link
Copy Markdown
Collaborator

Coverage Status

coverage: 78.336%. remained the same — technical-debt-tensor-indexing into master

@ndgrigorian ndgrigorian marked this pull request as ready for review May 30, 2026 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants