Skip to content

Commit 790768b

Browse files
committed
clean up errors/warnings in windows workflows
1 parent fbbf397 commit 790768b

File tree

2 files changed

+26
-20
lines changed

2 files changed

+26
-20
lines changed

.github/workflows/conda-package-cf.yml

Lines changed: 19 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -103,10 +103,13 @@ jobs:
103103

104104
- uses: conda-incubator/setup-miniconda@fc2d68f6413eb2d87b895e92f8584b5b94a10167 # v3.3.0
105105
with:
106-
conda-remove-defaults: true
107-
channels: conda-forge
106+
miniforge-variant: Miniforge3
107+
miniforge-version: latest
108108
auto-activate: true
109109
activate-environment: base
110+
channels: conda-forge
111+
conda-remove-defaults: true
112+
python-version: ${{ matrix.python }}
110113

111114
- name: Cache conda packages
112115
uses: actions/cache@cdf6c1fa76f9f475f3d7449005a359c84ca0f306 # v5.0.3
@@ -123,14 +126,19 @@ jobs:
123126
- name: Install conda-build
124127
run: conda install -n base -y conda-build
125128

129+
- name: Store conda paths as envs
130+
shell: bash -el {0}
131+
run: |
132+
echo "CONDA_BLD=${CONDA_PREFIX}\\conda-bld\\win-64\\" >> "$GITHUB_ENV"
133+
126134
- name: Build conda package
127135
run: conda build --no-test --python ${{ matrix.python }} --numpy ${{ matrix.numpy }} -c conda-forge --override-channels conda-recipe-cf
128136

129137
- name: Upload artifact
130138
uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f # v7.0.0
131139
with:
132140
name: ${{ env.PACKAGE_NAME }} ${{ runner.os }} Python ${{ matrix.python }}
133-
path: ${{ env.conda-bld }}${{ env.PACKAGE_NAME }}-*.conda
141+
path: ${{ env.CONDA_BLD }}${{ env.PACKAGE_NAME }}-*.conda
134142

135143
test_linux:
136144
needs: build_linux
@@ -243,14 +251,14 @@ jobs:
243251

244252
- uses: conda-incubator/setup-miniconda@fc2d68f6413eb2d87b895e92f8584b5b94a10167 # v3.3.0
245253
with:
246-
conda-remove-defaults: true
254+
miniforge-version: latest
247255
channels: conda-forge
248-
auto-activate: true
249-
activate-environment: base
256+
conda-remove-defaults: true
257+
activate-environment: ${{ env.TEST_ENV_NAME }}
258+
python-version: ${{ matrix.python }}
250259

251-
- name: Install conda-build
252-
# Needed to be able to run conda index
253-
run: conda install conda-build
260+
- name: Install conda-index
261+
run: conda install conda-index
254262

255263
- name: Create conda channel
256264
run: |
@@ -270,8 +278,7 @@ jobs:
270278
FOR /F "tokens=* USEBACKQ" %%F IN (`python -c "%SCRIPT%"`) DO (
271279
SET PACKAGE_VERSION=%%F
272280
)
273-
conda create -n ${{ env.TEST_ENV_NAME }} ${{ env.PACKAGE_NAME }}=%PACKAGE_VERSION% python=${{ matrix.python }} numpy=${{ matrix.numpy }} -c ${{ env.GITHUB_WORKSPACE }}/channel ${{ env.CHANNELS }} --only-deps --dry-run > lockfile
274-
more lockfile
281+
conda install -n ${{ env.TEST_ENV_NAME }} ${{ env.PACKAGE_NAME }}=%PACKAGE_VERSION% python=${{ matrix.python }} numpy=${{ matrix.numpy }} -c ${{ env.GITHUB_WORKSPACE }}/channel ${{ env.CHANNELS }} --only-deps --dry-run > lockfile
275282
276283
- name: Cache conda packages
277284
uses: actions/cache@cdf6c1fa76f9f475f3d7449005a359c84ca0f306 # v5.0.3
@@ -300,5 +307,5 @@ jobs:
300307
301308
- name: Run tests
302309
run: |
303-
conda activate -n ${{ env.TEST_ENV_NAME }}
310+
conda activate ${{ env.TEST_ENV_NAME }}
304311
pytest -v --pyargs ${{ env.MODULE_NAME }}

.github/workflows/conda-package.yml

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -247,10 +247,10 @@ jobs:
247247
- uses: conda-incubator/setup-miniconda@fc2d68f6413eb2d87b895e92f8584b5b94a10167 # v3.3.0
248248
with:
249249
miniforge-version: latest
250-
use-mamba: 'true'
251-
conda-remove-defaults: 'true'
252-
activate-environment: 'test'
253-
python-version: '3.13' # no python 3.14 support by conda-index
250+
channels: conda-forge
251+
conda-remove-defaults: true
252+
activate-environment: ${{ env.TEST_ENV_NAME }}
253+
python-version: ${{ matrix.python }}
254254

255255
- name: Install conda-index
256256
run: conda install conda-index
@@ -274,8 +274,7 @@ jobs:
274274
FOR /F "tokens=* USEBACKQ" %%F IN (`python -c "%SCRIPT%"`) DO (
275275
SET PACKAGE_VERSION=%%F
276276
)
277-
conda create -n ${{ env.TEST_ENV_NAME }} ${{ env.PACKAGE_NAME }}=%PACKAGE_VERSION% python=${{ matrix.python }} numpy=${{ matrix.numpy }} -c ${{ env.GITHUB_WORKSPACE }}/channel ${{ env.CHANNELS }} --only-deps --dry-run > lockfile
278-
more lockfile
277+
conda install -n ${{ env.TEST_ENV_NAME }} ${{ env.PACKAGE_NAME }}=%PACKAGE_VERSION% python=${{ matrix.python }} numpy=${{ matrix.numpy }} -c ${{ env.GITHUB_WORKSPACE }}/channel ${{ env.CHANNELS }} --only-deps --dry-run > lockfile
279278
280279
- name: Cache conda packages
281280
uses: actions/cache@cdf6c1fa76f9f475f3d7449005a359c84ca0f306 # v5.0.3
@@ -302,12 +301,12 @@ jobs:
302301
)
303302
SET "WORKAROUND_DEPENDENCIES=intel-openmp"
304303
conda create -n ${{ env.TEST_ENV_NAME }} ${{ env.PACKAGE_NAME }}=%PACKAGE_VERSION% %WORKAROUND_DEPENDENCIES% pytest python=${{ matrix.python }} numpy=${{ matrix.numpy }} -c ${{ env.GITHUB_WORKSPACE }}/channel ${{ env.CHANNELS }}
305-
conda activate -n ${{ env.TEST_ENV_NAME }}
304+
conda activate ${{ env.TEST_ENV_NAME }}
306305
307306
# Test installed packages
308307
conda list
309308
310309
- name: Run tests
311310
run: |
312-
conda activate -n "${{ env.TEST_ENV_NAME }}"
311+
conda activate "${{ env.TEST_ENV_NAME }}"
313312
pytest -v --pyargs ${{ env.MODULE_NAME }}

0 commit comments

Comments
 (0)